+0300, Yoni Bettan wrote:
The main goal is to create an example to be used as template or
guideline for contributors when they wish to create a new virtio
device and to document "the right way" to do so.
It consists of several parts:
1. The device specification
* it can
device specification
- device implementation
- device driver for linux
* it can be found at https://howtovms.wordpress.com
Signed-off-by: Yoni Bettan
---
RFC -> V1:
* Updated the commit message to be more informative about the full
working flow.
On 4/10/19 10:25 PM, Stefan Hajnoczi wrote:
On Wed, Apr 10, 2019 at 4:45 PM Yoni Bettan wrote:
On 4/9/19 4:17 PM, Stefan Hajnoczi wrote:
On Mon, Apr 01, 2019 at 02:18:43PM +0300, Yoni Bettan wrote:
There are multiple problems with the code, but the larger issue is that
this example device
On 4/9/19 4:17 PM, Stefan Hajnoczi wrote:
On Mon, Apr 01, 2019 at 02:18:43PM +0300, Yoni Bettan wrote:
The main goal is to add an example device to Qemu to be used as template or
guideline for contributors when they wish to create a new virtio device.
Another reason for this device is to
d at https://howtovms.wordpress.com.
scripts/checkpatch.pl have some errors do to "//" (old style one line comment),
those lines contains FIXMEs for the next version and will be removed.
Signed-off-by: Yoni Bettan
---
hw/virtio/Makefile.objs | 1 +
hw/vir
guide to write a new virtio device.
This blog can be found at https://howtovms.wordpress.com.
Signed-off-by: Yoni Bettan
---
Some questions I would like hear your opinion on:
1. How in your opinion can we make this device compile with qemu to ensure it
won't break but without enabli
On 8/29/18 4:07 PM, Eduardo Habkost wrote:
Hi,
Thanks for the patch.
On Tue, Aug 28, 2018 at 10:24:26AM +0300, Yoni Bettan wrote:
- this is a simple example of how to write a pci device that supports
portio, mmio, irq and dma
Can we have some documentation on what are the
Please ignore this message as a V2 was already sent.
Thanks,
Yoni.
On 9/2/18 3:36 PM, Yoni Bettan wrote:
This patch make INFO files (e.g. README, CODING_STYLE etc) much more
readable when watched from GitHub GUI.
./VERSION and ./MAINTAINERS were leave untouched otherwise
./scripts
On 9/2/18 8:13 PM, Peter Maydell wrote:
On 2 September 2018 at 13:36, Yoni Bettan wrote:
This patch make INFO files (e.g. README, CODING_STYLE etc) much more
readable when watched from GitHub GUI.
./VERSION and ./MAINTAINERS were leave untouched otherwise
./scripts/get_maintainer.pl breaks
Signed-off-by: Yoni Bettan
---
HACKING => HACKING.md | 186 ++
1 file changed, 97 insertions(+), 89 deletions(-)
rename HACKING => HACKING.md (53%)
diff --git a/HACKING b/HACKING.md
similarity index 53%
rename from HACKING
rename to HACKING.md
Signed-off-by: Yoni Bettan
---
CODING_STYLE => CODING_STYLE.md | 151 +---
1 file changed, 80 insertions(+), 71 deletions(-)
rename CODING_STYLE => CODING_STYLE.md (50%)
diff --git a/CODING_STYLE b/CODING_STYLE.md
similarity index 50%
rename from CODING_STYLE
Also updated scripts/checkpatch.pl and made it reference to README.md
instead of README.
Signed-off-by: Yoni Bettan
---
README => README.md | 89 ++-
scripts/checkpatch.pl | 2 +-
2 files changed, 46 insertions(+), 45 deletions(-)
rename REA
from GNU and not QEMU.
Visualization of the change can be found at
https://github.com/ybettan/qemu/tree/md.
NOTE:
This last part of the message should be removed from the commit message
since I will remove the 'md' branch from my fork if the patch is
accepted.
Yoni Bettan (3):
Signed-off-by: Yoni Bettan
---
HACKING => HACKING.md | 186 ++
1 file changed, 97 insertions(+), 89 deletions(-)
rename HACKING => HACKING.md (53%)
diff --git a/HACKING b/HACKING.md
similarity index 53%
rename from HACKING
rename to HACKING.md
not QEMU.
Visualization of the change can be found at
https://github.com/ybettan/qemu/tree/md.
NOTE:
This last part of the message should be removed from the commit message
since I will remove the 'md' brance from my fork if the patch is
accepted.
Yoni Bettan (4):
README.md : Refo
Signed-off-by: Yoni Bettan
---
README => README.md | 87 +++--
1 file changed, 44 insertions(+), 43 deletions(-)
rename README => README.md (68%)
diff --git a/README b/README.md
similarity index 68%
rename from README
rename to README.md
index 49a9
Signed-off-by: Yoni Bettan
---
CODING_STYLE => CODING_STYLE.md | 151 +---
1 file changed, 80 insertions(+), 71 deletions(-)
rename CODING_STYLE => CODING_STYLE.md (50%)
diff --git a/CODING_STYLE b/CODING_STYLE.md
similarity index 50%
rename from CODING_STYLE
Signed-off-by: Yoni Bettan
---
LICENSE => LICENSE.md | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
rename LICENSE => LICENSE.md (90%)
diff --git a/LICENSE b/LICENSE.md
similarity index 90%
rename from LICENSE
rename to LICENSE.md
index 0e0b4b9553..644e953429 100644
--- a/L
On 8/29/18 2:40 PM, Cornelia Huck wrote:
On Tue, 28 Aug 2018 10:24:26 +0300
Yoni Bettan wrote:
Thanks you for your review!
- this is a simple example of how to write a pci device that supports
portio, mmio, irq and dma
Do you also plan to add example code for MSI(-X)?
[Not
On 8/28/18 10:24 AM, Yoni Bettan wrote:
- this is a simple example of how to write a pci device that supports
portio, mmio, irq and dma
As the commit message miss a little bit of information I will add it
here and update
the commit message in the next Version.
The main goal is
- this is a simple example of how to write a pci device that supports
portio, mmio, irq and dma
Signed-off-by: Yoni Bettan
---
hw/pci/Makefile.objs | 1 +
hw/pci/pci_example.c | 309 +++
2 files changed, 310 insertions(+)
create mode 100644
On 04/20/2018 12:27 AM, Philippe Mathieu-Daudé wrote:
The SysBusDevice is the last DeviceClass::init user.
Instead of using
SysBusDeviceClass::realize
-> DeviceClass::realize
-> DeviceClass::init
-> sysbus_device_init
-> SysBusDeviceClass::init
Simpli
On 01/16/2018 02:34 PM, Yoni Bettan wrote:
according to Eduardo Habkost's commit fd3b02c889 all PCIEs now implement
INTERFACE_PCIE_DEVICE so we don't need is_express field anymore.
Devices that implements only INTERFACE_PCIE_DEVICE (is_express == 1)
or
devices that imple
by: Marcel Apfelbaum
Reviewed-by: Eduardo Habkost
Signed-off-by: Yoni Bettan
---
V5 --> V6 : rebased on Michael S. Tsirkin pci branch as requested.
V4 --> V5 : updated the patch to work with a new inserted device hw/xen/xen_pt.c
V3 --> V4 : added a comment on the devices to explain why
On 12/19/2017 12:21 PM, Laurent Vivier wrote:
Le 19/12/2017 à 11:11, Yoni Bettan a écrit :
it was added on 2008 902b3d5c39 when introduced cache-utils.[ch]
since then cache-utils.[ch] were removed but **envp was left
behind.
By the way "to be portable it is best to write main to tak
On 12/19/2017 12:11 PM, Yoni Bettan wrote:
it was added on 2008 902b3d5c39 when introduced cache-utils.[ch]
since then cache-utils.[ch] were removed but **envp was left
behind.
By the way "to be portable it is best to write main to take two
arguments, and use the value of environ"
ibc/manual/html_node/Program-\
Arguments.html#Program-Arguments
Signed-off-by: Yoni Bettan
---
V2 -> V3:
since ui/cocoa.c rename main() is using qemu_main() ,because it uses it
inside its main() function, the function qemu_main() can't be removed
V1 -> V2:
r
On 12/18/2017 05:21 PM, Yoni Bettan wrote:
according to Eduardo Habkost's commit fd3b02c889 all PCIEs now implement
INTERFACE_PCIE_DEVICE so we don't need is_express field anymore.
Devices that implements only INTERFACE_PCIE_DEVICE (is_express == 1)
or
devices that imple
On 12/18/2017 05:21 PM, Yoni Bettan wrote:
according to Eduardo Habkost's commit fd3b02c889 all PCIEs now implement
INTERFACE_PCIE_DEVICE so we don't need is_express field anymore.
Devices that implements only INTERFACE_PCIE_DEVICE (is_express == 1)
or
devices that imple
= 0)
where not affected by the change.
The only devices that were affected are those that are hybrid and also
had (is_express == 1) - therefor only:
- hw/vfio/pci.c
- hw/usb/hcd-xhci.c
- hw/xen/xen_pt.c
For those 3 I made sure that QEMU_PCI_CAP_EXPRESS is on in instance_init()
Signed-of
On 12/18/2017 02:54 PM, Peter Maydell wrote:
On 18 December 2017 at 12:49, Yoni Bettan wrote:
* it was added on 2008 902b3d5c392bb6f48ef340ad8ecc3311705d2800
when introduced cache-utils.[ch]
* since then cache-utils.[ch] were removed but **envp was left
e two
arguments, and use the value of environ" according to
https://www.gnu.org/software/libc/manual/html_node/Program-\
Arguments.html#Program-Arguments
Signed-off-by: Yoni Bettan
---
include/qemu-common.h | 5 -
linux-user/main.c | 2 +-
ui/cocoa.m
On 11/21/2017 09:30 AM, Laurent Vivier wrote:
Le 21/11/2017 à 07:41, Yoni Bettan a écrit :
* it was added on 2008 902b3d5c392bb6f48ef340ad8ecc3311705d2800
when introduced cache-utils.[ch]
* since then cache-utils.[ch] were removed but **envp was left
- hw/usb/hcd-xhci.c
For both I made sure that QEMU_PCI_CAP_EXPRESS is on
Signed-off-by: Yoni Bettan
---
docs/pcie_pci_bridge.txt | 2 +-
hw/block/nvme.c| 1 -
hw/net/e1000e.c| 1 -
hw/pci-bridge/pcie_pci_bridge.c| 1 -
hw/
On 12/11/2017 04:19 PM, Eduardo Habkost wrote:
On Mon, Dec 11, 2017 at 03:11:39PM +0200, Yoni Bettan wrote:
On 12/07/2017 10:58 PM, Eduardo Habkost wrote:
On Tue, Dec 05, 2017 at 07:17:06PM +0200, Yoni Bettan wrote:
* according to Eduardo Habkost's c
On 12/07/2017 10:58 PM, Eduardo Habkost wrote:
On Tue, Dec 05, 2017 at 07:17:06PM +0200, Yoni Bettan wrote:
* according to Eduardo Habkost's commit
fd3b02c8896d597dd8b9e053dec579cf0386aee1
* since all PCIEs now implement INTERFACE_PCIE_DEVICE we
On 12/05/2017 07:17 PM, Yoni Bettan wrote:
* according to Eduardo Habkost's commit
fd3b02c8896d597dd8b9e053dec579cf0386aee1
* since all PCIEs now implement INTERFACE_PCIE_DEVICE we
don't need this field anymore
* Devices that
- hw/usb/hcd-xhci.c
For both I made sure that QEMU_PCI_CAP_EXPRESS is on
Signed-off-by: Yoni Bettan
---
docs/pcie_pci_bridge.txt | 2 +-
hw/block/nvme.c| 1 -
hw/net/e1000e.c| 1 -
hw/pci-bridge/pcie_pci_bridge.c| 1 -
hw/
On 12/04/2017 09:46 PM, Philippe Mathieu-Daudé wrote:
Hi Yoni, Eduardo, Markus,
On 12/04/2017 07:18 AM, Yoni Bettan wrote:
* according to Eduardo Habkost's commit
fd3b02c8896d597dd8b9e053dec579cf0386aee1
* since all PCIEs now implement INTERFACE_PCIE_DEVI
- hw/usb/hcd-xhci.c
For both i made sure that pci_dev->cap_present |= QEMU_PCI_CAP_EXPRESS
Signed-off-by: Yoni Bettan
---
docs/pcie_pci_bridge.txt | 2 +-
hw/block/nvme.c| 1 -
hw/net/e1000e.c| 1 -
hw/pci-bridge/pcie
On 11/28/2017 07:51 AM, Yoni Bettan wrote:
* according to Eduardo Habkost's commit
fd3b02c8896d597dd8b9e053dec579cf0386aee1
* since all PCIEs now implement INTERFACE_PCIE_DEVICE we
don't need this field anymore
Hi, please discard this seri
Signed-off-by: Yoni Bettan
---
hw/pci/pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/pci/pci.c b/hw/pci/pci.c
index 02f6f2f37a..d2bf749251 100644
--- a/hw/pci/pci.c
+++ b/hw/pci/pci.c
@@ -2014,7 +2014,7 @@ static void pci_qdev_realize(DeviceState *qdev, Error
* according to Eduardo Habkost's commit
fd3b02c8896d597dd8b9e053dec579cf0386aee1
* since all PCIEs now implement INTERFACE_PCIE_DEVICE we
don't need this field anymore
Signed-off-by: Yoni Bettan
---
hw/block/nvme.c| 1 -
hw/ne
* according to Eduardo Habkost's commit
fd3b02c8896d597dd8b9e053dec579cf0386aee1
* since all PCIEs now implement INTERFACE_PCIE_DEVICE we
don't need this field anymore
Signed-off-by: Yoni Bettan
---
hw/block/nvme.c| 1 -
hw/ne
* it was added on 2008 902b3d5c392bb6f48ef340ad8ecc3311705d2800
when introduced cache-utils.[ch]
* since then cache-utils.[ch] were removed but **envp was left
behind
Signed-off-by: Yoni Bettan
---
linux-user/main.c | 2 +-
vl.c | 6 +++---
2
Moved vmgenid from uncategorized to misc category in QEMU help menu
Signed-off-by: Yoni Bettan
---
hw/acpi/vmgenid.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/acpi/vmgenid.c b/hw/acpi/vmgenid.c
index a32b847fe0..876723a4ce 100644
--- a/hw/acpi/vmgenid.c
+++ b/hw/acpi/vmgenid.c
46 matches
Mail list logo