Re: [PATCH 1/6] migration: Add multi-thread compress method

2020-11-30 Thread Zeyu Jin
On 2020/11/30 16:35, Markus Armbruster wrote: > Zeyu Jin writes: > >> On 2020/11/27 17:48, Markus Armbruster wrote: >>> Kevin, Max, suggest to skip right to Qcow2CompressionType. >>> >>> Zeyu Jin writes: >>> >>>> A multi-thr

Re: [PATCH v2 4/6] migration: Add zstd support in multi-thread compression

2020-11-30 Thread Zeyu Jin
On 2020/12/1 0:43, Eric Blake wrote: > On 11/27/20 3:32 AM, Zeyu Jin wrote: >> This patch enables zstd option in multi-thread compression. >> >> Signed-off-by: Zeyu Jin >> Signed-off-by: Ying Fang >> --- > >> +++ b/qapi/migration.json >&

Re: [PATCH v2 0/6] migration: Multi-thread compression method support

2020-11-30 Thread Zeyu Jin
On 2020/12/1 0:42, Eric Blake wrote: > On 11/27/20 3:36 AM, Zeyu Jin wrote: > > Meta-comment: you appear to be having problems threading your series; > I've now seen three separate cover letters (RFC v1, v2 with no subject, > v2 with subject) and two series where each patch was a

Re: [RFC PATCH 4/6] migration: Add zstd support in multi-thread compression

2020-11-27 Thread Zeyu Jin
On 2020/11/27 20:10, Markus Armbruster wrote: > Zeyu Jin writes: > >> This patch enables zstd option in multi-thread compression. >> >> Signed-off-by: Zeyu Jin >> Signed-off-by: Ying Fang > [...] >> diff --git a/qapi/migration.json b/qapi/migration.json

Re: [PATCH 1/6] migration: Add multi-thread compress method

2020-11-27 Thread Zeyu Jin
On 2020/11/27 17:48, Markus Armbruster wrote: > Kevin, Max, suggest to skip right to Qcow2CompressionType. > > Zeyu Jin writes: > >> A multi-thread compress method parameter is added to hold the method we >> are going to use. By default the 'zlib' method is used to maint

回复

2020-11-27 Thread Zeyu Jin
On 2020/11/27 17:48, Markus Armbruster wrote: > Kevin, Max, suggest to skip right to Qcow2CompressionType. > > Zeyu Jin writes: > >> A multi-thread compress method parameter is added to hold the method we >> are going to use. By default the 'zlib' method is used to maint

[PATCH v2 0/6] migration: Multi-thread compression method support

2020-11-27 Thread Zeyu Jin
)| 1576866|736117 | +-+--+-+ | throughput(mbps) | 172.06 |137.16 | +-+--+-+ | total ram(kB) | 33685952 |33685952 | +-+--+-+ Zeyu

[PATCH v2 5/6] migration: Add compress_level sanity check

2020-11-27 Thread Zeyu Jin
Zlib compression has level from 1 to 9. However Zstd compression has level from 1 to 22 (level >= 20 not recommanded). Let's do sanity check here to make sure a vaild compress_level is given by user. Signed-off-by: Zeyu Jin Signed-off-by: Ying Fang --- migration/migration.c |

[PATCH v2 4/6] migration: Add zstd support in multi-thread compression

2020-11-27 Thread Zeyu Jin
This patch enables zstd option in multi-thread compression. Signed-off-by: Zeyu Jin Signed-off-by: Ying Fang --- hw/core/qdev-properties-system.c | 2 +- migration/ram.c | 128 ++- qapi/migration.json | 2 +- 3 files changed, 129

[PATCH v2 3/6] migration: Add multi-thread compress ops

2020-11-27 Thread Zeyu Jin
Add the MigrationCompressOps and MigrationDecompressOps structures to make the compression method configurable for multi-thread compression migration. Signed-off-by: Zeyu Jin Signed-off-by: Ying Fang parameters.decompress_threads; } +CompressMethod migrate_compress_method(void

[PATCH v2 6/6] doc: Update multi-thread compression doc

2020-11-27 Thread Zeyu Jin
Modify the doc to fit the previous changes. Signed-off-by: Zeyu Jin Signed-off-by: Ying Fang --- docs/multi-thread-compression.txt | 31 ++- 1 file changed, 18 insertions(+), 13 deletions(-) diff --git a/docs/multi-thread-compression.txt b/docs/multi-thread

[PATCH v2 1/6] migration: Add multi-thread compress method

2020-11-27 Thread Zeyu Jin
A multi-thread compress method parameter is added to hold the method we are going to use. By default the 'zlib' method is used to maintain the compatibility as before. Signed-off-by: Zeyu Jin Signed-off-by: Ying Fang --- hw/core/qdev-properties-system.c | 11 +++ include/hw/qdev

[PATCH v2 2/6] migration: Refactoring multi-thread compress migration

2020-11-27 Thread Zeyu Jin
. Simplify the function input arguments for compression and decompression. Wrap the input into the param structure which already exists. This change also makes the function much more flexible for other compression methods. Signed-off-by: Zeyu Jin Signed-off-by: Ying Fang --- migration/qemu-file.c | 62

[PATCH v2 0/6]

2020-11-27 Thread Zeyu Jin
)| 1576866|736117 | +-+--+-+ | throughput(mbps) | 172.06 |137.16 | +-+--+-+ | total ram(kB) | 33685952 |33685952 | +-+--+-+ Zeyu

[RFC PATCH 6/6] doc: Update multi-thread compression doc

2020-11-26 Thread Zeyu Jin
Modify the doc to fit the previous changes. Signed-off-by: Zeyu Jin Signed-off-by: Ying Fang --- docs/multi-thread-compression.txt | 31 ++- 1 file changed, 18 insertions(+), 13 deletions(-) diff --git a/docs/multi-thread-compression.txt b/docs/multi-thread

[RFC PATCH 5/6] migration: Add compress_level sanity check

2020-11-26 Thread Zeyu Jin
Zlib compression has level from 1 to 9. However Zstd compression has level from 1 to 22 (level >= 20 not recommanded). Let's do sanity check here to make sure a vaild compress_level is given by user. Signed-off-by: Zeyu Jin Signed-off-by: Ying Fang --- migration/migration.c |

[RFC PATCH 3/6] migration: Add multi-thread compress ops

2020-11-26 Thread Zeyu Jin
Add the MigrationCompressOps and MigrationDecompressOps structures to make the compression method configurable for multi-thread compression migration. Signed-off-by: Zeyu Jin Signed-off-by: Ying Fang parameters.decompress_threads; } +CompressMethod migrate_compress_method(void

[RFC PATCH 4/6] migration: Add zstd support in multi-thread compression

2020-11-26 Thread Zeyu Jin
This patch enables zstd option in multi-thread compression. Signed-off-by: Zeyu Jin Signed-off-by: Ying Fang --- hw/core/qdev-properties-system.c | 2 +- migration/ram.c | 128 ++- qapi/migration.json | 2 +- 3 files changed, 129

[PATCH 1/6] migration: Add multi-thread compress method

2020-11-26 Thread Zeyu Jin
A multi-thread compress method parameter is added to hold the method we are going to use. By default the 'zlib' method is used to maintain the compatibility as before. Signed-off-by: Zeyu Jin Signed-off-by: Ying Fang --- hw/core/qdev-properties-system.c | 11 +++ include/hw/qdev

[RFC PATCH 2/6] migration: Refactoring multi-thread compress migration

2020-11-26 Thread Zeyu Jin
. Simplify the function input arguments for compression and decompression. Wrap the input into the param structure which already exists. This change also makes the function much more flexible for other compression methods. Signed-off-by: Zeyu Jin Signed-off-by: Ying Fang --- migration/qemu-file.c | 62

[RFC PATCH 0/6] migration: Multi-thread compression method support

2020-11-26 Thread Zeyu Jin
)| 1576866|736117 | +-+--+-+ | throughput(mbps) | 172.06 |137.16 | +-+--+-+ | total ram(kB) | 33685952 |33685952 | +-+--+-+ Zeyu

Re: [RFC PATCH 0/6] migration: Multi-thread compression with zstd method

2020-11-15 Thread Zeyu Jin
On 2020/11/9 17:08, Zeyu Jin wrote: > Currently we have both multi-thread compression and multifd to optimize > live migration in Qemu. Mulit-thread compression deals with the situation > where network bandwith is limited but cpu resource adequate. Multifd instead > aims to take fu

Re: [RFC PATCH 1/6] migration: Add multi-thread compress method

2020-11-09 Thread Zeyu Jin
On 2020/11/9 23:57, Eric Blake wrote: > On 11/9/20 3:08 AM, Zeyu Jin wrote: >> A multi-thread compress method parameter is added to hold the method we >> are going to use. By default the 'zlib' method is used to maintain the >> compatibility as before. >> >> Signe

[RFC PATCH 6/6] doc: Update multi-thread compression doc

2020-11-09 Thread Zeyu Jin
Modify the doc to fit the previous changes. Signed-off-by: Zeyu Jin Signed-off-by: Ying Fang --- docs/multi-thread-compression.txt | 31 ++- 1 file changed, 18 insertions(+), 13 deletions(-) diff --git a/docs/multi-thread-compression.txt b/docs/multi-thread

[RFC PATCH 5/6] migration: Add compress_level sanity check

2020-11-09 Thread Zeyu Jin
Zlib compression has level from 1 to 9. However Zstd compression has level from 1 to 22 (level >= 20 not recommanded). Let's do sanity check here to make sure a vaild compress_level is given by user. Signed-off-by: Zeyu Jin Signed-off-by: Ying Fang --- migration/migration.c |

[RFC PATCH 1/6] migration: Add multi-thread compress method

2020-11-09 Thread Zeyu Jin
A multi-thread compress method parameter is added to hold the method we are going to use. By default the 'zlib' method is used to maintain the compatibility as before. Signed-off-by: Zeyu Jin Signed-off-by: Ying Fang --- hw/core/qdev-properties-system.c | 11 +++ include/hw/qdev

[RFC PATCH 3/6] migration: Add multi-thread compress ops

2020-11-09 Thread Zeyu Jin
Add the MigrationCompressOps and MigrationDecompressOps structures to make the compression method configurable for multi-thread compression migration. Signed-off-by: Zeyu Jin Signed-off-by: Ying Fang parameters.decompress_threads; } +CompressMethod migrate_compress_method(void

[RFC PATCH 0/6] migration: Multi-thread compression with zstd method

2020-11-09 Thread Zeyu Jin
)| 1576866|736117 | +-+--+-+ | throughput(mbps) | 172.06 |137.16 | +-+--+-+ | total ram(kB) | 33685952 |33685952 | +-+--+-+ Zeyu

[RFC PATCH 2/6] migration: Refactoring multi-thread compress migration

2020-11-09 Thread Zeyu Jin
. Simplify the function input arguments for compression and decompression. Wrap the input into the param structure which already exists. This change also makes the function much more flexible for other compression methods. Signed-off-by: Zeyu Jin Signed-off-by: Ying Fang --- migration/qemu-file.c | 62

[RFC PATCH 4/6] migration: Add zstd support in multi-thread compression

2020-11-09 Thread Zeyu Jin
This patch enables zstd option in multi-thread compression. Signed-off-by: Zeyu Jin Signed-off-by: Ying Fang --- hw/core/qdev-properties-system.c | 2 +- migration/ram.c | 128 ++- qapi/migration.json | 2 +- 3 files changed, 129