[PULL 7/7] tests/acpi: disallow acpi test data updates

2024-09-17 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- tests/qtest/bios-tables-test-allowed-diff.h | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h index 00137acabc71..dfb8523c8bf4 100644 --- a/tests/qtest/bios-tables-test

[PULL 0/7] Edk2 stable202408 20240917 patches

2024-09-17 Thread Gerd Hoffmann
a (address changed due to firmware size change). ---- Gerd Hoffmann (6): tests/acpi: allow acpi test data updates update submodule and version file to edk2-stable202408 update binaries to edk2-stable202408 add loongarch binarie

[PULL 2/7] update submodule and version file to edk2-stable202408

2024-09-17 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- roms/edk2 | 2 +- roms/edk2-version | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/roms/edk2 b/roms/edk2 index edc6681206c1..b158dad150bf 16 --- a/roms/edk2 +++ b/roms/edk2 @@ -1 +1 @@ -Subproject commit

[PULL 6/7] tests/acpi: update aarch64/virt/SSDT.memhp

2024-09-17 Thread Gerd Hoffmann
Address (and checksum) change due to firmware image size change. DefinitionBlock ("", "SSDT", 1, "BOCHS ", "NVDIMM", 0x0001) [ ... ] -Name (MEMA, 0x43C8) +Name (MEMA, 0x43DA) Signed-off-by: Gerd Hoffmann --- tests/data/acpi/aarch64/

[PULL 4/7] roms: Support compile the efi bios for loongarch

2024-09-17 Thread Gerd Hoffmann
: <20240724022245.1317884-1-lixiang...@loongson.cn> Signed-off-by: Gerd Hoffmann --- docs/system/loongarch/virt.rst | 2 +- meson.build | 2 +- pc-bios/descriptors/60-edk2-loongarch64.json | 31 pc-bios/descriptors/meson.build | 3

[PULL 1/7] tests/acpi: allow acpi test data updates

2024-09-17 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- tests/qtest/bios-tables-test-allowed-diff.h | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h index dfb8523c8bf4..00137acabc71 100644 --- a/tests/qtest/bios-tables-test

Re: [PULL 0/4] Edk2 stable202408 20240916 patches

2024-09-17 Thread Gerd Hoffmann
Hi, > acpi-test: Warning! SSDT binary file mismatch. Actual Address has changed due to firmware size change. I'll respin with acpi test data updates included. take care, Gerd

[PULL 1/4] update submodule and version file to edk2-stable202408

2024-09-16 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- roms/edk2 | 2 +- roms/edk2-version | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/roms/edk2 b/roms/edk2 index edc6681206c1..b158dad150bf 16 --- a/roms/edk2 +++ b/roms/edk2 @@ -1 +1 @@ -Subproject commit

[PULL 3/4] roms: Support compile the efi bios for loongarch

2024-09-16 Thread Gerd Hoffmann
: <20240724022245.1317884-1-lixiang...@loongson.cn> Signed-off-by: Gerd Hoffmann --- docs/system/loongarch/virt.rst | 2 +- meson.build | 2 +- pc-bios/descriptors/60-edk2-loongarch64.json | 31 pc-bios/descriptors/meson.build | 3

[PULL 0/4] Edk2 stable202408 20240916 patches

2024-09-16 Thread Gerd Hoffmann
stable tag ---- Gerd Hoffmann (3): update submodule and version file to edk2-stable202408 update binaries to edk2-stable202408 add loongarch binaries for edk2-stable202408 Xianglai Li (1): roms: Support compile the efi bios for loongarch docs/system/loongarc

Re: qemu emulation for USB ports of Allwinner H3

2024-09-09 Thread Gerd Hoffmann
On Sun, Sep 08, 2024 at 11:36:18AM GMT, Guenter Roeck wrote: > Hi, > > the Allwinner H3 USB port qemu emulation creates separate USB ports > for its EHCI and OHCI controllers, resulting in a total of 8 USB ports. > From the orangepi-pc emulation: > > # lsusb > Bus 005 Device 001: ID 1d6b:0002 > B

[PATCH v2 5/5] x86/loader: add -shim option

2024-09-05 Thread Gerd Hoffmann
Add new -shim command line option, wire up for the x86 loader. When specified load shim into the new "etc/boot/shim" fw_cfg file. Needs OVMF changes too to be actually useful. Signed-off-by: Gerd Hoffmann --- include/hw/boards.h | 1 + hw/core/machine.c| 20 +++

[PATCH v2 2/5] x86/loader: only patch linux kernels

2024-09-05 Thread Gerd Hoffmann
OVMF happily loads and runs not only linux kernels but any efi binary via direct kernel boot. Note: Breaking the secure boot verification is a problem for linux kernels too, but fixed that is left for another day ... Signed-off-by: Gerd Hoffmann --- hw/i386/x86-common.c | 2 +- 1 file chang

[PATCH v2 1/5] vl: fix qemu_validate_options() indention

2024-09-05 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- system/vl.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/system/vl.c b/system/vl.c index 01b8b8e77ad1..302ad81285b7 100644 --- a/system/vl.c +++ b/system/vl.c @@ -2426,15 +2426,15 @@ static void qemu_validate_options(const

[PATCH v2 3/5] x86/loader: read complete kernel

2024-09-05 Thread Gerd Hoffmann
. Signed-off-by: Gerd Hoffmann --- hw/i386/x86-common.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/hw/i386/x86-common.c b/hw/i386/x86-common.c index b52903c47fec..82137e053ae0 100644 --- a/hw/i386/x86-common.c +++ b/hw/i386/x86-common.c @@ -893,7 +893,6 @@ void

[PATCH v2 4/5] x86/loader: expose unpatched kernel

2024-09-05 Thread Gerd Hoffmann
Add a new "etc/boot/kernel" fw_cfg file, containing the kernel without the setup header patches. Intended use is booting in UEFI with secure boot enabled, where the setup header patching breaks secure boot verification. Needs OVMF changes too to be actually useful. Signed-off-by: Ger

[PATCH v2 0/5] x86/loader: secure boot support for direct kernel load

2024-09-05 Thread Gerd Hoffmann
cure-boot/ With everything in place it is possible to use direct kernel load with secure boot enabled. take care, Gerd Gerd Hoffmann (5): vl: fix qemu_validate_options() indention x86/loader: only patch linux kernels x86/loader: read complete kernel x86/loader: expose unpatched kernel

Re: [PATCH] hw/audio/virtio-sound: fix heap buffer overflow

2024-09-02 Thread Gerd Hoffmann
> > Remove the set_config function from the virtio_snd class. > > This also prevents a heap buffer overflow. See QEMU issue #2296. > > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2296 > Signed-off-by: Volker Rümelin Acked-by: Gerd Hoffmann

Re: [PATCH v10 1/8] memory: prevent dma-reentracy issues

2024-08-28 Thread Gerd Hoffmann
Hi, > But I think unexpected access shouldn't be there in the 1st place, > so guard looks pretty legit at this point. > Lets see what Gerd finds out from edk2 point of view. CPU eject happens /after/ SMM syncronisation, when CPUs are on their way back into normal mode: * The boot processor wi

Re: [PATCH v4 19/34] modules: check arch on qom lookup

2024-08-28 Thread Gerd Hoffmann
On Tue, Aug 27, 2024 at 05:37:00PM GMT, Philippe Mathieu-Daudé wrote: > Hi, > > (old patch) > > On 24/6/21 12:38, Gerd Hoffmann wrote: > > With target-specific modules we can have multiple modules implementing > > the same object. Therefore we have to check the target

Re: [PATCH for-9.2 v6 04/12] pci-ids.rst: add Red Hat pci-id for RISC-V IOMMU device

2024-08-21 Thread Gerd Hoffmann
D. > > [1] https://github.com/riscv-non-isa/riscv-iommu/releases/tag/v1.0.0 > > Cc: Gerd Hoffmann > Signed-off-by: Daniel Henrique Barboza > Reviewed-by: Frank Chang Reviewed-by: Gerd Hoffmann

Re: [PATCH] roms: Support compile the efi bios for loongarch

2024-08-21 Thread Gerd Hoffmann
On Wed, Jul 24, 2024 at 10:22:45AM GMT, Xianglai Li wrote: > Added loongarch UEFI BIOS support to compiled scripts. > But now, the UEFI code of loongarch virtual machine has been migrated > from edK2-platform to edk2 repository. The migration work was completed > and merged into edk2 main line o

Re: [v2 1/1] hw/i386/acpi-build: add OSHP method support for SHPC driver load

2024-07-01 Thread Gerd Hoffmann
Hi, > > for SHPC on PXB see, > > commit d10dda2d60 hw/pci-bridge: disable SHPC in PXB > > > > it seems that enabling SHPC on PXB in QEMU is not enough, > > UEFI needs to support that as well > > (CCing Gerd to check whether it is possible at all) Hmm, can't give a quick answer on that. From th

Re: [PATCH v3 02/15] uefi-test-tools: Add support for python based build script

2024-06-24 Thread Gerd Hoffmann
le as > required to support the python based build script. > > Signed-off-by: Sunil V L Acked-by: Gerd Hoffmann

Re: [PATCH v3 2/4] usb/hub: mark as deprecated

2024-06-14 Thread Gerd Hoffmann
Hi, > > This does seem quite aggressive because there may be cases when users > > explicitly want to use old devices. Maybe there is need for a third > > state (better_alternatives?) so we can steer users away from old command > > lines they may have picked up from the web to the modern alternat

Re: [PATCH v3 2/4] usb/hub: mark as deprecated

2024-06-14 Thread Gerd Hoffmann
On Thu, Jun 13, 2024 at 03:49:23PM GMT, Alex Bennée wrote: > Daniel P. Berrangé writes: > > > I don't want to loose that clear & easily understood meaning, by overloading > > "deprecated" for scenarios like "it is sometimes better to use a different > > device instead of this one, depending on fa

[PATCH v3 1/4] qom: allow to mark objects as deprecated or not secure.

2024-06-06 Thread Gerd Hoffmann
Add flags to ObjectClass for objects which are deprecated or not secure. Add 'deprecated' and 'not-secure' bools to ObjectTypeInfo, report in 'qom-list-types'. Print the flags when listing devices via '-device help'. Signed-off-by: Gerd Hoffmann --- in

[PATCH v3 4/4] qdev: add device policy [RfC]

2024-06-06 Thread Gerd Hoffmann
at object level, especially the 'deny' part of it. TODO: add a command line option to actually set these policies. Comments are welcome. Signed-off-by: Gerd Hoffmann --- hw/core/qdev.c | 60 +- 1 file changed, 59 insertions(+), 1 del

[PATCH v3 0/4] allow to deprecate objects and devices

2024-06-06 Thread Gerd Hoffmann
r devices with flags. v2: - pick up reviews. - drop ohci patch. - add cirrus vga patch. Gerd Hoffmann (4): qom: allow to mark objects as deprecated or not secure. usb/hub: mark as deprecated vga/cirrus: mark as not secure qdev: add device policy [RfC] include/qom/object.h|

[PATCH v3 3/4] vga/cirrus: mark as not secure

2024-06-06 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/display/cirrus_vga.c | 1 + hw/display/cirrus_vga_isa.c | 1 + 2 files changed, 2 insertions(+) diff --git a/hw/display/cirrus_vga.c b/hw/display/cirrus_vga.c index 150883a97166..1f4c55b21415 100644 --- a/hw/display/cirrus_vga.c +++ b/hw/display

[PATCH v3 2/4] usb/hub: mark as deprecated

2024-06-06 Thread Gerd Hoffmann
The hub supports only USB 1.1. When running out of usb ports it is in almost all cases the much better choice to add another usb host adapter (or increase the number of root ports when using xhci) instead of using the usb hub. Signed-off-by: Gerd Hoffmann --- hw/usb/dev-hub.c | 1 + 1 file

[PATCH v3 1/3] stdvga: fix screen blanking

2024-06-05 Thread Gerd Hoffmann
/qemu-project/qemu/-/issues/2067 Signed-off-by: Gerd Hoffmann --- hw/display/vga.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/hw/display/vga.c b/hw/display/vga.c index 30facc6c8e33..474b6b14c327 100644 --- a/hw/display/vga.c +++ b/hw/display/vga.c @@ -1762,6 +1762,12 @@ static void

[PATCH v3 2/3] ui+display: rename is_placeholder() -> surface_is_placeholder()

2024-06-05 Thread Gerd Hoffmann
No functional change. Signed-off-by: Gerd Hoffmann --- include/ui/surface.h | 2 +- ui/console.c | 2 +- ui/sdl2-2d.c | 2 +- ui/sdl2-gl.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/include/ui/surface.h b/include/ui/surface.h index

[PATCH v3 0/3] stdvga: fix screen blanking

2024-06-05 Thread Gerd Hoffmann
Gerd Hoffmann (3): stdvga: fix screen blanking ui+display: rename is_placeholder() -> surface_is_placeholder() ui+display: rename is_buffer_shared() -> surface_is_allocated() include/ui/surface.h| 6 +++--- hw/display/qxl-render.c | 2 +- hw/display/vga.c

[PATCH v3 3/3] ui+display: rename is_buffer_shared() -> surface_is_allocated()

2024-06-05 Thread Gerd Hoffmann
Boolean return value is reversed, to align with QEMU_ALLOCATED_FLAG, so all callers must be adapted. Also rename share_surface variable in vga_draw_graphic() to reduce confusion. No functional change. Suggested-by: Marc-André Lureau Signed-off-by: Gerd Hoffmann --- include/ui/surface.h

Re: [PATCH v2 1/3] stdvga: fix screen blanking

2024-06-05 Thread Gerd Hoffmann
On Tue, Jun 04, 2024 at 10:27:18AM GMT, Marc-André Lureau wrote: > Hi > > > +if (is_buffer_shared(surface)) { > > Perhaps the suggestion to rename the function (in the following patch) > should instead be surface_is_allocated() ? that would match the actual > flag check. But callers would hav

Re: [PATCH v2 4/4] vga/cirrus: deprecate, don't build by default

2024-06-05 Thread Gerd Hoffmann
Hi, > > Upstream QEMU's scope is to emulate pretty much arbitrary hardware that > > may have existed at any point in time. Emulating Cirrus is very much > > in scope upstream, and even if there are other better VGA devices, that > > doesn't make emulation of Cirrus redundant. > > > > Downstream

[PATCH v2 3/3] ui+display: rename is_placeholder -> surface_is_placeholder

2024-06-03 Thread Gerd Hoffmann
No functional change. Signed-off-by: Gerd Hoffmann --- include/ui/surface.h | 2 +- ui/console.c | 2 +- ui/sdl2-2d.c | 2 +- ui/sdl2-gl.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/include/ui/surface.h b/include/ui/surface.h index

[PATCH v2 0/3] stdvga: fix screen blanking

2024-06-03 Thread Gerd Hoffmann
Gerd Hoffmann (3): stdvga: fix screen blanking ui+display: rename is_buffer_shared() -> surface_is_borrowed() ui+display: rename is_placeholder -> surface_is_placeholder include/ui/surface.h| 4 ++-- hw/display/qxl-render.c | 2 +- hw/display/vga.c| 14 ++--

[PATCH v2 1/3] stdvga: fix screen blanking

2024-06-03 Thread Gerd Hoffmann
/qemu-project/qemu/-/issues/2067 Signed-off-by: Gerd Hoffmann --- hw/display/vga.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/hw/display/vga.c b/hw/display/vga.c index 30facc6c8e33..474b6b14c327 100644 --- a/hw/display/vga.c +++ b/hw/display/vga.c @@ -1762,6 +1762,12 @@ static void

[PATCH v2 2/3] ui+display: rename is_buffer_shared() -> surface_is_borrowed()

2024-06-03 Thread Gerd Hoffmann
No functional change. Suggested-by: Marc-André Lureau Signed-off-by: Gerd Hoffmann --- include/ui/surface.h| 2 +- hw/display/qxl-render.c | 2 +- hw/display/vga.c| 10 +- hw/display/xenfb.c | 4 ++-- ui/console.c| 2 +- 5 files changed, 10 insertions

Re: [PATCH] stdvga: fix screen blanking

2024-06-03 Thread Gerd Hoffmann
On Mon, Jun 03, 2024 at 02:24:52PM GMT, Marc-André Lureau wrote: > Hi > > On Thu, May 30, 2024 at 3:05 PM Gerd Hoffmann wrote: > > > In case the display surface uses a shared buffer (i.e. uses vga vram > > directly instead of a shadow) go unshare the buffer before c

Re: [PATCH 4/5] x86/loader: expose unpatched kernel

2024-06-03 Thread Gerd Hoffmann
On Sun, Jun 02, 2024 at 09:26:09AM GMT, Michael S. Tsirkin wrote: > On Thu, Apr 11, 2024 at 11:48:28AM +0200, Gerd Hoffmann wrote: > > Add a new "etc/boot/kernel" fw_cfg file, containing the kernel without > > the setup header patches. Intended use is booting in UEFI wit

Re: [PATCH v2 4/4] vga/cirrus: deprecate, don't build by default

2024-05-30 Thread Gerd Hoffmann
Hi, > > > static const TypeInfo cirrus_vga_info = { > > > diff --git a/hw/display/cirrus_vga_isa.c b/hw/display/cirrus_vga_isa.c > > > index 84be51670ed8..3abbf490 100644 > > > --- a/hw/display/cirrus_vga_isa.c > > > +++ b/hw/display/cirrus_vga_isa.c > > > @@ -85,6 +85,7 @@ static void isa_c

[PATCH v2 4/4] vga/cirrus: deprecate, don't build by default

2024-05-30 Thread Gerd Hoffmann
stdvga is the much better option. Signed-off-by: Gerd Hoffmann --- hw/display/cirrus_vga.c | 1 + hw/display/cirrus_vga_isa.c | 1 + hw/display/Kconfig | 1 - 3 files changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/display/cirrus_vga.c b/hw/display/cirrus_vga.c index

[PATCH v2 1/4] qom: allow to mark objects (including devices) as deprecated.

2024-05-30 Thread Gerd Hoffmann
Add deprecation_note field (string) to ObjectClass. Add deprecated bool to ObjectTypeInfo, report in 'qom-list-types'. Print the note when listing devices via '-device help'. Signed-off-by: Gerd Hoffmann --- include/qom/object.h | 1 + qom/qom-qmp-cmds.c| 4 syste

[PATCH v2 3/4] usb/hub: deprecate, don't build by default

2024-05-30 Thread Gerd Hoffmann
The hub supports only USB 1.1. When running out of usb ports it is in almost all cases the much better choice to add another usb host adapter (or increase the number of root ports when using xhci) instead of using the usb hub. Signed-off-by: Gerd Hoffmann --- hw/usb/dev-hub.c | 1 + hw/usb

[PATCH v2 0/4] allow to deprecate objects and devices

2024-05-30 Thread Gerd Hoffmann
Put some infrastructure in place to allow tagging objects (including devices) as deprected. Use it to mark the ohci pci host adapter and the usb hub as deprecated. v2: - pick up reviews. - drop ohci patch. - add cirrus vga patch. Gerd Hoffmann (4): qom: allow to mark objects (including

[PATCH v2 2/4] usb: add config options for the hub and hid devices

2024-05-30 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann Reviewed-by: Thomas Huth --- hw/usb/Kconfig | 10 ++ hw/usb/meson.build | 4 ++-- 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/hw/usb/Kconfig b/hw/usb/Kconfig index f569ed7eeaa1..84bc7fbe36cd 100644 --- a/hw/usb/Kconfig +++ b/hw/usb

[PATCH v2] vnc: increase max display size

2024-05-30 Thread Gerd Hoffmann
It's 2024. 4k display resolutions are a thing these days. Raise width and height limits of the qemu vnc server. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1596 Signed-off-by: Gerd Hoffmann --- ui/vnc.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH] stdvga: fix screen blanking

2024-05-30 Thread Gerd Hoffmann
/qemu-project/qemu/-/issues/2067 Signed-off-by: Gerd Hoffmann --- hw/display/vga.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/hw/display/vga.c b/hw/display/vga.c index 30facc6c8e33..34ab8eb9b745 100644 --- a/hw/display/vga.c +++ b/hw/display/vga.c @@ -1762,6 +1762,12 @@ static void

Re: [PATCH v2 1/4] MAINTAINERS: drop audio maintainership

2024-05-28 Thread Gerd Hoffmann
Hi, > > virtio-snd > > -M: Gerd Hoffmann > > -R: Manos Pitsidianakis > > +M: Manos Pitsidianakis > > +R: Matias Ezequiel Vara Larsen > > S: Supported > > F: hw/audio/virtio-snd.c > > F: hw/audio/virtio-snd-pci.c > > While extra r

[PATCH 4/4] usb/hub: deprecate, don't build by default

2024-05-28 Thread Gerd Hoffmann
The hub supports only USB 1.1. When running out of usb ports it is in almost all cases the much better choice to add another usb host adapter (or increase the number of root ports when using xhci) instead of using the usb hub. Signed-off-by: Gerd Hoffmann --- hw/usb/dev-hub.c | 1 + hw/usb

[PATCH 0/4] allow to deprecate objects and devices

2024-05-28 Thread Gerd Hoffmann
Put some infrastructure in place to allow tagging objects (including devices) as deprected. Use it to mark the ohci pci host adapter and the usb hub as deprecated. Gerd Hoffmann (4): qom: allow to mark objects (including devices) as deprecated. usb: add config options for the hub and hid

[PATCH 1/4] qom: allow to mark objects (including devices) as deprecated.

2024-05-28 Thread Gerd Hoffmann
Add deprecation_note field (string) to ObjectClass. Add deprecated bool to ObjectTypeInfo, report in 'qom-list-types'. Print the note when listing devices via '-device help'. Signed-off-by: Gerd Hoffmann --- include/qom/object.h | 1 + qom/qom-qmp-cmds.c| 4 syste

[PATCH 3/4] usb/ohci-pci: deprecate, don't build by default

2024-05-28 Thread Gerd Hoffmann
The xhci host adapter is the much better choice. Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-ohci-pci.c | 1 + hw/usb/Kconfig| 1 - 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/usb/hcd-ohci-pci.c b/hw/usb/hcd-ohci-pci.c index 33ed9b6f5a52..88de657def71 100644 --- a/hw

[PATCH 2/4] usb: add config options for the hub and hid devices

2024-05-28 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/usb/Kconfig | 10 ++ hw/usb/meson.build | 4 ++-- 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/hw/usb/Kconfig b/hw/usb/Kconfig index f569ed7eeaa1..84bc7fbe36cd 100644 --- a/hw/usb/Kconfig +++ b/hw/usb/Kconfig @@ -65,6 +65,16

[PATCH v2 1/4] MAINTAINERS: drop audio maintainership

2024-05-28 Thread Gerd Hoffmann
Remove myself from audio (both devices and backend) entries. Flip status to "Orphan" for entries which have nobody else listed. Cc: Manos Pitsidianakis Cc: Matias Ezequiel Vara Larsen Cc: Thomas Huth Signed-off-by: Gerd Hoffmann --- MAINTAINERS | 30 ++--

[PATCH v2 2/4] MAINTAINERS: drop usb maintainership

2024-05-28 Thread Gerd Hoffmann
Remove myself from usb entries. Flip status to "Orphan" for entries which have nobody else listed. Signed-off-by: Gerd Hoffmann Reviewed-by: Manos Pitsidianakis --- MAINTAINERS | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 58

[PATCH v2 4/4] MAINTAINERS: drop spice+ui maintainership

2024-05-28 Thread Gerd Hoffmann
Remove myself from spice and ui entries. Flip status to "Orphan" for entries which have nobody else listed. Signed-off-by: Gerd Hoffmann Reviewed-by: Manos Pitsidianakis --- MAINTAINERS | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/MAINTAINERS b/MAINTAI

[PATCH v2 3/4] MAINTAINERS: drop virtio-gpu maintainership

2024-05-28 Thread Gerd Hoffmann
Remove myself from virtio-gpu entries. Flip status to "Orphan" for entries which have nobody else listed. Signed-off-by: Gerd Hoffmann Reviewed-by: Manos Pitsidianakis --- MAINTAINERS | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/MAINTAINERS b/MAINTAI

[PATCH v2 0/4] MAINTAINERS: update kraxel's entries.

2024-05-28 Thread Gerd Hoffmann
don't see much development activity such as stdvga and cirrus for now. I might revisit this later. v2 changes: - flip entries without maintainer to orphan even if there is a reviewer left. - add/upgrade volunteers from replies to audio sections. take care, Gerd Gerd Hoffmann (4): M

[PATCH v5] hw/pflash: fix block write start

2024-05-16 Thread Gerd Hoffmann
: https://gitlab.com/qemu-project/qemu/-/issues/2343 Fixes: 284a7ee2e290 ("hw/pflash: implement update buffer for block writes") Signed-off-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daudé --- hw/block/pflash_cfi01.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff

[PATCH 4/4] MAINTAINERS: drop spice+ui maintainership

2024-05-16 Thread Gerd Hoffmann
Remove myself from spice and ui entries. Flip status to "Orphan" for entries which have nobody else listed. Signed-off-by: Gerd Hoffmann --- MAINTAINERS | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 4d9f4fd09823..d5b6a1c76abb 10

[PATCH 3/4] MAINTAINERS: drop virtio-gpu maintainership

2024-05-16 Thread Gerd Hoffmann
Remove myself from virtio-gpu entries. Flip status to "Orphan" for entries which have nobody else listed. Signed-off-by: Gerd Hoffmann --- MAINTAINERS | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index d81376f84746..4d9f4fd09823 10

[PATCH 2/4] MAINTAINERS: drop usb maintainership

2024-05-16 Thread Gerd Hoffmann
Remove myself from usb entries. Flip status to "Orphan" for entries which have nobody else listed. Signed-off-by: Gerd Hoffmann --- MAINTAINERS | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 7f52e2912fc3..d81376f84746 10

[PATCH 1/4] MAINTAINERS: drop audio maintainership

2024-05-16 Thread Gerd Hoffmann
Remove myself from audio (both devices and backend) entries. Flip status to "Orphan" for entries which have nobody else listed. Signed-off-by: Gerd Hoffmann --- MAINTAINERS | 19 --- 1 file changed, 4 insertions(+), 15 deletions(-) diff --git a/MAINTAINERS b/MAINTAI

[PATCH 0/4] MAINTAINERS: update kraxel's entries.

2024-05-16 Thread Gerd Hoffmann
don't see much development activity such as stdvga and cirrus for now. I might revisit this later. take care, Gerd Gerd Hoffmann (4): MAINTAINERS: drop audio maintainership MAINTAINERS: drop usb maintainership MAINTAINERS: drop virtio-gpu maintainership MAINTAINERS: drop spice+ui main

[PATCH v4] hw/pflash: fix block write start

2024-05-16 Thread Gerd Hoffmann
: https://gitlab.com/qemu-project/qemu/-/issues/2343 Fixes: fcc79f2e0955 ("hw/pflash: implement update buffer for block writes") Signed-off-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daudé --- hw/block/pflash_cfi01.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff

[PATCH v3] hw/pflash: fix block write start

2024-05-15 Thread Gerd Hoffmann
ot;hw/pflash: implement update buffer for block writes") Signed-off-by: Gerd Hoffmann --- hw/block/pflash_cfi01.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/hw/block/pflash_cfi01.c b/hw/block/pflash_cfi01.c index 1bda8424b907..c8f1cf5a8722 100644 ---

Re: [RFC PATCH 0/1] pci: allocate a PCI ID for RISC-V IOMMU

2024-05-07 Thread Gerd Hoffmann
On Tue, May 07, 2024 at 11:37:05PM GMT, Frank Chang wrote: > Hi Daniel, > > Daniel Henrique Barboza 於 2024年5月3日 週五 下午8:43寫道: > > > > Hi, > > > > In this RFC I want to check with Gerd and others if it's ok to add a PCI > > id for the RISC-V IOMMU device. It's currently under review in [1]. The >

Re: Problems (timeouts) when testing usb-ohci with qemu

2024-04-24 Thread Gerd Hoffmann
> qemu hack: > > hw/usb/hcd-ohci.c | 11 +++ > hw/usb/hcd-ohci.h | 1 + > 2 files changed, 12 insertions(+) > > diff --git a/hw/usb/hcd-ohci.c b/hw/usb/hcd-ohci.c > index fc8fc91a1d..99e52ad13a 100644 > --- a/hw/usb/hcd-ohci.c > +++ b/hw/usb/hcd-ohci.c > @@ -267,6 +267,10 @@ static inli

Re: [edk2-devel] [PATCH v3 5/6] target/arm: Do memory type alignment check when translation disabled

2024-04-19 Thread Gerd Hoffmann
Hi, > Gerd, any ideas? Maybe I needs something subtly different in my > edk2 build? I've not looked at this bit of the qemu infrastructure > before - is there a document on how that image is built? There is roms/Makefile for that. make -C roms help make -C roms efi So easiest would be to ju

Re: secure boot & direct kernel load (was: Re: [PATCH] x86/loader: only patch linux kernels)

2024-04-15 Thread Gerd Hoffmann
Hi, > > Options I see: > > > > (a) Stop using direct kernel boot, let virt-install & other tools > > create vfat boot media with shim+kernel+initrd instead. > > > > (b) Enroll the distro signing keys in the efi variable store, so > > booting the kernel without shim.efi works. >

Re: [PATCH 01/12] ui/console-vc: Replace sprintf() by g_strdup_printf()

2024-04-11 Thread Gerd Hoffmann
On Thu, Apr 11, 2024 at 11:36:10AM +0200, Philippe Mathieu-Daudé wrote: > On 11/4/24 09:47, Gerd Hoffmann wrote: > >Hi, > > > > > Due to security concerns inherent in the design of sprintf(3), > > > it is highly recommended that you use snprintf

[PATCH 5/5] x86/loader: add -shim option

2024-04-11 Thread Gerd Hoffmann
Add new -shim command line option, wire up for the x86 loader. When specified load shim into the new "etc/boot/shim" fw_cfg file. Needs OVMF changes too to be actually useful. Signed-off-by: Gerd Hoffmann --- include/hw/boards.h | 1 + hw/core/machine.c | 20 +++

[PATCH 2/5] x86/loader: only patch linux kernels

2024-04-11 Thread Gerd Hoffmann
OVMF happily loads and runs not only linux kernels but any efi binary via direct kernel boot. Note: Breaking the secure boot verification is a problem for linux kernels too, but fixed that is left for another day ... Signed-off-by: Gerd Hoffmann --- hw/i386/x86.c | 2 +- 1 file changed, 1 inse

[PATCH 1/5] vl: fix qemu_validate_options() indention

2024-04-11 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- system/vl.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/system/vl.c b/system/vl.c index c64422298245..0c6201c5bdc5 100644 --- a/system/vl.c +++ b/system/vl.c @@ -2411,15 +2411,15 @@ static void qemu_validate_options(const

[PATCH 4/5] x86/loader: expose unpatched kernel

2024-04-11 Thread Gerd Hoffmann
Add a new "etc/boot/kernel" fw_cfg file, containing the kernel without the setup header patches. Intended use is booting in UEFI with secure boot enabled, where the setup header patching breaks secure boot verification. Needs OVMF changes too to be actually useful. Signed-off-by: Ger

[PATCH 0/5] x86/loader: secure boot support for direct kernel load

2024-04-11 Thread Gerd Hoffmann
cure-boot/ With everything in place it is possible to use direct kernel load with secure boot enabled. take care, Gerd Gerd Hoffmann (5): vl: fix qemu_validate_options() indention x86/loader: only patch linux kernels x86/loader: read complete kernel x86/loader: expose unpatched kernel

[PATCH 3/5] x86/loader: read complete kernel

2024-04-11 Thread Gerd Hoffmann
. Signed-off-by: Gerd Hoffmann --- hw/i386/x86.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/hw/i386/x86.c b/hw/i386/x86.c index 765899eebe43..6f75948b3021 100644 --- a/hw/i386/x86.c +++ b/hw/i386/x86.c @@ -1058,7 +1058,6 @@ void x86_load_linux(X86MachineState

Re: [PATCH 01/12] ui/console-vc: Replace sprintf() by g_strdup_printf()

2024-04-11 Thread Gerd Hoffmann
Hi, > Due to security concerns inherent in the design of sprintf(3), > it is highly recommended that you use snprintf(3) instead. > -char response[40]; > +g_autofree char *response = NULL; > -sprintf(response, "\033[%d;%dR", > +response =

Re: secure boot & direct kernel load (was: Re: [PATCH] x86/loader: only patch linux kernels)

2024-04-10 Thread Gerd Hoffmann
> > > Options I see: > > > > > > (a) Stop using direct kernel boot, let virt-install & other tools > > > create vfat boot media with shim+kernel+initrd instead. > > > > > > (b) Enroll the distro signing keys in the efi variable store, so > > > booting the kernel without shim.efi w

Re: secure boot & direct kernel load (was: Re: [PATCH] x86/loader: only patch linux kernels)

2024-04-10 Thread Gerd Hoffmann
On Wed, Apr 10, 2024 at 07:10:22AM -0400, Michael S. Tsirkin wrote: > On Wed, Apr 10, 2024 at 12:35:13PM +0200, Gerd Hoffmann wrote: > > On Wed, Apr 10, 2024 at 03:26:29AM -0400, Michael S. Tsirkin wrote: > > > On Wed, Apr 10, 2024 at 09:21:26AM +0200, Gerd Hoffmann wrote: >

secure boot & direct kernel load (was: Re: [PATCH] x86/loader: only patch linux kernels)

2024-04-10 Thread Gerd Hoffmann
On Wed, Apr 10, 2024 at 03:26:29AM -0400, Michael S. Tsirkin wrote: > On Wed, Apr 10, 2024 at 09:21:26AM +0200, Gerd Hoffmann wrote: > > If the binary loaded via -kernel is *not* a linux kernel (in which > > case protocol == 0), do not patch the linux kernel header fields. &

[PATCH] x86/loader: only patch linux kernels

2024-04-10 Thread Gerd Hoffmann
OVMF happily loads and runs not only linux kernels but any efi binary via direct kernel boot. Note: Breaking the secure boot verification is a problem for linux kernels too, but fixed that is left for another day ... Signed-off-by: Gerd Hoffmann --- hw/i386/x86.c | 2 +- 1 file changed, 1 inse

Re: [PATCH] edk2: get version + date from git submodule

2024-04-09 Thread Gerd Hoffmann
On Tue, Apr 09, 2024 at 04:13:34PM +0100, Peter Maydell wrote: > On Tue, 9 Apr 2024 at 15:19, Peter Maydell wrote: > > > > On Tue, 9 Apr 2024 at 15:14, Gerd Hoffmann wrote: > > > > > > Hi, > > > > > > > > +

[PULL 1/4] edk2: get version + date from git submodule

2024-04-09 Thread Gerd Hoffmann
ff-by: Gerd Hoffmann Message-ID: <20240327102448.61877-2-kra...@redhat.com> --- roms/Makefile | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/roms/Makefile b/roms/Makefile index edc234a0e886..783a5cab4f4c 100644 --- a/roms/Makefile +++ b/roms/Makefi

[PULL 0/4] Edk2 20240409 patches

2024-04-09 Thread Gerd Hoffmann
. Gerd Hoffmann (4): edk2: get version + date from git submodule edk2: commit version info edk2/seabios: use common extra version edk2: rebuild binaries with correct version information pc-bios/edk2-aarch64-code.fd.bz2 | Bin 1589310 -> 1588976 bytes pc-bios/edk2-arm-code.fd.

[PULL 2/4] edk2: commit version info

2024-04-09 Thread Gerd Hoffmann
Reviewed-by: Peter Maydell Signed-off-by: Gerd Hoffmann Message-ID: <20240327102448.61877-3-kra...@redhat.com> --- roms/edk2-version | 2 ++ 1 file changed, 2 insertions(+) create mode 100644 roms/edk2-version diff --git a/roms/edk2-version b/roms/edk2-version new file mode 100644

[PULL 3/4] edk2/seabios: use common extra version

2024-04-09 Thread Gerd Hoffmann
Bring a bit more consistency into the naming. Reviewed-by: Peter Maydell Signed-off-by: Gerd Hoffmann Message-ID: <20240327102448.61877-4-kra...@redhat.com> --- roms/Makefile | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/roms/Makefile b/roms/Makefile

Re: [PATCH] edk2: get version + date from git submodule

2024-04-09 Thread Gerd Hoffmann
Hi, > > + --version-override "$(EDK2_STABLE)-for-qemu" \ > > + --release-date "$(EDK2_DATE)" \ > > Hi -- I've just noticed that we never made this change to > automate the date/version for EDK2 ROMs, but we also never > updated the version by hand. So at the moment w

Re: [PATCH-for-9.0 0/4] hw/virtio: Protect from more DMA re-entrancy bugs

2024-04-05 Thread Gerd Hoffmann
On Thu, Apr 04, 2024 at 09:13:35PM +0200, Philippe Mathieu-Daudé wrote: > Gerd suggested to use the transport guard to protect the > device from DMA re-entrancy abuses. Thanks for turning that idea into a proper patch series. Series: Reviewed-by: Gerd Hoffmann take care, Gerd

Re: [PATCH for-9.0] docs/about: Mark the iaspc machine type as deprecated

2024-04-02 Thread Gerd Hoffmann
On Fri, Mar 29, 2024 at 10:19:09AM +, Bernhard Beschow wrote: > > In theory you could pass `-M acpi=off` to not instantiate the PIIX4 > ACPI function, essentially turning the Frankenstein-PIIX4 SB into a > PIIX3. However, this also removes SMI registers used by SeaBIOS to > handle SMM setup wh

[PATCH v2 2/3] edk2: commit version info

2024-03-27 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- roms/edk2-version | 2 ++ 1 file changed, 2 insertions(+) create mode 100644 roms/edk2-version diff --git a/roms/edk2-version b/roms/edk2-version new file mode 100644 index ..1594ed8c4de9 --- /dev/null +++ b/roms/edk2-version @@ -0,0 +1,2

[PATCH v2 3/3] edk2/seabios: use common extra version

2024-03-27 Thread Gerd Hoffmann
Bring a bit more consistency into the naming. Signed-off-by: Gerd Hoffmann --- roms/Makefile | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/roms/Makefile b/roms/Makefile index 783a5cab4f4c..dfed2b216a1e 100644 --- a/roms/Makefile +++ b/roms/Makefile @@ -41,8

[PATCH v2 1/3] edk2: get version + date from git submodule

2024-03-27 Thread Gerd Hoffmann
Turned out hard-coding version and date in the Makefile wasn't a bright idea. Updating it on edk2 updates is easily forgotten. Fetch the info from git instead. Store in edk2-version, so this can be committed to the repo and is present in tarballs too. Signed-off-by: Gerd Hoffmann ---

[PATCH v2 0/3] edk2: get version + date from git submodule

2024-03-27 Thread Gerd Hoffmann
v2 changes: - store version information in git Gerd Hoffmann (3): edk2: get version + date from git submodule edk2: commit version info edk2/seabios: use common extra version roms/Makefile | 25 ++--- roms/edk2-version | 2 ++ 2 files changed, 20 insertions(+), 7

Re: [PATCH for-9.0] docs/about: Mark the iaspc machine type as deprecated

2024-03-27 Thread Gerd Hoffmann
On Tue, Mar 26, 2024 at 01:30:48PM +, Mark Cave-Ayland wrote: > Heh I've actually been using isapc over the past couple of weeks to fire up > some old programs in a Windows 3 VM :) I'm wondering why these use cases can't simply use the 'pc' machine type? The early pci chipsets of the 90-ies h

Re: [PATCH] edk2: get version + date from git submodule

2024-03-26 Thread Gerd Hoffmann
On Mon, Mar 25, 2024 at 02:55:11PM +, Peter Maydell wrote: > On Mon, 25 Mar 2024 at 14:45, Gerd Hoffmann wrote: > > > > Turned out hard-coding version and date in the Makefile wasn't a bright > > idea. Updating it on edk2 updates is easily forgotten. Fetch the

  1   2   3   4   5   6   7   8   9   10   >