On Mon, Apr 08, 2024 at 11:33:34PM +0200, Philippe Mathieu-Daudé wrote:
> Mechanical (mostly) conversion inspired by Wolfram [*] to
> use inclusive terminology, similarly to the other renames
> we did 3 years ago, shortly before the I2C spec v7 was
> published.
Sorry, I've been extremely busy on
ing in qemu is pretty esoteric, not many people know anything
about it.
-corey
>
> Thanks again,
> Paz
>
>
>
>
> ____
> From: Corey Minyard on behalf of Corey Minyard
>
> Sent: Monday, February 19, 2024 6:32 PM
> To: Paz Offer
&
On Mon, Feb 19, 2024 at 01:49:44PM +, Paz Offer wrote:
> Hi,
>
> I am new to QEMU development, so please excuse if I my direction here is
> wrong:
>
> I am trying to implement an i2c slave device.
> My device should be able to read/write data from its i2c bus.
>
> I defined my device-state
On Thu, Feb 08, 2024 at 04:39:10PM +, Peter Maydell wrote:
> On Fri, 2 Feb 2024 at 20:48, Joe Komlodi wrote:
> >
> > It's possible for a reset to come in the middle of a transaction, which
> > causes the bus to be in an old state when a new transaction comes in.
> >
> > Signed-off-by: Joe
On Wed, Jan 10, 2024 at 09:26:37PM +, Joe Komlodi wrote:
> Hi all,
>
> This series adds some resets for SMBus and for the I2C core. Along with
> it, we make SMBus slave error printing a little more helpful.
>
> These reset issues were very infrequent, they would maybe occur in 1 out
> of
From: Corey Minyard
Some minor I2C changes. One has been sitting in my queue forgotten for
a while, but still needs to go in. The other is fairly recent. Both
are for BMC related stuff.
These are available at:
https://github.com/cminyard/qemu.git i2c-for-release-2023-12-06
and signed
From: Titus Rwantare
Reviewed-by: Patrick Venture
Reviewed-by: Chris Rauer
Reviewed-by: Hao Wu
Signed-off-by: Titus Rwantare
Message-Id: <20220106173814.3580141-1-vent...@google.com>
Signed-off-by: Corey Minyard
---
hw/sensor/adm1272.c| 27 ++-
tests
From: Potin Lai
Add pca9543 2-channel i2c-mux switch support.
Signed-off-by: Potin Lai
Reviewed-by: Patrick Venture
Message-Id: <20231113063156.2264941-1-potin.lai...@gmail.com>
Signed-off-by: Corey Minyard
---
hw/i2c/i2c_mux_pca954x.c | 12
include/
On Tue, Dec 05, 2023 at 11:05:33AM -0800, Patrick Venture wrote:
> On Tue, Nov 14, 2023 at 3:30 PM Corey Minyard wrote:
>
> > On Mon, Nov 13, 2023 at 02:31:56PM +0800, Potin Lai wrote:
> > > Add pca9543 2-channel i2c-mux switch support.
> > >
> > > Signe
On Mon, Nov 13, 2023 at 02:31:56PM +0800, Potin Lai wrote:
> Add pca9543 2-channel i2c-mux switch support.
>
> Signed-off-by: Potin Lai
Looks good to me.
Acked-by: Corey Minyard
> ---
> hw/i2c/i2c_mux_pca954x.c | 12
> include/hw/i2c/i2c_mux_pca954x.h
w
Looks good to me.
Acked-by: Corey Minyard
> ---
> hw/i2c/pm_smbus.c | 18 --
> hw/i2c/trace-events | 6 ++
> 2 files changed, 10 insertions(+), 14 deletions(-)
>
> diff --git a/hw/i2c/pm_smbus.c b/hw/i2c/pm_smbus.c
> index 4e1b8a5182..78e7c229a8
d.
> >
> > Signed-off-by: Thomas Huth
>
> Reviewed-by: Juan Quintela
>
> It fixes my issues.
>
> Should I take this through the Migration tree?
That's fine with me.
Acked-by: Corey Minyard
>
-chardev socket,id=ipmi0,host=127.0.0.1,port=%d,reconnect=10"
Yeah, this make sense.
Acked-by: Corey Minyard
> " -device ipmi-bmc-extern,chardev=ipmi0,id=bmc0"
> " -device isa-ipmi-bt,bmc=bmc0", emu_port);
> qtest_irq_intercept_in(global_qtest, "ioapic");
> --
> 2.34.1
>
On Mon, Sep 25, 2023 at 04:47:39PM +0200, Paolo Bonzini wrote:
> Signed-off-by: Paolo Bonzini
> ---
> hw/i2c/pm_smbus.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
This looks ok to me.
Acked-by: Corey Minyard
>
> diff --git a/hw/i2c/pm_smbus.c b/hw/i2c/
On Wed, Sep 20, 2023 at 06:31:25AM -0700, Klaus Jensen wrote:
> On Sep 20 07:54, Corey Minyard wrote:
> > On Wed, Sep 20, 2023 at 12:48:03PM +0100, Jonathan Cameron via wrote:
> > > On Thu, 14 Sep 2023 11:53:40 +0200
> > > Klaus Jensen wrote:
> > >
> > &
On Wed, Sep 20, 2023 at 12:48:03PM +0100, Jonathan Cameron via wrote:
> On Thu, 14 Sep 2023 11:53:40 +0200
> Klaus Jensen wrote:
>
> > This adds a generic MCTP endpoint model that other devices may derive
> > from.
> >
> > Also included is a very basic implementation of an NVMe-MI device,
> >
posted code by Padmakar Kalghatgi, Arun
> Kumar Agasar and Saurav Kumar.
This seems fine.
Acked-by: Corey Minyard
One question, though. You don't have any tests. Did you test invalid
packets and such? I think the logic is correct, but those are things
that are good to test. Having tests i
tended to derive from this and implement the class
> methods.
>
> Parts of this implementation is inspired by code[1] previously posted by
> Jonathan Cameron.
I've been kind of watching this, I guess I need to review. I've been
over the logic and it all looks good, I think. So I can do:
On Thu, Sep 14, 2023 at 11:53:41AM +0200, Klaus Jensen wrote:
> From: Klaus Jensen
>
> Add i2c_smbus_pec() to calculate the SMBus Packet Error Code for a
> message.
Seems fine.
Acked-by: Corey Minyard
>
> Reviewed-by: Jonathan Cameron
> Signed-off-by: Klaus Je
On Wed, May 31, 2023 at 01:47:41PM +0200, Klaus Jensen wrote:
> From: Klaus Jensen
>
> This adds a generic MCTP endpoint model that other devices may derive
> from. I'm not 100% happy with the design of the class methods, but it's
> a start.
>
> Also included is a very basic implementation of
On Wed, Apr 26, 2023 at 09:11:16AM +0200, Klaus Jensen wrote:
> On Apr 25 10:19, Corey Minyard wrote:
> > On Tue, Apr 25, 2023 at 08:35:38AM +0200, Klaus Jensen wrote:
> > > From: Klaus Jensen
> > >
> > > Add an abstract MCTP over I2C endpoint model. This i
On Tue, Apr 25, 2023 at 08:35:38AM +0200, Klaus Jensen wrote:
> From: Klaus Jensen
>
> Add an abstract MCTP over I2C endpoint model. This implements MCTP
> control message handling as well as handling the actual I2C transport
> (packetization).
>
> Devices are intended to derive from this and
On Mon, Apr 24, 2023 at 11:02:08AM -0500, Corey Minyard wrote:
> On Mon, Apr 24, 2023 at 02:09:50PM +, Karol Nowak wrote:
> > Hi Corey,
> >
> >
> >
> > Have you got a chance to look at the I2C code?
>
> No, I have not. I've been pretty busy with
.
-corey
>
>
>
> Karol
>
>
> ____
> From: Corey Minyard on behalf of Corey Minyard
>
> Sent: Wednesday, April 19, 2023 4:35 PM
> To: Karol Nowak
> Cc: qemu-devel@nongnu.org ; phi...@linaro.org
> ; c...@kaod.org
> Subject: Re: [RFC PATCH v1] hw/misc: add i2c sla
>
> Best regards,
> Karol
>
>
>
> ____
> From: Corey Minyard on behalf of Corey Minyard
>
> Sent: Monday, April 17, 2023 4:34 PM
> To: Karol Nowak
> Cc: qemu-devel@nongnu.org ; phi...@linaro.org
> ; c...@kaod.org
> Subject:
;
You can look at hw/ipmi/ipmi_bmc_extern.c for an example.
-corey
>
> Karol
>
>
> ____
> From: Corey Minyard on behalf of Corey Minyard
>
> Sent: Thursday, March 23, 2023 5:03 PM
> To: Karol Nowak
> Cc: qemu-devel@nongnu.org ; phi...@li
in the
> CXL code in pci_expander_bridge.c.
>
> Signed-off-by: Peter Maydell
Looks correct ot me.
Reviewed-by: Corey Minyard
> ---
> hw/i2c/allwinner-i2c.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/hw/i2c/allwinner-i2c.c b/hw/i2c/allwinn
But those are really
minor nits, I didn't see anything really wrong with this.
Reviewed-by: Corey Minyard
>
> Testing:
> TPM I2C device module is tested using SWTPM (software based TPM
> package). Qemu uses the rainier machine and is connected to swtpm over
> the socket i
On Fri, Mar 31, 2023 at 12:07:56AM +, Titus Rwantare wrote:
> The ADM1266 can have string fields written by the driver, so
> it's worth specifically testing.
>
> Reviewed-by: Hao Wu
> Signed-off-by: Titus Rwantare
Acked-by: Corey Minyard
> ---
> tests/qtest
dds basic support for its PMBus commands and models
> the identification registers that can be modified in a firmware
> update.
>
> Reviewed-by: Hao Wu
> Signed-off-by: Titus Rwantare
Looks good.
Acked-by: Corey Minyard
> ---
> hw/arm/Kconfig| 1 +
> hw
On Fri, Mar 31, 2023 at 12:07:54AM +, Titus Rwantare wrote:
> VCAP is a register for devices with energy storage capacitors.
>
> Reviewed-by: Benjamin Streb
> Signed-off-by: Titus Rwantare
Acked-by: Corey Minyard
> ---
> hw/i2c/pmbus_device.c | 8
On Fri, Mar 31, 2023 at 12:07:53AM +, Titus Rwantare wrote:
> Devices models calling pmbus_send_string can't be relied upon to
> send a non-zero pointer. This logs an error and doesn't segfault.
>
> Reviewed-by: Patrick Venture
> Signed-off-by: Titus Rwantare
Acked-by
ephen Longfield
> Signed-off-by: Titus Rwantare
Acked-by: Corey Minyard
> ---
> hw/i2c/pmbus_device.c | 176 ++
> include/hw/i2c/pmbus_device.h | 1 +
> 2 files changed, 177 insertions(+)
>
> diff --git a/hw/i2c/pmbus_devi
uint16, uint16,
> VID, and Direct modes. VID and Direct modes use the remaining 5 bits
> to scale the voltage readings.
>
> Reviewed-by: Hao Wu
> Signed-off-by: Titus Rwantare
Ok, I see the new sensor later.
Acked-by: Corey Minyard
> ---
> include/hw/i2c/pmbus_device
gs. Devices can
> respond to a block read with an empty string.
>
> Reviewed-by: Hao Wu
> Signed-off-by: Titus Rwantare
Acked-by: Corey Minyard
> ---
> hw/i2c/pmbus_device.c | 30 +-
> include/hw/i2c/pmbus_device.h | 7 +++
> 2 file
On Thu, Mar 30, 2023 at 11:20:11AM -0500, Corey Minyard wrote:
> I almost never say this, as patches are usually too large :), but it
> would be nice if you combined this with the patch that uses the
> structure so we can see what it's used for. Especially since that patch
> is sev
On Wed, Mar 22, 2023 at 05:55:13PM +, Titus Rwantare wrote:
> VCAP is a register for devices with energy storage capacitors.
Acked-by: Corey MInyard
>
> Reviewed-by: Benjamin Streb
> Signed-off-by: Titus Rwantare
> ---
> hw/i2c/pmbus_device.c | 8
On Wed, Mar 22, 2023 at 05:55:12PM +, Titus Rwantare wrote:
> Devices models calling pmbus_send_string can't be relied upon to
> send a non-zero pointer. This logs an error and doesn't segfault.
Yes, a good idea.
Acked-by: Corey Minyard
>
> Reviewed-by: Patrick Venture
Empty description, but the code itself looks ok.
Acked-by: Corey Minyard
On Wed, Mar 22, 2023 at 05:55:11PM +, Titus Rwantare wrote:
> Reviewed-by: Stephen Longfield
> Signed-off-by: Titus Rwantare
> ---
> hw/i2c/pmbus_device.c | 176 +
I almost never say this, as patches are usually too large :), but it
would be nice if you combined this with the patch that uses the
structure so we can see what it's used for. Especially since that patch
is several patches down the line.
-corey
On Wed, Mar 22, 2023 at 05:55:10PM +, Titus
It's generally frowned upon to have empty descriptions, some rationale
would be helpful. For instance, you remove a length check from the send
string, why did you do that?
Any why is this being added? What's it supporting?
-corey
On Wed, Mar 22, 2023 at 05:55:09PM +, Titus Rwantare wrote:
en't done this before, keeping the old
branch and then using "git diff" against it as you break it up in a new
branch will help make sure you haven't changed anything when you break
it up.
-corey
>
> On Sat, Mar 25, 2023 at 4:51 PM Corey Minyard wrote:
>
> > On Fri, Mar
On Mon, Mar 27, 2023 at 10:11:50AM -0700, Hao Wu wrote:
> Hi, Cedric
>
> The naming scheme is suggested by Corey in a previous review:
>
> https://lists.gnu.org/archive/html/qemu-devel/2021-09/msg02691.html
>
> I originally kept "IpmIBmc" for the host side code talking to BMC but it
> might
On Fri, Mar 24, 2023 at 04:08:59PM -0700, Hao Wu wrote:
> From: Havard Skinnemoen
>
> This document is an attempt to briefly document the existing IPMI
> emulation support on the main processor. It provides the necessary
> background for the BMC-side IPMI emulation proposed by the next patch.
>
On Fri, Mar 24, 2023 at 04:09:01PM -0700, Hao Wu wrote:
> This patch refactors the IPMI interface so that it can be used by both
> the BMC side and core-side simulation.
This patch is hard to review because it does so many different things
and they are all mixed up. It looks ok, but it's hard to
On Thu, Mar 23, 2023 at 10:09:02AM +, Karol Nowak wrote:
> Hi,
>
> There is a feature I prepared which may be practical for some QEMU users.
>
> The feature provides a new I2C slave device
> that prepares a message depending what i2c-slave callback was called
> and sends it outside of QEMU
behind a bus.
>
> Tested: Verified that by default the device was findable with the name
> 'pca954x[77]', for an instance attached at that address.
This looks good to me.
Acked-by: Corey Minyard
if you are taking this in through another tree. Or do you want me to
take this?
-corey
>
On Wed, Mar 22, 2023 at 10:03:27AM -0700, Patrick Venture wrote:
> On Tue, Mar 21, 2023 at 6:41 PM Corey Minyard wrote:
>
> > On Tue, Mar 21, 2023 at 11:27:44AM -0700, Patrick Venture wrote:
> > > This allows the devices to be more readily found and specified.
> > >
On Tue, Mar 21, 2023 at 11:27:44AM -0700, Patrick Venture wrote:
> This allows the devices to be more readily found and specified.
> Without setting the id field, they can only be found by device type
> name, which doesn't let you specify the second of the same device type
> behind a bus.
So
ne. There's no checking of the
reset type, but there's only one reset type right now, so I guess any
changes due to reset type will have to come when new types come.
Acked-by: Corey Minyard
for another tree, or I can take them.
Thanks,
-corey
>
> Thanks!
> Joe
>
> Joe Komlodi (2
On Mon, Feb 27, 2023 at 12:53:23PM +0100, Philippe Mathieu-Daudé wrote:
> On 19/2/23 15:21, Corey Minyard wrote:
> > On Sun, Feb 19, 2023 at 02:45:44PM +0100, Philippe Mathieu-Daudé wrote:
> > > On 18/2/23 21:25, Corey Minyard wrote:
> > > > On Mon, Feb 13, 2023
On Sun, Feb 19, 2023 at 02:45:44PM +0100, Philippe Mathieu-Daudé wrote:
> On 18/2/23 21:25, Corey Minyard wrote:
> > On Mon, Feb 13, 2023 at 06:30:26PM +0100, Bernhard Beschow wrote:
> > > ich9_smb_init() is a legacy init function, so modernize the code.
> > >
>
On Mon, Feb 13, 2023 at 06:30:26PM +0100, Bernhard Beschow wrote:
> ich9_smb_init() is a legacy init function, so modernize the code.
>
> Note that the smb_io_base parameter was unused.
Acked-by: Corey Minyard
>
> Signed-off-by: Bernhard Beschow
> ---
> include/hw/i38
On Mon, Feb 06, 2023 at 07:49:34PM +, Titus Rwantare wrote:
> This is a simple i2c device that allows i2c capable devices to have
> GPIOs.
>
> Reviewed-by: Hao Wu
> Signed-off-by: Titus Rwantare
> ---
> hw/arm/Kconfig | 1 +
> hw/gpio/meson.build | 1 +
>
agree, I was actually wondering about this reviewing earlier
changes. Thanks for fixing this.
Reviewed-by: Corey Minyard
>
> The current implementation of the at24c EEPROM resets its internal memory on
> reset. This matches the specification in docs/devel/reset.rst:
>
> Cold res
init_rom helper to initialize BMC FRUID EEPROM with
> data
> from aspeed_eeprom.c
Reviewed-by: Corey Minyard
>
> wget
> https://github.com/facebook/openbmc/releases/download/openbmc-e2294ff5d31d/fby35.mtd
> qemu-system-aarch64 -machine fby35-bmc -nographic -mtdblock fby35.mtd
&
On Tue, Jan 17, 2023 at 06:42:10PM -0800, Peter Delevoryas wrote:
> This helper is useful in board initialization because lets users initialize
> and
> realize an EEPROM on an I2C bus with a single function call.
This is a good improvement.
Reviewed-by: Corey Minyard
>
> Signe
On Tue, Jan 17, 2023 at 06:42:11PM -0800, Peter Delevoryas wrote:
> aspeed_eeprom_init is an exact copy of at24c_eeprom_init, not needed.
Reviewed-by: Corey Minyard
>
> Signed-off-by: Peter Delevoryas
> Reviewed-by: Cédric Le Goater
> Reviewed-by: Philippe Mathieu-Daudé
>
t;address", address);
Why did you switch from using i2c_slave_new()? Using it is more
documentation and future-proofing than convenience.
Other than that, looks good to me.
Reviewed-by: Corey Minyard
> +qdev_prop_set_uint32(DEVICE(s), "rom-size", rom_size);
>
On Wed, Jan 11, 2023 at 09:50:11AM +0100, Philippe Mathieu-Daudé wrote:
> Series fully reviewed.
These all look good to me
Acked-by: Corey Minyard
You mentioned the ARM tree, is this going in through there?
-corey
>
> Since v2:
> - Use array of const pointers to const (Richard
On Wed, Nov 16, 2022 at 09:43:11AM +0100, Klaus Jensen wrote:
> From: Klaus Jensen
>
> Add an abstract MCTP over I2C endpoint model. This implements MCTP
> control message handling as well as handling the actual I2C transport
> (packetization).
>
> Devices are intended to derive from this and
On Wed, Nov 16, 2022 at 09:43:10AM +0100, Klaus Jensen wrote:
> From: Klaus Jensen
>
> It is not given that the current master will release the bus after a
> transfer ends. Only schedule a pending master if the bus is idle.
>
Yes, I think this is correct.
Acked-by
Not a huge deal, but probably makes mainainers lives a little easier.
Add a change to make Coverity happy.
Corey Minyard (1):
ipmi:smbus: Add a check around a memcpy
hw/ipmi/smbus_ipmi.c | 4 +++-
1 file changed, 3
From: Corey Minyard
In one case:
memcpy(sid->inmsg + sid->inlen, buf, len);
if len == 0 then sid->inmsg + sig->inlen can point to one past the inmsg
array if the array is full. We have to allow len == 0 due to some
vagueness in the spec, but we don't have to call memcpy.
Found
On Tue, Jun 28, 2022 at 05:21:44PM +0100, Peter Maydell wrote:
> On Thu, 19 Sept 2019 at 22:39, wrote:
> >
> > From: Corey Minyard
> >
> > Signed-off-by: Corey Minyard
> > ---
>
Thank you for the ping. Comments inline...
> Very old patch, but Coverit
On Tue, Jul 05, 2022 at 12:13:52PM -0700, Peter Delevoryas wrote:
> I added this helper in the Aspeed machine file a while ago to help
> initialize fuji-bmc i2c devices. This moves it to the official pca954x
> file so that other files can use it.
>
> This does something very similar to
On Wed, Jun 01, 2022 at 11:08:29PM +0200, Klaus Jensen wrote:
> From: Klaus Jensen
>
> Add an asynchronous version of i2c_send() that requires the slave to
> explicitly acknowledge on the bus with i2c_ack().
>
> The current master must use the new i2c_start_send_async() to indicate
> that it
On Wed, Jun 01, 2022 at 11:08:28PM +0200, Klaus Jensen wrote:
> From: Klaus Jensen
>
> Allow slaves to master the bus by registering a bottom halve. If the bus
> is busy, the bottom halve is queued up. When a slave has succesfully
^ half
> mastered the bus, the bottom halve
On Tue, May 24, 2022 at 05:50:43PM +0100, Jonathan Cameron wrote:
> On Tue, 24 May 2022 09:36:44 -0700
> Ben Widawsky wrote:
>
> > On 22-05-20 18:01:28, Jonathan Cameron wrote:
> > > As the only I2C emulation in QEMU that supports being both
> > > a master and a slave, suitable for MCTP over i2c
On Fri, Apr 01, 2022 at 08:29:03AM +0200, Klaus Jensen wrote:
> On Mar 31 15:32, Corey Minyard wrote:
> > On Thu, Mar 31, 2022 at 06:57:33PM +0200, Klaus Jensen wrote:
> > > From: Klaus Jensen
> > >
> > > Hi all,
> > >
> > > This RFC s
On Thu, Mar 31, 2022 at 06:57:33PM +0200, Klaus Jensen wrote:
> From: Klaus Jensen
>
> Hi all,
>
> This RFC series adds I2C "slave mode" support for the Aspeed I2C
> controller as well as the necessary infrastructure in the i2c core to
> support this.
I've been wondering when this would happen
On Mon, Mar 07, 2022 at 01:00:02AM +0100, Philippe Mathieu-Daudé wrote:
> On 5/3/22 00:42, Titus Rwantare wrote:
> > On Fri, 4 Mar 2022 at 13:43, Corey Minyard wrote:
> > >
> > > On Tue, Mar 01, 2022 at 05:50:44PM -0800, Titus Rwantare wrote:
> > > &
gt; - rename rolled into preceding commits
> - update commit description for uint refactoring change
This all looks good to me:
Acked-by: Corey Minyard
Do you have a plan for getting this in to qemu? Like through the ARM
tree? I could take it into an I2C tree, but there's really not much
activit
On Tue, Mar 01, 2022 at 04:23:02PM -0800, Titus Rwantare wrote:
> Signed-off-by: Titus Rwantare
> ---
> MAINTAINERS | 10 ++
> hw/i2c/pmbus_device.c | 18 +-
> 2 files changed, 19 insertions(+), 9 deletions(-)
This makes sense, but can you split it into two
On Tue, Mar 01, 2022 at 04:23:07PM -0800, Titus Rwantare wrote:
> Signed-off-by: Titus Rwantare
Two things:
* Why do you want to rename this?
* This patch doesn't really add anything, it just renames things in a
previous patch. Can it be folded in to the patch that added these
fields?
good idea.
This is obviously trivial here, but:
Acked-by: Corey Minyard
For this and the KCS patch.
-corey
>
> Signed-off-by: Bernhard Beschow
> ---
> hw/ipmi/isa_ipmi_bt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/ipmi/isa_ipmi_bt.c b
On Thu, Feb 24, 2022 at 10:58:52AM -0800, Patrick Venture wrote:
> On Thu, Jan 6, 2022 at 3:09 PM Titus Rwantare wrote:
>
> > This patch series contains updates to PMBus in QEMU along with some PMBus
> > device models for Renesas regulators.
> > I have also added myself to MAINTAINERS as this
On Mon, Feb 21, 2022 at 09:47:27AM -0800, Chris Rauer wrote:
> Hi Phil,
>
> > What about using virtio-gpio & bitbang I2C?
> >
> > - virtio-gpio
> > https://lore.kernel.org/qemu-devel/20201127182917.2387-5-i...@metux.net/
> >
> > - bitbang I2C already in: hw/i2c/bitbang_i2c.c
> Sorry for the
On Thu, Jan 27, 2022 at 03:18:43PM -0800, Patrick Venture wrote:
> On Thu, Jan 27, 2022 at 10:20 AM Hao Wu wrote:
>
> >
> > On Thu, Jan 27, 2022 at 6:55 AM Corey Minyard wrote:
> >
> >> On Wed, Jan 26, 2022 at 04:09:03PM -0800, Hao Wu wrote:
> >> &g
gt;
> >
> > On Mon, Jan 17, 2022 at 6:05 AM Corey Minyard wrote:
> >
> >> On Sun, Jan 09, 2022 at 06:17:34PM -0800, Patrick Venture wrote:
> >> > On Fri, Jan 7, 2022 at 7:04 PM Patrick Venture
> >> wrote:
> >> >
> >> > > From: H
hw/display/virtio-vga.c| 2 +-
> hw/dma/bcm2835_dma.c | 2 +-
> hw/i386/pc_piix.c | 2 +-
> hw/i386/sgx-epc.c | 2 +-
> hw/intc/bcm2835_ic.c | 2 +-
> hw/intc/bcm2836_control.c | 2 +-
> hw/ipmi/ipmi.c | 4 ++--
For IPMI portions:
Acked-by:
On Sun, Jan 09, 2022 at 06:17:34PM -0800, Patrick Venture wrote:
> On Fri, Jan 7, 2022 at 7:04 PM Patrick Venture wrote:
>
> > From: Hao Wu
> >
> > SB Temperature Sensor Interface (SB-TSI) is an SMBus compatible
> > interface that reports AMD SoC's Ttcl (normalized temperature),
> > and
read changed. This patch fixes this issue.
>
> Signed-off-by: Hao Wu
> Reviewed-by: Titus Rwantare
This looks ok. I assume you can take this in with the rest of the
patches.
Acked-by: Corey Minyard
> ---
> hw/i2c/npcm7xx_smbus.c | 6 +++---
> 1 file changed, 3 insertions(+),
On Mon, Sep 27, 2021 at 12:15:18AM +0200, Philippe Mathieu-Daudé wrote:
> Sensors models are listed in the 'Misc devices' category.
> Move them to their own category.
>
> For the devices in the hw/sensor/ directory, the category
> is obvious.
>
> hw/arm/z2.c models the AER915 model which is
On Thu, Sep 23, 2021 at 01:11:52PM +0100, Peter Maydell wrote:
> Rename the "allocate and return" qbus creation function to
> qbus_new(), to bring it into line with our _init vs _new convention.
This looks like a good idea to me.
Reviewed-by: Corey Minyard
>
> Signed
On Thu, Sep 09, 2021 at 04:06:19PM -0700, Hao Wu wrote:
> The IPMI external host device works for Baseband Management Controller
> (BMC) emulations. It works as a representation of a host class that
> connects to a given BMC. It can connect to a real host hardware or a
> emulated or simulated
teDescription vmstate_ipmi_bmc_extern
> = {
> .post_load = ipmi_bmc_extern_post_migrate,
> .fields = (VMStateField[]) {
> VMSTATE_BOOL(send_reset, IPMIBmcExtern),
> -VMSTATE_BOOL(waiting_rsp, IPMIBmcExtern),
> +VMSTATE_BOOL(conn.waitin
On Thu, Sep 09, 2021 at 04:06:16PM -0700, Hao Wu wrote:
> This patch refactors the IPMI interface so that it can be used by both
> the BMC side and core-side simulation.
>
> Detail changes:
> (1) rename handle_rsp -> handle_msg so the name fits both BMC side and
> Core side.
> (2) Add a new
On Thu, Sep 09, 2021 at 04:06:14PM -0700, Hao Wu wrote:
> From: Havard Skinnemoen
>
> This document is an attempt to briefly document the existing IPMI
> emulation support on the main processor. It provides the necessary
> background for the BMC-side IPMI emulation proposed by the next patch.
On Thu, Sep 09, 2021 at 04:06:13PM -0700, Hao Wu wrote:
> From: Havard Skinnemoen
>
Can you add some reason for this? I also can't approve this, you'll
need permission from whoever is responsible for this file.
-corey
> Signed-off-by: Havard Skinnemoen
> Signed-off-by: Hao Wu
> ---
>
Maydell
Looks good to me. Thanks, Peter. I looked through all the other
patches, too, and reviewed those.
Reviewed-by: Corey Minyard
> ---
> tests/qtest/ipmi-bt-test.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/qtest/ipmi-bt-test.c b/test
extensible.
>
> I am leaving google, so I will be passing this project to my team. Thank
> you again for your feedback.
Well, bummer. This is a good idea hopefully we can see it through.
Thanks,
-corey
>
> best,
> Shengtan
>
> On Fri, Aug 6, 2021 at 9:55 PM Corey
On Mon, Aug 09, 2021 at 03:15:55PM +0200, Cédric Le Goater wrote:
> From: Joel Stanley
>
> This contains some hardcoded register values that were obtained from the
> hardware after reading the temperature.
>
> It does enough to test the Linux kernel driver. The FIFO mode, IRQs and
> operation
On Fri, Aug 06, 2021 at 11:49:16PM +, Shengtan Mao wrote:
> This patch implements the remote I2C device. The remote I2C device allows an
> external I2C device to communicate with the I2C controller in QEMU through the
> remote I2C protocol. Users no longer have to directly modify QEMU to add
On Mon, Aug 02, 2021 at 11:03:22PM +, Shengtan Mao wrote:
> This patch implements the remote I2C device.
> The remote I2C device allows an external I2C device to communicate with the
> I2C controller in QEMU through the remote I2C protocol.
> Users no longer have to directly modify QEMU to
On Tue, Jul 27, 2021 at 10:23:26AM +0100, Peter Maydell wrote:
> On Wed, 21 Jul 2021 at 22:06, Shengtan Mao wrote:
> >
> > Hi everyone,
> > we are hoping to upstream a MAX I2C device to QEMU. The device's datasheet
> > is not public, and we are contacting the Maxim company to get their
> >
cessary. Feature freeze is in two days, so probably not for
6.1, though it could be pushed into there if its needed in 6.1.
Or:
Acked-by: Corey Minyard
if someone else wants to take it. This particular code really doesn't
belong in eeprom.c, I don't think, but I'm not sure where else to
On Wed, Jul 14, 2021 at 10:36:24AM +0100, Alex Bennée wrote:
> Signed-off-by: Alex Bennée
> Cc: Corey Minyard
Acked-by: Corey Minyard
You even got the (mis)spelling right! Thanks.
-corey
> ---
> contrib/gitdm/domain-map | 1 +
> 1 file changed, 1 insertion(+)
>
>
):
hw/i2c: Make i2c_start_transfer() direction argument a boolean
Corey Minyard (3):
adc: Move the zynq-xadc file to the adc directories
adc: Move the max111x driver to the adc directory
sensor: Move hardware sensors from misc to a sensor directory
Jinhua Cao (1):
ipmi/sim
Hmm, it compiled for me, I wonder if there are some compiler
differences, but I don't see how.
Anyway, copying the original patch source so they know.
Thanks for checking.
-corey
On Tue, Jul 06, 2021 at 10:16:36PM +0100, Peter Maydell wrote:
> On Tue, 6 Jul 2021 at 21:06, Corey Minyard wr
1 - 100 of 1030 matches
Mail list logo
