Re: [Qemu-devel] [PATCH] bios-tables-test: delete a assert about block name

2017-08-14 Thread wyang
On 2017年08月15日 10:49, Michael S. Tsirkin wrote: BTW sizeof(BLOCK_NAME_END) is actually 2. I think it works because there's a space after ,. It is better to replace it with strlen so it will work without a space too. MST, I double check the failure of assert, it has already been fixed by the

Re: [Qemu-devel] [PATCH] bios-tables-test: delete a assert about block name

2017-08-14 Thread wyang
On 2017年08月14日 23:58, Michael S. Tsirkin wrote: On Mon, Aug 14, 2017 at 04:48:38PM +0800, wei.y...@ucloud.cn wrote: From: Wei Yang The assert would be touched when the version of acpica is greater than or equal to 20160318. its reason is that "Disasembler: Update a couple

Re: [Qemu-devel] [PATCH] bios-tables-test: delete a assert about block name

2017-08-14 Thread wyang
On 2017年08月15日 10:39, Michael S. Tsirkin wrote: On Tue, Aug 15, 2017 at 10:21:08AM +0800, wyang wrote: On 2017年08月14日 23:58, Michael S. Tsirkin wrote: On Mon, Aug 14, 2017 at 04:48:38PM +0800, wei.y...@ucloud.cn wrote: From: Wei Yang <wei.y...@ucloud.cn> The assert would be touche

Re: [Qemu-devel] [PATCH] block/mirror: enable detect zeroes when driving mirror

2016-11-22 Thread wyang
On 2016年11月22日 21:44, Eric Blake wrote: On 11/21/2016 08:31 PM, wyang wrote: On 2016年11月21日 14:51, Vasiliy Tolstov wrote: 21 Ноя 2016 г. 4:27 пользователь "Yang Wei" <w90p...@gmail.com <mailto:w90p...@gmail.com>> написал: In order to preserve sparse disk image, det

Re: [Qemu-devel] [Qemu-block] [PATCH] block/mirror: enable detect zeroes when driving mirror

2016-11-22 Thread wyang
On 2016年11月22日 18:09, Kevin Wolf wrote: Am 22.11.2016 um 04:45 hat wyang geschrieben: On 2016年11月21日 19:34, Kevin Wolf wrote: Am 21.11.2016 um 02:24 hat Yang Wei geschrieben: In order to preserve sparse disk image, detect_zeroes should also be enabled when bdrv_get_block_status_above

Re: [Qemu-devel] [Qemu-block] [PATCH] block/mirror: enable detect zeroes when driving mirror

2016-11-21 Thread wyang
On 2016年11月21日 19:34, Kevin Wolf wrote: Am 21.11.2016 um 02:24 hat Yang Wei geschrieben: In order to preserve sparse disk image, detect_zeroes should also be enabled when bdrv_get_block_status_above() returns BDRV_BLOCK_DATA Signed-off-by: Yang Wei Just preserving

Re: [Qemu-devel] [PATCH] block/mirror: enable detect zeroes when driving mirror

2016-11-21 Thread wyang
On 2016年11月21日 14:51, Vasiliy Tolstov wrote: 21 Ноя 2016 г. 4:27 пользователь "Yang Wei" > написал: > > In order to preserve sparse disk image, detect_zeroes > should also be enabled when bdrv_get_block_status_above() > returns BDRV_BLOCK_DATA > >