Re: [GEDI] [PATCH 07/17] gluster: Drop useless has_zero_init callback

2020-02-17 Thread Niels de Vos
On Mon, Feb 17, 2020 at 06:03:40AM -0600, Eric Blake wrote: > On 2/17/20 2:06 AM, Niels de Vos wrote: > > On Fri, Jan 31, 2020 at 11:44:26AM -0600, Eric Blake wrote: > > > block.c already defaults to 0 if we don't provide a callback; there's > > > no need to write a callback that always fails. > >

Re: [GEDI] [PATCH 07/17] gluster: Drop useless has_zero_init callback

2020-02-17 Thread Eric Blake
On 2/17/20 6:03 AM, Eric Blake wrote: > > Creation or truncation should behave just as on a file on a local > filesystem. So maybe qemu_gluster_known_zeroes is not needed at all? Which version of gluster first required a regular filesystem backing for all gluster files?  Does qemu support o

Re: [GEDI] [PATCH 07/17] gluster: Drop useless has_zero_init callback

2020-02-17 Thread Eric Blake
On 2/17/20 2:06 AM, Niels de Vos wrote: On Fri, Jan 31, 2020 at 11:44:26AM -0600, Eric Blake wrote: block.c already defaults to 0 if we don't provide a callback; there's no need to write a callback that always fails. Signed-off-by: Eric Blake Reviewed-by: Niels de Vos Per your other mess

Re: [GEDI] [PATCH 07/17] gluster: Drop useless has_zero_init callback

2020-02-17 Thread Niels de Vos
On Fri, Jan 31, 2020 at 11:44:26AM -0600, Eric Blake wrote: > block.c already defaults to 0 if we don't provide a callback; there's > no need to write a callback that always fails. > > Signed-off-by: Eric Blake Reviewed-by: Niels de Vos > --- > block/gluster.c | 14 -- > 1 file ch