Hey Philippe,
Thanks for the detailed comments! I have a couple of questions.
1. I'll modify the patch to just include a fallthrough comment instead
of an attribute. How do I include the v4 version number in the patch? Do I
erase the last commit on my branch or fork from the master and
Patchew URL:
https://patchew.org/QEMU/20200815151245.10640-1-rohit.shinde12...@gmail.com/
Hi,
This series failed the docker-quick@centos7 build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT
Patchew URL:
https://patchew.org/QEMU/20200815151148.10571-1-rohit.shinde12...@gmail.com/
Hi,
This series failed the docker-quick@centos7 build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT
This is v3 with no change w.r.t. v1/v2 (except this time you correctly
Cc'ed the maintainers). Maybe something is wrong in your setup?
On 8/15/20 5:12 PM, Rohit Shinde wrote:
> Added the fallthrough comment so that the compiler doesn't emit an error on
> compiling with the -Wimplicit-fallthrough
When you repost a patch, please add a version. This is patch v2.
Next (once you read my v1 comments) should be v3.
Watch out, v1 correctly Cc'ed the maintainers, this v2 doesn't.
On 8/15/20 5:11 PM, Rohit Shinde wrote:
> Added the fallthrough comment so that the compiler doesn't emit an error on
Hi Rohit,
Congratulation for your first patch! It is in very
good shape already :)
It is easier for the reviewers if you start the patch subject with
the name of the subsystem concerned, or the file modified:
"qapi/opts-visitor: Add missing fallthrough annotations"
On 8/15/20 3:00 PM, Rohit
Added the fallthrough comment so that the compiler doesn't emit an error on
compiling with the -Wimplicit-fallthrough flag.
Signed-off-by: Rohit Shinde
---
qapi/opts-visitor.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/qapi/opts-visitor.c b/qapi/opts-visitor.c
index
Patchew URL:
https://patchew.org/QEMU/20200815130046.5344-1-rohit.shinde12...@gmail.com/
Hi,
This series failed the docker-quick@centos7 build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT
Added the fallthrough comment so that the compiler doesn't emit an error on
compiling with the -Wimplicit-fallthrough flag.
Signed-off-by: Rohit Shinde
---
qapi/opts-visitor.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/qapi/opts-visitor.c b/qapi/opts-visitor.c
index
: Fallthrough warning on line 270 of
qemu/qapi/opts-visitor.c
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback b
Added the fallthrough comment so that the compiler doesn't emit an error on
compiling with the -Wimplicit-fallthrough flag.
Signed off by: Rohit Shinde
---
qapi/opts-visitor.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/qapi/opts-visitor.c b/qapi/opts-visitor.c
index
11 matches
Mail list logo
