Re: [PATCH] Hexagon: add PC alignment check and exception

2024-04-29 Thread Richard Henderson
On 4/27/24 07:56, Richard Henderson wrote: On 4/26/24 11:15, Matheus Tavares Bernardino wrote: The Hexagon Programmer's Reference Manual says that the exception 0x1e should be raised upon an unaligned program counter. Let's implement that and also add tests for both the most common case as well

RE: [PATCH] Hexagon: add PC alignment check and exception

2024-04-29 Thread Matheus Tavares Bernardino
Hi, Taylor On Mon, 29 Apr 2024 09:51:16 -0500 wrote: > > PS You should also update the pkt_raises_exception function in translate.c > to return true for packets that contain these instructions. This will > ensure that none of the machine state is changed before the check is > complete. Will

RE: [PATCH] Hexagon: add PC alignment check and exception

2024-04-29 Thread ltaylorsimpson
il.com > Sent: Monday, April 29, 2024 9:41 AM > To: 'Matheus Tavares Bernardino' ; qemu- > de...@nongnu.org > Cc: bc...@quicinc.com; sidn...@quicinc.com; a...@rev.ng; a...@rev.ng > Subject: RE: [PATCH] Hexagon: add PC alignment check and exception > > > > > -Ori

RE: [PATCH] Hexagon: add PC alignment check and exception

2024-04-29 Thread ltaylorsimpson
> -Original Message- > From: Matheus Tavares Bernardino > Sent: Friday, April 26, 2024 1:16 PM > To: qemu-devel@nongnu.org > Cc: bc...@quicinc.com; sidn...@quicinc.com; a...@rev.ng; a...@rev.ng; > ltaylorsimp...@gmail.com > Subject: [PATCH] Hexagon: add PC alignmen

Re: [PATCH] Hexagon: add PC alignment check and exception

2024-04-27 Thread Richard Henderson
On 4/26/24 11:15, Matheus Tavares Bernardino wrote: The Hexagon Programmer's Reference Manual says that the exception 0x1e should be raised upon an unaligned program counter. Let's implement that and also add tests for both the most common case as well as packets with multiple change-of-flow

RE: [PATCH] Hexagon: add PC alignment check and exception

2024-04-26 Thread Brian Cain
> -Original Message- > From: Matheus Bernardino (QUIC) > Sent: Friday, April 26, 2024 1:16 PM > To: qemu-devel@nongnu.org > Cc: Brian Cain ; Sid Manning ; > a...@rev.ng; a...@rev.ng; ltaylorsimp...@gmail.com > Subject: [PATCH] Hexagon: add PC alignmen

[PATCH] Hexagon: add PC alignment check and exception

2024-04-26 Thread Matheus Tavares Bernardino
The Hexagon Programmer's Reference Manual says that the exception 0x1e should be raised upon an unaligned program counter. Let's implement that and also add tests for both the most common case as well as packets with multiple change-of-flow instructions. Signed-off-by: Matheus Tavares Bernardino