Re: [PATCH] MIPS - fix cycle counter timing calculations

2021-12-13 Thread Daniel P . Berrangé
On Tue, Dec 14, 2021 at 12:54:05AM +1100, Simon Burge wrote: > Hi Phil, > > =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= wrote: > > > Oops, missing your Signed-off-by tag, see: > > https://www.qemu.org/docs/master/devel/submitting-a-patch.html#patch-emails-must-includ > e-a-signed-off-by-line > > > >

Re: [PATCH] MIPS - fix cycle counter timing calculations

2021-12-13 Thread Simon Burge
Hi Phil, =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= wrote: > Oops, missing your Signed-off-by tag, see: > https://www.qemu.org/docs/master/devel/submitting-a-patch.html#patch-emails-must-includ e-a-signed-off-by-line > > Do you mind re-sending with your S-o-b? Meanwhile, patch dropped. Hopefully

Re: [PATCH] MIPS - fix cycle counter timing calculations

2021-12-13 Thread Philippe Mathieu-Daudé
On 12/13/21 11:10, Philippe Mathieu-Daudé wrote: > On 11/16/21 08:26, Simon Burge wrote: >> The cp0_count_ns value is calculated from the CP0_COUNT_RATE_DEFAULT >> constant in target/mips/cpu.c. The cycle counter resolution is defined >> per-CPU in target/mips/cpu-defs.c.inc; use this value for

Re: [PATCH] MIPS - fix cycle counter timing calculations

2021-12-13 Thread Philippe Mathieu-Daudé
On 11/16/21 08:26, Simon Burge wrote: > The cp0_count_ns value is calculated from the CP0_COUNT_RATE_DEFAULT > constant in target/mips/cpu.c. The cycle counter resolution is defined > per-CPU in target/mips/cpu-defs.c.inc; use this value for calculating > cp0_count_ns. Fixings timing problems on

[PATCH] MIPS - fix cycle counter timing calculations

2021-11-16 Thread Simon Burge
The cp0_count_ns value is calculated from the CP0_COUNT_RATE_DEFAULT constant in target/mips/cpu.c. The cycle counter resolution is defined per-CPU in target/mips/cpu-defs.c.inc; use this value for calculating cp0_count_ns. Fixings timing problems on guest OSs for the 20Kc CPU which has a CCRes