Re: [PATCH] accel/tcg: Complete cpu initialization before registration

2023-02-03 Thread Peter Maydell
On Fri, 3 Feb 2023 at 10:29, Eric Auger wrote: > > Hi Peter, > On 2/2/23 11:53, Peter Maydell wrote: > > On Wed, 1 Feb 2023 at 20:37, Richard Henderson > > wrote: > >> > >> On 2/1/23 04:20, Eric Auger wrote: > >>> What I fail to understand is why this code is called with a kvm > >>> accelerated

Re: [PATCH] accel/tcg: Complete cpu initialization before registration

2023-02-03 Thread Eric Auger
Hi Peter, On 2/2/23 11:53, Peter Maydell wrote: > On Wed, 1 Feb 2023 at 20:37, Richard Henderson > wrote: >> >> On 2/1/23 04:20, Eric Auger wrote: >>> What I fail to understand is why this code is called with a kvm >>> accelerated qemu (the test runs by default with kvm). >> ... >>> #2

Re: [PATCH] accel/tcg: Complete cpu initialization before registration

2023-02-02 Thread Peter Maydell
On Wed, 1 Feb 2023 at 20:37, Richard Henderson wrote: > > On 2/1/23 04:20, Eric Auger wrote: > > What I fail to understand is why this code is called with a kvm > > accelerated qemu (the test runs by default with kvm). > ... > > #2 0x02aaab1500f0 in vmsa_ttbr_write > > (env=0x2aaac393850,

Re: [PATCH] accel/tcg: Complete cpu initialization before registration

2023-02-01 Thread Richard Henderson
On 2/1/23 04:20, Eric Auger wrote: What I fail to understand is why this code is called with a kvm accelerated qemu (the test runs by default with kvm). ... #2 0x02aaab1500f0 in vmsa_ttbr_write (env=0x2aaac393850, ri=0x2aaac3c90e0, value=2154950976315703518) at ../target/arm/helper.c:3784

Re: [PATCH] accel/tcg: Complete cpu initialization before registration

2023-02-01 Thread Eric Auger
Hi Richard, Commit 4e4fa6c12d ("accel/tcg: Complete cpu initialization before registration") seems to cause a regression on one kvm unit test: FAIL debug-wp-migration (terminated on SIGSEGV) This can be reproduced with upstream kernel, qemu and kvm unit test. Seems the change in

Re: [PATCH] accel/tcg: Complete cpu initialization before registration

2022-10-31 Thread Richard Henderson
On 10/31/22 22:07, Ilya Leoshkevich wrote: @@ -1580,15 +1580,13 @@ void tcg_flush_jmp_cache(CPUState *cpu) { CPUJumpCache *jc = cpu->tb_jmp_cache; -if (likely(jc)) { -for (int i = 0; i < TB_JMP_CACHE_SIZE; i++) { -qatomic_set(>array[i].tb, NULL); -} -

Re: [PATCH] accel/tcg: Complete cpu initialization before registration

2022-10-31 Thread Ilya Leoshkevich
On Mon, Oct 31, 2022 at 04:41:05PM +1100, Richard Henderson wrote: > Delay cpu_list_add until realize is complete, so that cross-cpu > interaction does not happen with incomplete cpu state. For this, > we must delay plugin initialization out of tcg_exec_realizefn, > because no cpu_index has been

[PATCH] accel/tcg: Complete cpu initialization before registration

2022-10-30 Thread Richard Henderson
Delay cpu_list_add until realize is complete, so that cross-cpu interaction does not happen with incomplete cpu state. For this, we must delay plugin initialization out of tcg_exec_realizefn, because no cpu_index has been assigned. Fixes a problem with cross-cpu jump cache flushing, when the