Re: [PATCH] acpi: Fix access to PM1 control and status registers

2020-07-23 Thread Anthony PERARD
On Thu, Jul 23, 2020 at 03:54:18PM +0300, Michael Tokarev wrote: > 01.07.2020 15:48, Anthony PERARD wrote: > > > I actually tried, but when reading `addr` or `addr+1` I had the same > > value. So I guess `addr` wasn't taken into account. > > AFAICS, these registers aren't actually supposed to be

Re: [PATCH] acpi: Fix access to PM1 control and status registers

2020-07-23 Thread Anthony PERARD
On Thu, Jul 23, 2020 at 08:44:27AM -0400, Michael S. Tsirkin wrote: > On Fri, Jul 10, 2020 at 10:42:58AM +0100, Anthony PERARD wrote: > > On Thu, Jul 02, 2020 at 07:12:08AM -0400, Michael S. Tsirkin wrote: > > > memory: align to min access size > > > > > > If impl.min_access_size >

Re: [PATCH] acpi: Fix access to PM1 control and status registers

2020-07-23 Thread Michael Tokarev
01.07.2020 15:48, Anthony PERARD wrote: > I actually tried, but when reading `addr` or `addr+1` I had the same > value. So I guess `addr` wasn't taken into account. AFAICS, these registers aren't actually supposed to be accessed like this as addr+1. ACPI and ISA spec states multiple times that

Re: [PATCH] acpi: Fix access to PM1 control and status registers

2020-07-23 Thread Michael S. Tsirkin
On Thu, Jul 16, 2020 at 11:05:06AM +0200, Cédric Le Goater wrote: > On 7/2/20 1:12 PM, Michael S. Tsirkin wrote: > > On Wed, Jul 01, 2020 at 01:48:36PM +0100, Anthony PERARD wrote: > >> On Wed, Jul 01, 2020 at 08:01:55AM -0400, Michael S. Tsirkin wrote: > >>> On Wed, Jul 01, 2020 at 12:05:49PM

Re: [PATCH] acpi: Fix access to PM1 control and status registers

2020-07-23 Thread Michael S. Tsirkin
On Fri, Jul 10, 2020 at 10:42:58AM +0100, Anthony PERARD wrote: > On Thu, Jul 02, 2020 at 07:12:08AM -0400, Michael S. Tsirkin wrote: > > memory: align to min access size > > > > If impl.min_access_size > valid.min_access_size access callbacks > > can get a misaligned access as size is increased.

Re: [PATCH] acpi: Fix access to PM1 control and status registers

2020-07-16 Thread Cédric Le Goater
On 7/2/20 1:12 PM, Michael S. Tsirkin wrote: > On Wed, Jul 01, 2020 at 01:48:36PM +0100, Anthony PERARD wrote: >> On Wed, Jul 01, 2020 at 08:01:55AM -0400, Michael S. Tsirkin wrote: >>> On Wed, Jul 01, 2020 at 12:05:49PM +0100, Anthony PERARD wrote: The ACPI spec state that "Accesses to PM1

Re: [PATCH] acpi: Fix access to PM1 control and status registers

2020-07-10 Thread Anthony PERARD
On Thu, Jul 02, 2020 at 07:12:08AM -0400, Michael S. Tsirkin wrote: > memory: align to min access size > > If impl.min_access_size > valid.min_access_size access callbacks > can get a misaligned access as size is increased. > They don't expect that, let's fix it in the memory core. > >

Re: [PATCH] acpi: Fix access to PM1 control and status registers

2020-07-02 Thread Michael S. Tsirkin
On Wed, Jul 01, 2020 at 01:48:36PM +0100, Anthony PERARD wrote: > On Wed, Jul 01, 2020 at 08:01:55AM -0400, Michael S. Tsirkin wrote: > > On Wed, Jul 01, 2020 at 12:05:49PM +0100, Anthony PERARD wrote: > > > The ACPI spec state that "Accesses to PM1 control registers are > > > accessed through

Re: [PATCH] acpi: Fix access to PM1 control and status registers

2020-07-01 Thread Anthony PERARD
On Wed, Jul 01, 2020 at 08:01:55AM -0400, Michael S. Tsirkin wrote: > On Wed, Jul 01, 2020 at 12:05:49PM +0100, Anthony PERARD wrote: > > The ACPI spec state that "Accesses to PM1 control registers are > > accessed through byte and word accesses." (In section 4.7.3.2.1 PM1 > > Control Registers of

Re: [PATCH] acpi: Fix access to PM1 control and status registers

2020-07-01 Thread Michael S. Tsirkin
On Wed, Jul 01, 2020 at 12:05:49PM +0100, Anthony PERARD wrote: > The ACPI spec state that "Accesses to PM1 control registers are > accessed through byte and word accesses." (In section 4.7.3.2.1 PM1 > Control Registers of my old spec copy rev 4.0a). > > With commit 5d971f9e6725 ("memory: Revert

[PATCH] acpi: Fix access to PM1 control and status registers

2020-07-01 Thread Anthony PERARD
The ACPI spec state that "Accesses to PM1 control registers are accessed through byte and word accesses." (In section 4.7.3.2.1 PM1 Control Registers of my old spec copy rev 4.0a). With commit 5d971f9e6725 ("memory: Revert "memory: accept mismatching sizes in memory_region_access_valid""), it