Re: [PATCH] audio/ossaudio: Fix compiler warning with -Wshadow

2023-10-04 Thread Markus Armbruster
Thomas Huth writes: > The "err" variable is only used twice in this code, in a very > local fashion of first assigning it and then checking it in the > next line. So there is no need to declare this variable a second > time in the innermost block, we can re-use the variable that is > declared at

Re: [PATCH] audio/ossaudio: Fix compiler warning with -Wshadow

2023-10-04 Thread Philippe Mathieu-Daudé
On 4/10/23 10:39, Thomas Huth wrote: The "err" variable is only used twice in this code, in a very local fashion of first assigning it and then checking it in the next line. So there is no need to declare this variable a second time in the innermost block, we can re-use the variable that is

[PATCH] audio/ossaudio: Fix compiler warning with -Wshadow

2023-10-04 Thread Thomas Huth
The "err" variable is only used twice in this code, in a very local fashion of first assigning it and then checking it in the next line. So there is no need to declare this variable a second time in the innermost block, we can re-use the variable that is declared at the beginning of the function.