Re: [PATCH] block/rbd: Add support for ceph namespaces

2019-12-20 Thread Eric Blake
On 12/20/19 11:17 AM, Florian Florensa wrote: The patch LGTM, but I'd like to use 'namespace' instead of cryptic 'nspace'. (as BlockdevOptionsNVMe did) What do you think? Yes no worries, I can rename it to 'rbd_namespace' to avoid any possible confusion, is this Ok for you ? We use

Re: [PATCH] block/rbd: Add support for ceph namespaces

2019-12-20 Thread Eric Blake
On 12/19/19 7:34 AM, Florian Florensa wrote: Starting from ceph Nautilus, RBD has support for namespaces, allowing for finer grain ACLs on images inside a pool, and tenant isolation. In the rbd cli tool documentation, the new image-spec and snap-spec are : -

Re: [PATCH] block/rbd: Add support for ceph namespaces

2019-12-20 Thread Florian Florensa
On Fri, Dec 20, 2019 at 09:56:51AM -0500, Jason Dillaman wrote: > On Fri, Dec 20, 2019 at 9:11 AM Florian Florensa wrote: > > > > Hello Stefano and Jason, > > > > First of all thanks for the quick reply, > > Response inline belowe > > > Hi Florian, > > > > > > I think we need to add (Since: 5.0).

Re: [PATCH] block/rbd: Add support for ceph namespaces

2019-12-20 Thread Stefano Garzarella
On Fri, Dec 20, 2019 at 09:56:51AM -0500, Jason Dillaman wrote: > On Fri, Dec 20, 2019 at 9:11 AM Florian Florensa wrote: > > > > Hello Stefano and Jason, > > > > First of all thanks for the quick reply, > > Response inline belowe > > > Hi Florian, > > > > > > I think we need to add (Since: 5.0).

Re: [PATCH] block/rbd: Add support for ceph namespaces

2019-12-20 Thread Jason Dillaman
On Fri, Dec 20, 2019 at 9:11 AM Florian Florensa wrote: > > Hello Stefano and Jason, > > First of all thanks for the quick reply, > Response inline belowe > > Hi Florian, > > > > I think we need to add (Since: 5.0). > > Are you implying by that (Since: 5.0) that we need to specify its >

Re: [PATCH] block/rbd: Add support for ceph namespaces

2019-12-20 Thread Florian Florensa
Hello Stefano and Jason, First of all thanks for the quick reply, Response inline belowe > Hi Florian, > > I think we need to add (Since: 5.0). Are you implying by that (Since: 5.0) that we need to specify its availability target is qemu 5.0 ? I guess that maybe a version check would be better

Re: [PATCH] block/rbd: Add support for ceph namespaces

2019-12-19 Thread Stefano Garzarella
Hi Florian, On Thu, Dec 19, 2019 at 02:34:16PM +0100, Florian Florensa wrote: > Starting from ceph Nautilus, RBD has support for namespaces, allowing > for finer grain ACLs on images inside a pool, and tenant isolation. > > In the rbd cli tool documentation, the new image-spec and snap-spec are

Re: [PATCH] block/rbd: Add support for ceph namespaces

2019-12-19 Thread Jason Dillaman
On Thu, Dec 19, 2019 at 8:44 AM Florian Florensa wrote: > > Starting from ceph Nautilus, RBD has support for namespaces, allowing > for finer grain ACLs on images inside a pool, and tenant isolation. > > In the rbd cli tool documentation, the new image-spec and snap-spec are : > -

[PATCH] block/rbd: Add support for ceph namespaces

2019-12-19 Thread Florian Florensa
Starting from ceph Nautilus, RBD has support for namespaces, allowing for finer grain ACLs on images inside a pool, and tenant isolation. In the rbd cli tool documentation, the new image-spec and snap-spec are : - [pool-name/[namespace-name/]]image-name -