Re: [PATCH] configure: actually disable 'git_update' mode with --disable-git-update

2020-10-16 Thread Dan Streetman
On Fri, Oct 2, 2020 at 9:11 AM Daniel P. Berrangé wrote: > > On Wed, Sep 30, 2020 at 09:28:54PM -0400, Dan Streetman wrote: > > On Tue, Sep 22, 2020 at 12:34 PM Daniel P. Berrangé > > wrote: > > > > > > On Wed, Jul 29, 2020 at 03:58:29PM -0400, Dan Streetman wrote: > > > > The

Re: [PATCH] configure: actually disable 'git_update' mode with --disable-git-update

2020-10-02 Thread Rafael David Tinoco
Assuming you're just using git for conveniently applying local downstream patches, you don't need the git repo to exist once getting to the build stage. IOW just delete the .git dir after applying patches before running a build. ...then what do you do if the build fails and you want to

Re: [PATCH] configure: actually disable 'git_update' mode with --disable-git-update

2020-10-02 Thread Peter Maydell
On Fri, 2 Oct 2020 at 14:13, Daniel P. Berrangé wrote: > Assuming you're just using git for conveniently applying local > downstream patches, you don't need the git repo to exist once > getting to the build stage. IOW just delete the .git dir after > applying patches before running a build.

Re: [PATCH] configure: actually disable 'git_update' mode with --disable-git-update

2020-10-02 Thread Daniel P . Berrangé
On Wed, Sep 30, 2020 at 09:28:54PM -0400, Dan Streetman wrote: > On Tue, Sep 22, 2020 at 12:34 PM Daniel P. Berrangé > wrote: > > > > On Wed, Jul 29, 2020 at 03:58:29PM -0400, Dan Streetman wrote: > > > The --disable-git-update configure param sets git_update=no, but > > > some later checks only

Re: [PATCH] configure: actually disable 'git_update' mode with --disable-git-update

2020-09-30 Thread Dan Streetman
On Tue, Sep 22, 2020 at 12:34 PM Daniel P. Berrangé wrote: > > On Wed, Jul 29, 2020 at 03:58:29PM -0400, Dan Streetman wrote: > > The --disable-git-update configure param sets git_update=no, but > > some later checks only look for the .git dir. This changes the > > --enable-git-update to set

Re: [PATCH] configure: actually disable 'git_update' mode with --disable-git-update

2020-09-22 Thread Daniel P . Berrangé
On Wed, Jul 29, 2020 at 03:58:29PM -0400, Dan Streetman wrote: > The --disable-git-update configure param sets git_update=no, but > some later checks only look for the .git dir. This changes the > --enable-git-update to set git_update=yes but also fail if it > does not find a .git dir. Then all

[PATCH] configure: actually disable 'git_update' mode with --disable-git-update

2020-07-29 Thread Dan Streetman
The --disable-git-update configure param sets git_update=no, but some later checks only look for the .git dir. This changes the --enable-git-update to set git_update=yes but also fail if it does not find a .git dir. Then all the later checks for the .git dir can just be changed to a check for