Re: [PATCH] console: make QMP screendump use coroutine

2020-03-11 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > On Fri, Mar 6, 2020 at 9:44 AM Markus Armbruster wrote: >> >> Marc-André Lureau writes: >> >> > Hi >> > >> > On Tue, Mar 3, 2020 at 8:41 AM Markus Armbruster wrote: >> [...] >> >> >> Let's take a step back. >> >> >> >> >> >> The actual problem is to find the

Re: [PATCH] console: make QMP screendump use coroutine

2020-03-06 Thread Marc-André Lureau
Hi On Fri, Mar 6, 2020 at 9:44 AM Markus Armbruster wrote: > > Marc-André Lureau writes: > > > Hi > > > > On Tue, Mar 3, 2020 at 8:41 AM Markus Armbruster wrote: > [...] > >> >> Let's take a step back. > >> >> > >> >> The actual problem is to find the coroutine in graphic_hw_update_done(), > >>

Re: [PATCH] console: make QMP screendump use coroutine

2020-03-06 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > On Tue, Mar 3, 2020 at 8:41 AM Markus Armbruster wrote: [...] >> >> Let's take a step back. >> >> >> >> The actual problem is to find the coroutine in graphic_hw_update_done(), >> >> so you can wake it. >> >> >> >> Your solution stores the coroutine in the Qemu

Re: [PATCH] console: make QMP screendump use coroutine

2020-03-05 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > On Thu, Mar 5, 2020 at 3:46 PM Markus Armbruster wrote: >> >> I tried to observe the main loop keeps running while the screendump does >> its work. >> >> The main loop appears to lack trace points. Alright, if there's no >> hammer handy, I'll use a rock: >> >>

Re: [PATCH] console: make QMP screendump use coroutine

2020-03-05 Thread Marc-André Lureau
Hi On Thu, Mar 5, 2020 at 3:46 PM Markus Armbruster wrote: > > I tried to observe the main loop keeps running while the screendump does > its work. > > The main loop appears to lack trace points. Alright, if there's no > hammer handy, I'll use a rock: > > diff --git a/softmmu/vl.c b/softmmu/vl.c

Re: [PATCH] console: make QMP screendump use coroutine

2020-03-05 Thread Markus Armbruster
I tried to observe the main loop keeps running while the screendump does its work. The main loop appears to lack trace points. Alright, if there's no hammer handy, I'll use a rock: diff --git a/softmmu/vl.c b/softmmu/vl.c index 5549f4b619..b6561a65d7 100644 --- a/softmmu/vl.c +++ b/softmmu/vl.c

Re: [PATCH] console: make QMP screendump use coroutine

2020-03-03 Thread Marc-André Lureau
Hi On Tue, Mar 3, 2020 at 8:41 AM Markus Armbruster wrote: > > Kevin Wolf writes: > > > Am 02.03.2020 um 15:22 hat Markus Armbruster geschrieben: > >> Marc-André Lureau writes: > >> > >> > Hi > >> > > >> > On Fri, Feb 21, 2020 at 5:50 PM Markus Armbruster > >> > wrote: > >> >> > >> >> Kevin W

Re: [PATCH] console: make QMP screendump use coroutine

2020-03-03 Thread Markus Armbruster
Marc-André Lureau writes: [...] >> To apply the QMP coroutine infrastructure for 5.0, I need a user. We >> have two: block_resize from Kevin, and screendump from Marc-André. >> Neither is quite ready, yet. I'll wait for a respin of either one. >> > > Kevin series has conflicts, I will wait for

Re: [PATCH] console: make QMP screendump use coroutine

2020-03-03 Thread Marc-André Lureau
Hi On Tue, Mar 3, 2020 at 8:41 AM Markus Armbruster wrote: > > Kevin Wolf writes: > > > Am 02.03.2020 um 15:22 hat Markus Armbruster geschrieben: > >> Marc-André Lureau writes: > >> > >> > Hi > >> > > >> > On Fri, Feb 21, 2020 at 5:50 PM Markus Armbruster > >> > wrote: > >> >> > >> >> Kevin W

Re: [PATCH] console: make QMP screendump use coroutine

2020-03-02 Thread Markus Armbruster
Kevin Wolf writes: > Am 02.03.2020 um 15:22 hat Markus Armbruster geschrieben: >> Marc-André Lureau writes: >> >> > Hi >> > >> > On Fri, Feb 21, 2020 at 5:50 PM Markus Armbruster >> > wrote: >> >> >> >> Kevin Wolf writes: >> >> >> >> > Am 20.02.2020 um 17:01 hat Markus Armbruster geschrieben

Re: [PATCH] console: make QMP screendump use coroutine

2020-03-02 Thread Kevin Wolf
Am 02.03.2020 um 15:22 hat Markus Armbruster geschrieben: > Marc-André Lureau writes: > > > Hi > > > > On Fri, Feb 21, 2020 at 5:50 PM Markus Armbruster wrote: > >> > >> Kevin Wolf writes: > >> > >> > Am 20.02.2020 um 17:01 hat Markus Armbruster geschrieben: > >> >> >> > void qmp_screendump(co

Re: [PATCH] console: make QMP screendump use coroutine

2020-03-02 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > On Fri, Feb 21, 2020 at 5:50 PM Markus Armbruster wrote: >> >> Kevin Wolf writes: >> >> > Am 20.02.2020 um 17:01 hat Markus Armbruster geschrieben: >> >> >> > void qmp_screendump(const char *filename, bool has_device, const >> >> >> > char *device, >> >> >>

Re: [PATCH] console: make QMP screendump use coroutine

2020-02-24 Thread Marc-André Lureau
Hi On Fri, Feb 21, 2020 at 5:50 PM Markus Armbruster wrote: > > Kevin Wolf writes: > > > Am 20.02.2020 um 17:01 hat Markus Armbruster geschrieben: > >> >> > void qmp_screendump(const char *filename, bool has_device, const > >> >> > char *device, > >> >> > bool has_head, in

Re: [PATCH] console: make QMP screendump use coroutine

2020-02-21 Thread Markus Armbruster
Kevin Wolf writes: > Am 20.02.2020 um 17:01 hat Markus Armbruster geschrieben: >> >> > void qmp_screendump(const char *filename, bool has_device, const char >> >> > *device, >> >> > bool has_head, int64_t head, Error **errp) >> >> > { >> >> > QemuConsole *con; >> >> >

Re: [PATCH] console: make QMP screendump use coroutine

2020-02-21 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > "Dr. David Alan Gilbert" writes: > > > * Markus Armbruster (arm...@redhat.com) wrote: > [...] > >> Collecting several users before building infrastructure makes sense when > >> the design of the infrastructure isn't obvious, or when the need for it

Re: [PATCH] console: make QMP screendump use coroutine

2020-02-21 Thread Kevin Wolf
Am 20.02.2020 um 17:01 hat Markus Armbruster geschrieben: > >> > void qmp_screendump(const char *filename, bool has_device, const char > >> > *device, > >> > bool has_head, int64_t head, Error **errp) > >> > { > >> > QemuConsole *con; > >> > DisplaySurface *surface

Re: [PATCH] console: make QMP screendump use coroutine

2020-02-20 Thread Markus Armbruster
"Dr. David Alan Gilbert" writes: > * Markus Armbruster (arm...@redhat.com) wrote: [...] >> Collecting several users before building infrastructure makes sense when >> the design of the infrastructure isn't obvious, or when the need for it >> is in doubt. >> >> Neither is the case for running QMP

Re: [PATCH] console: make QMP screendump use coroutine

2020-02-20 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > Cc: David for questions regarding the HMP core. David, please look for > "Is HMP blocking the main loop a problem?" > > Marc-André Lureau writes: > > > Hi > > > > On Thu, Feb 20, 2020 at 8:49 AM Markus Armbruster wrote: > >> > >> Marc-André Lure

Re: [PATCH] console: make QMP screendump use coroutine

2020-02-20 Thread Markus Armbruster
Cc: David for questions regarding the HMP core. David, please look for "Is HMP blocking the main loop a problem?" Marc-André Lureau writes: > Hi > > On Thu, Feb 20, 2020 at 8:49 AM Markus Armbruster wrote: >> >> Marc-André Lureau writes: >> >> > Thanks to the QMP coroutine support, the screen

Re: [PATCH] console: make QMP screendump use coroutine

2020-02-20 Thread Marc-André Lureau
Hi On Thu, Feb 20, 2020 at 8:49 AM Markus Armbruster wrote: > > Marc-André Lureau writes: > > > Thanks to the QMP coroutine support, the screendump handler can > > trigger a graphic_hw_update(), yield and let the main loop run until > > update is done. Then the handler is resumed, and the ppm_sa

Re: [PATCH] console: make QMP screendump use coroutine

2020-02-19 Thread Markus Armbruster
Marc-André Lureau writes: > Thanks to the QMP coroutine support, the screendump handler can > trigger a graphic_hw_update(), yield and let the main loop run until > update is done. Then the handler is resumed, and the ppm_save() will > write the screen image to disk in the coroutine context (thus

Re: [PATCH] console: make QMP screendump use coroutine

2020-02-13 Thread Markus Armbruster
Gerd Hoffmann writes: > Hi, > >> Thanks to the QMP coroutine support, the screendump handler can >> trigger a graphic_hw_update(), yield and let the main loop run until >> update is done. Then the handler is resumed, and the ppm_save() will >> write the screen image to disk in the coroutine con

Re: [PATCH] console: make QMP screendump use coroutine

2020-02-12 Thread Gerd Hoffmann
Hi, > Thanks to the QMP coroutine support, the screendump handler can > trigger a graphic_hw_update(), yield and let the main loop run until > update is done. Then the handler is resumed, and the ppm_save() will > write the screen image to disk in the coroutine context (thus > non-blocking). >

Re: [PATCH] console: make QMP screendump use coroutine

2020-01-13 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200113144848.2168018-1-marcandre.lur...@redhat.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT

Re: [PATCH] console: make QMP screendump use coroutine

2020-01-13 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200113144848.2168018-1-marcandre.lur...@redhat.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIP

[PATCH] console: make QMP screendump use coroutine

2020-01-13 Thread Marc-André Lureau
Thanks to the QMP coroutine support, the screendump handler can trigger a graphic_hw_update(), yield and let the main loop run until update is done. Then the handler is resumed, and the ppm_save() will write the screen image to disk in the coroutine context (thus non-blocking). For now, HMP doesn'