On Wednesday, 2021-09-08 at 08:06:27 +02, Paolo Bonzini wrote:
> On 07/09/21 13:08, Alexander Bulekov wrote:
>>
>> -if [ "$GITLAB_CI" != "true" ]; then
>> +if [ -z ${GITLAB_CI+x} ]; then
>
> I would slightly prefer to have "${GITLAB_CI+x}", since "test" in
> general doesn't like parameters
On 07/09/21 13:08, Alexander Bulekov wrote:
-if [ "$GITLAB_CI" != "true" ]; then
+if [ -z ${GITLAB_CI+x} ]; then
I would slightly prefer to have "${GITLAB_CI+x}", since "test" in
general doesn't like parameters that go away:
$ [ = abc ]
bash: [: =: unary operator expected
What you wrote
On 07/09/2021 14.51, Alexander Bulekov wrote:
On 210907 1432, Thomas Huth wrote:
On 07/09/2021 13.08, Alexander Bulekov wrote:
/src/build.sh: line 76: GITLAB_CI: unbound variable
Fix that.
Signed-off-by: Alexander Bulekov
---
This change is in preparation to revert:
7602748c ("qemu:
On 210907 1432, Thomas Huth wrote:
> On 07/09/2021 13.08, Alexander Bulekov wrote:
> > /src/build.sh: line 76: GITLAB_CI: unbound variable
> > Fix that.
> >
> > Signed-off-by: Alexander Bulekov
> > ---
> >
> > This change is in preparation to revert:
> > 7602748c ("qemu: manually build glib
On 07/09/2021 13.08, Alexander Bulekov wrote:
/src/build.sh: line 76: GITLAB_CI: unbound variable
Fix that.
Signed-off-by: Alexander Bulekov
---
This change is in preparation to revert:
7602748c ("qemu: manually build glib (#5919)") on OSS-Fuzz.
Reverting as-is produces an unbound variable
On Tuesday, 2021-09-07 at 07:08:41 -04, Alexander Bulekov wrote:
> /src/build.sh: line 76: GITLAB_CI: unbound variable
> Fix that.
>
> Signed-off-by: Alexander Bulekov
Reviewed-by: Darren Kenny
> ---
>
> This change is in preparation to revert:
> 7602748c ("qemu: manually build glib (#5919)")
/src/build.sh: line 76: GITLAB_CI: unbound variable
Fix that.
Signed-off-by: Alexander Bulekov
---
This change is in preparation to revert:
7602748c ("qemu: manually build glib (#5919)") on OSS-Fuzz.
Reverting as-is produces an unbound variable complaint when we try to
build the fuzzers in the
