Re: [PATCH] guest agent: Fixes for windows guest agent building on msys2/mingw

2020-09-15 Thread Thomas Huth
On 15/09/2020 21.17, 罗勇刚(Yonggang Luo) wrote: > I agree with that, seems QEMU currently are calling ANSI api all the > time, better not change that, >  so globally define -DUNICODE -D_UNICODE is not a option I agree, -DUNICODE is currently not an option. I'll go with my patch ("qga/commands-win32

Re: [PATCH] guest agent: Fixes for windows guest agent building on msys2/mingw

2020-09-15 Thread Yonggang Luo
On Wed, Sep 16, 2020 at 1:55 AM Philippe Mathieu-Daudé wrote: > > On 9/15/20 7:41 PM, 罗勇刚(Yonggang Luo) wrote: > > On Wed, Sep 16, 2020 at 12:41 AM Philippe Mathieu-Daudé > > mailto:phi...@redhat.com>> wrote: > >> > >> On 9/15/20 6:33 PM, Yonggang Luo wrote: > >> > error message: > >> > "cc" "-Iqg

Re: [PATCH] guest agent: Fixes for windows guest agent building on msys2/mingw

2020-09-15 Thread Philippe Mathieu-Daudé
On 9/15/20 7:41 PM, 罗勇刚(Yonggang Luo) wrote: > On Wed, Sep 16, 2020 at 12:41 AM Philippe Mathieu-Daudé > mailto:phi...@redhat.com>> wrote: >> >> On 9/15/20 6:33 PM, Yonggang Luo wrote: >> > error message: >> > "cc" "-Iqga/qemu-ga.exe.p" "-Iqga" "-I../qga" "-I." "-Iqapi" > "-Itrace" "-Iui" "-Iui/sha

Re: [PATCH] guest agent: Fixes for windows guest agent building on msys2/mingw

2020-09-15 Thread Philippe Mathieu-Daudé
On 9/15/20 6:33 PM, Yonggang Luo wrote: > error message: > "cc" "-Iqga/qemu-ga.exe.p" "-Iqga" "-I../qga" "-I." "-Iqapi" "-Itrace" "-Iui" > "-Iui/shader" "-IC:/CI-Tools/msys64/mingw64/include" > "-IC:/CI-Tools/msys64/mingw64/include/glib-2.0" > "-IC:/CI-Tools/msys64/mingw64/lib/glib-2.0/include"

[PATCH] guest agent: Fixes for windows guest agent building on msys2/mingw

2020-09-15 Thread Yonggang Luo
error message: "cc" "-Iqga/qemu-ga.exe.p" "-Iqga" "-I../qga" "-I." "-Iqapi" "-Itrace" "-Iui" "-Iui/shader" "-IC:/CI-Tools/msys64/mingw64/include" "-IC:/CI-Tools/msys64/mingw64/include/glib-2.0" "-IC:/CI-Tools/msys64/mingw64/lib/glib-2.0/include" "-fdiagnostics-color=auto" "-pipe" "-Wall" "-Winv