Re: [PATCH] hw/char/pl011: Fix clock migration failure

2021-03-17 Thread Gavin Shan
Hi Drew, On 3/17/21 11:54 PM, Andrew Jones wrote: On Wed, Mar 17, 2021 at 11:14:56AM +, Peter Maydell wrote: On Wed, 17 Mar 2021 at 10:59, Gavin Shan wrote: On 3/17/21 9:40 PM, Peter Maydell wrote: On Wed, 17 Mar 2021 at 10:37, Gavin Shan wrote: On 3/17/21 8:09 PM, Peter Maydell

Re: [PATCH] hw/char/pl011: Fix clock migration failure

2021-03-17 Thread Peter Maydell
On Wed, 17 Mar 2021 at 12:55, Andrew Jones wrote: > I'm also curious what the state of mach-virt's machine types are for > migration. Probably not great -- I don't think anybody is really testing cross-version migration, and I don't think there's a great deal of in-practice use of it for Arm

Re: [PATCH] hw/char/pl011: Fix clock migration failure

2021-03-17 Thread Philippe Mathieu-Daudé
+Beraldo On 3/17/21 1:54 PM, Andrew Jones wrote: > On Wed, Mar 17, 2021 at 11:14:56AM +, Peter Maydell wrote: >> On Wed, 17 Mar 2021 at 10:59, Gavin Shan wrote: >>> >>> Hi Peter, >>> >>> On 3/17/21 9:40 PM, Peter Maydell wrote: On Wed, 17 Mar 2021 at 10:37, Gavin Shan wrote: > On

Re: [PATCH] hw/char/pl011: Fix clock migration failure

2021-03-17 Thread Andrew Jones
On Wed, Mar 17, 2021 at 11:14:56AM +, Peter Maydell wrote: > On Wed, 17 Mar 2021 at 10:59, Gavin Shan wrote: > > > > Hi Peter, > > > > On 3/17/21 9:40 PM, Peter Maydell wrote: > > > On Wed, 17 Mar 2021 at 10:37, Gavin Shan wrote: > > >> On 3/17/21 8:09 PM, Peter Maydell wrote: > > >>> On

Re: [PATCH] hw/char/pl011: Fix clock migration failure

2021-03-17 Thread Peter Maydell
On Wed, 17 Mar 2021 at 10:59, Gavin Shan wrote: > > Hi Peter, > > On 3/17/21 9:40 PM, Peter Maydell wrote: > > On Wed, 17 Mar 2021 at 10:37, Gavin Shan wrote: > >> On 3/17/21 8:09 PM, Peter Maydell wrote: > >>> On Wed, 17 Mar 2021 at 04:44, Gavin Shan wrote: > > static const

Re: [PATCH] hw/char/pl011: Fix clock migration failure

2021-03-17 Thread Gavin Shan
Hi Peter, On 3/17/21 9:40 PM, Peter Maydell wrote: On Wed, 17 Mar 2021 at 10:37, Gavin Shan wrote: On 3/17/21 8:09 PM, Peter Maydell wrote: On Wed, 17 Mar 2021 at 04:44, Gavin Shan wrote: static const VMStateDescription vmstate_pl011 = { .name = "pl011", .version_id = 2,

Re: [PATCH] hw/char/pl011: Fix clock migration failure

2021-03-17 Thread Peter Maydell
On Wed, 17 Mar 2021 at 10:37, Gavin Shan wrote: > > Hi Peter, > > On 3/17/21 8:09 PM, Peter Maydell wrote: > > On Wed, 17 Mar 2021 at 04:44, Gavin Shan wrote: > >> > >> static const VMStateDescription vmstate_pl011 = { > >> .name = "pl011", > >> .version_id = 2, > >>

Re: [PATCH] hw/char/pl011: Fix clock migration failure

2021-03-17 Thread Gavin Shan
Hi Peter, On 3/17/21 8:09 PM, Peter Maydell wrote: On Wed, 17 Mar 2021 at 04:44, Gavin Shan wrote: There is a added clock to trace buad rate change since v5.2.0 by commit aac63e0e6ea3 ("hw/char/pl011: add a clock input"). The added clock causes migration failure. For example, migration from

Re: [PATCH] hw/char/pl011: Fix clock migration failure

2021-03-17 Thread Peter Maydell
On Wed, 17 Mar 2021 at 04:44, Gavin Shan wrote: > > There is a added clock to trace buad rate change since v5.2.0 by > commit aac63e0e6ea3 ("hw/char/pl011: add a clock input"). The added > clock causes migration failure. For example, migration from v5.2.0 > to v5.1.0 can fail with the following

[PATCH] hw/char/pl011: Fix clock migration failure

2021-03-16 Thread Gavin Shan
There is a added clock to trace buad rate change since v5.2.0 by commit aac63e0e6ea3 ("hw/char/pl011: add a clock input"). The added clock causes migration failure. For example, migration from v5.2.0 to v5.1.0 can fail with the following error messages: qemu-system-aarch64: error while loading