Re: [PATCH] hw/display/qxl: Set pci rom address aligned with page size

2021-05-18 Thread maobibo
在 2021年05月18日 15:37, Gerd Hoffmann 写道: > Hi, > >>> Is the host page size fixed on mips? >> >> No, it is not fixed on mips, and it can be selected by linux kernel config. > > Hmm. So the rom size can differ depending on host kernel config. > Which is bad. It'll break live migration between

Re: [PATCH] hw/display/qxl: Set pci rom address aligned with page size

2021-05-18 Thread Gerd Hoffmann
Hi, > > Is the host page size fixed on mips? > > No, it is not fixed on mips, and it can be selected by linux kernel config. Hmm. So the rom size can differ depending on host kernel config. Which is bad. It'll break live migration between hosts with different page sizes (or wouldn't that wor

Re: [PATCH] hw/display/qxl: Set pci rom address aligned with page size

2021-05-18 Thread maobibo
在 2021年05月18日 15:03, Gerd Hoffmann 写道: > On Tue, May 18, 2021 at 09:06:31AM +0800, maobibo wrote: >> Sorry I do not state the background clearly. >> >> Page size is 16K on my MIPS machine, and it supports running >> guest OS in kvm mode and qxl vga card can used for VM. > > Ok. Please add that

Re: [PATCH] hw/display/qxl: Set pci rom address aligned with page size

2021-05-18 Thread Gerd Hoffmann
On Tue, May 18, 2021 at 09:06:31AM +0800, maobibo wrote: > Sorry I do not state the background clearly. > > Page size is 16K on my MIPS machine, and it supports running > guest OS in kvm mode and qxl vga card can used for VM. Ok. Please add that to the commit message. Also there is no need to r

Re: [PATCH] hw/display/qxl: Set pci rom address aligned with page size

2021-05-17 Thread maobibo
Sorry I do not state the background clearly. Page size is 16K on my MIPS machine, and it supports running guest OS in kvm mode and qxl vga card can used for VM. Qxl pci rom size is 8K, smaller than 16K page size on host system, it fails to be added into memslot in kvm mode since size of the pci m

Re: [PATCH] hw/display/qxl: Set pci rom address aligned with page size

2021-05-17 Thread Gerd Hoffmann
On Sat, May 15, 2021 at 04:06:23PM +0800, Bibo Mao wrote: > From: maobibo > > pci memory bar size should be aligned with page size, else it will > not be effective memslot when running in kvm mode. > > This patch set qxl pci rom size aligned with page size of host > machine. What is the exact p

[PATCH] hw/display/qxl: Set pci rom address aligned with page size

2021-05-15 Thread Bibo Mao
From: maobibo pci memory bar size should be aligned with page size, else it will not be effective memslot when running in kvm mode. This patch set qxl pci rom size aligned with page size of host machine. Signed-off-by: Bibo Mao --- hw/display/qxl.c | 8 1 file changed, 4 insertions(+