Re: [PATCH] hw/i386/pc: when adding reserved E820 entries do not allocate dynamic entries

2022-02-28 Thread Ani Sinha
On Thu, Feb 24, 2022 at 6:51 PM Igor Mammedov wrote: > > On Thu, 24 Feb 2022 18:14:35 +0530 > Ani Sinha wrote: > > > On Thu, Feb 24, 2022 at 2:33 PM Igor Mammedov wrote: > > > > > > On Wed, 23 Feb 2022 17:30:34 +0530 > > > Ani Sinha wrote: > > > > > > > On Wed, Feb 23, 2022 at 2:34 PM Igor

Re: [PATCH] hw/i386/pc: when adding reserved E820 entries do not allocate dynamic entries

2022-02-24 Thread Igor Mammedov
On Thu, 24 Feb 2022 18:14:35 +0530 Ani Sinha wrote: > On Thu, Feb 24, 2022 at 2:33 PM Igor Mammedov wrote: > > > > On Wed, 23 Feb 2022 17:30:34 +0530 > > Ani Sinha wrote: > > > > > On Wed, Feb 23, 2022 at 2:34 PM Igor Mammedov > > > wrote: > > > > > > > > On Thu, 10 Feb 2022 18:58:21

Re: [PATCH] hw/i386/pc: when adding reserved E820 entries do not allocate dynamic entries

2022-02-24 Thread Ani Sinha
On Thu, Feb 24, 2022 at 2:33 PM Igor Mammedov wrote: > > On Wed, 23 Feb 2022 17:30:34 +0530 > Ani Sinha wrote: > > > On Wed, Feb 23, 2022 at 2:34 PM Igor Mammedov wrote: > > > > > > On Thu, 10 Feb 2022 18:58:21 +0530 > > > Ani Sinha wrote: > > > > > > > When adding E820_RESERVED entries we

Re: [PATCH] hw/i386/pc: when adding reserved E820 entries do not allocate dynamic entries

2022-02-24 Thread Igor Mammedov
On Wed, 23 Feb 2022 17:30:34 +0530 Ani Sinha wrote: > On Wed, Feb 23, 2022 at 2:34 PM Igor Mammedov wrote: > > > > On Thu, 10 Feb 2022 18:58:21 +0530 > > Ani Sinha wrote: > > > > > When adding E820_RESERVED entries we also accidentally allocate dynamic > > > entries. This is incorrect. We

Re: [PATCH] hw/i386/pc: when adding reserved E820 entries do not allocate dynamic entries

2022-02-23 Thread Ani Sinha
On Wed, Feb 23, 2022 at 2:34 PM Igor Mammedov wrote: > > On Thu, 10 Feb 2022 18:58:21 +0530 > Ani Sinha wrote: > > > When adding E820_RESERVED entries we also accidentally allocate dynamic > > entries. This is incorrect. We should simply return early with the count of > > the number of reserved

Re: [PATCH] hw/i386/pc: when adding reserved E820 entries do not allocate dynamic entries

2022-02-23 Thread Igor Mammedov
On Thu, 10 Feb 2022 18:58:21 +0530 Ani Sinha wrote: > When adding E820_RESERVED entries we also accidentally allocate dynamic > entries. This is incorrect. We should simply return early with the count of > the number of reserved entries added. can you expand commit message to explain what's

Re: [PATCH] hw/i386/pc: when adding reserved E820 entries do not allocate dynamic entries

2022-02-11 Thread Ani Sinha
On Thu, 10 Feb 2022, Philippe Mathieu-Daudé wrote: > On 10/2/22 14:28, Ani Sinha wrote: > > When adding E820_RESERVED entries we also accidentally allocate dynamic > > entries. This is incorrect. We should simply return early with the count of > > the number of reserved entries added. > > > >

Re: [PATCH] hw/i386/pc: when adding reserved E820 entries do not allocate dynamic entries

2022-02-10 Thread Philippe Mathieu-Daudé via
On 10/2/22 14:28, Ani Sinha wrote: When adding E820_RESERVED entries we also accidentally allocate dynamic entries. This is incorrect. We should simply return early with the count of the number of reserved entries added. fixes: 7d67110f2d9a6("pc: add etc/e820 fw_cfg file") 8 years old, so

[PATCH] hw/i386/pc: when adding reserved E820 entries do not allocate dynamic entries

2022-02-10 Thread Ani Sinha
When adding E820_RESERVED entries we also accidentally allocate dynamic entries. This is incorrect. We should simply return early with the count of the number of reserved entries added. fixes: 7d67110f2d9a6("pc: add etc/e820 fw_cfg file") cc: kra...@redhat.com Signed-off-by: Ani Sinha ---