Re: [PATCH] hw/intc/arm_gicv3_cpuif: Tolerate spurious EOIR writes

2021-06-03 Thread Shashi Mallela
Yes it does. Thanks Shashi On Jun 3 2021, at 8:56 am, Peter Maydell wrote: > On Thu, 3 Jun 2021 at 12:01, Jean-Philippe Brucker > wrote: > > > > Commit 382c7160d1cd ("hw/intc/arm_gicv3_cpuif: Fix EOIR write access > > check logic") added an assert_not_reached() if the guest writes the EOIR > >

Re: [PATCH] hw/intc/arm_gicv3_cpuif: Tolerate spurious EOIR writes

2021-06-03 Thread Jean-Philippe Brucker
On Thu, Jun 03, 2021 at 02:39:30PM +0200, Philippe Mathieu-Daudé wrote: > > diff --git a/hw/intc/arm_gicv3_cpuif.c b/hw/intc/arm_gicv3_cpuif.c > > index 81f94c7f4a..1d0964c9bf 100644 > > --- a/hw/intc/arm_gicv3_cpuif.c > > +++ b/hw/intc/arm_gicv3_cpuif.c > > @@ -1357,7 +1357,8 @@ static void

Re: [PATCH] hw/intc/arm_gicv3_cpuif: Tolerate spurious EOIR writes

2021-06-03 Thread Peter Maydell
On Thu, 3 Jun 2021 at 12:01, Jean-Philippe Brucker wrote: > > Commit 382c7160d1cd ("hw/intc/arm_gicv3_cpuif: Fix EOIR write access > check logic") added an assert_not_reached() if the guest writes the EOIR > register while no interrupt is active. > > It turns out some software does this: EDK2, in

Re: [PATCH] hw/intc/arm_gicv3_cpuif: Tolerate spurious EOIR writes

2021-06-03 Thread Philippe Mathieu-Daudé
Hi Jean-Philippe, On 6/3/21 1:00 PM, Jean-Philippe Brucker wrote: > Commit 382c7160d1cd ("hw/intc/arm_gicv3_cpuif: Fix EOIR write access > check logic") added an assert_not_reached() if the guest writes the EOIR > register while no interrupt is active. > > It turns out some software does this:

[PATCH] hw/intc/arm_gicv3_cpuif: Tolerate spurious EOIR writes

2021-06-03 Thread Jean-Philippe Brucker
Commit 382c7160d1cd ("hw/intc/arm_gicv3_cpuif: Fix EOIR write access check logic") added an assert_not_reached() if the guest writes the EOIR register while no interrupt is active. It turns out some software does this: EDK2, in GicV3ExitBootServicesEvent(), unconditionally write EOIR for all