On Thu, Sep 29, 2022 at 8:54 AM Peter Maydell
wrote:
> On Thu, 29 Sept 2022 at 16:28, Patrick Venture wrote:
> > On Mon, Sep 26, 2022 at 8:45 AM Patrick Venture
> wrote:
> >>> I think what Jason is suggesting is that that should depend on what
> >>> the real hardware does. On a physical board,
On Thu, 29 Sept 2022 at 16:28, Patrick Venture wrote:
> On Mon, Sep 26, 2022 at 8:45 AM Patrick Venture wrote:
>>> I think what Jason is suggesting is that that should depend on what
>>> the real hardware does. On a physical board, if the guest sets the
>>> MAC address, and then you power-cycle
On Mon, Sep 26, 2022 at 8:45 AM Patrick Venture wrote:
>
>
> On Sat, Sep 24, 2022 at 2:10 AM Peter Maydell
> wrote:
>
>> On Sat, 24 Sept 2022 at 00:42, Patrick Venture
>> wrote:
>> > On Thu, Sep 22, 2022 at 8:21 PM Jason Wang wrote:
>> >>
>> >> On Thu, Sep 22, 2022 at 8:35 PM Peter Maydell <
On Sat, Sep 24, 2022 at 2:10 AM Peter Maydell
wrote:
> On Sat, 24 Sept 2022 at 00:42, Patrick Venture wrote:
> > On Thu, Sep 22, 2022 at 8:21 PM Jason Wang wrote:
> >>
> >> On Thu, Sep 22, 2022 at 8:35 PM Peter Maydell
> wrote:
> >> > A question to which I don't know the answer: if the guest
On Sat, 24 Sept 2022 at 00:42, Patrick Venture wrote:
> On Thu, Sep 22, 2022 at 8:21 PM Jason Wang wrote:
>>
>> On Thu, Sep 22, 2022 at 8:35 PM Peter Maydell
>> wrote:
>> > A question to which I don't know the answer: if the guest writes to
>> > the device to change the MAC address, should
On Thu, Sep 22, 2022 at 8:21 PM Jason Wang wrote:
> On Thu, Sep 22, 2022 at 8:35 PM Peter Maydell
> wrote:
> >
> > On Thu, 22 Sept 2022 at 00:47, Patrick Venture
> wrote:
> > >
> > > The MAC address set from Qemu wasn't being saved into the register
> space.
> > >
> > > Reviewed-by: Hao Wu
>
On Thu, Sep 22, 2022 at 8:35 PM Peter Maydell wrote:
>
> On Thu, 22 Sept 2022 at 00:47, Patrick Venture wrote:
> >
> > The MAC address set from Qemu wasn't being saved into the register space.
> >
> > Reviewed-by: Hao Wu
> > Signed-off-by: Patrick Venture
>
> > @@ -112,6 +115,18 @@ static void
On Thu, 22 Sept 2022 at 00:47, Patrick Venture wrote:
>
> The MAC address set from Qemu wasn't being saved into the register space.
>
> Reviewed-by: Hao Wu
> Signed-off-by: Patrick Venture
> @@ -112,6 +115,18 @@ static void emc_reset(NPCM7xxEMCState *emc)
>
> emc->tx_active = false;
>
The MAC address set from Qemu wasn't being saved into the register space.
Reviewed-by: Hao Wu
Signed-off-by: Patrick Venture
---
hw/net/npcm7xx_emc.c | 15 +++
1 file changed, 15 insertions(+)
diff --git a/hw/net/npcm7xx_emc.c b/hw/net/npcm7xx_emc.c
index 7c86bb52e5..6be1008529