Re: [PATCH] intel-iommu: Document iova_tree

2022-12-06 Thread Peter Xu
On Tue, Dec 06, 2022 at 05:28:01PM +0100, Eric Auger wrote: > > > On 12/6/22 17:05, Peter Xu wrote: > > On Tue, Dec 06, 2022 at 02:16:32PM +0100, Eric Auger wrote: > >> Hi Peter, > >> On 12/6/22 00:28, Peter Xu wrote: > >>> On Mon, Dec 05, 2022 at 12:23:20PM +0800, Jason Wang wrote: > On

Re: [PATCH] intel-iommu: Document iova_tree

2022-12-06 Thread Eric Auger
On 12/6/22 17:05, Peter Xu wrote: > On Tue, Dec 06, 2022 at 02:16:32PM +0100, Eric Auger wrote: >> Hi Peter, >> On 12/6/22 00:28, Peter Xu wrote: >>> On Mon, Dec 05, 2022 at 12:23:20PM +0800, Jason Wang wrote: On Fri, Dec 2, 2022 at 12:25 AM Peter Xu wrote: > It seems not super clear

Re: [PATCH] intel-iommu: Document iova_tree

2022-12-06 Thread Peter Xu
On Tue, Dec 06, 2022 at 02:16:32PM +0100, Eric Auger wrote: > Hi Peter, > On 12/6/22 00:28, Peter Xu wrote: > > On Mon, Dec 05, 2022 at 12:23:20PM +0800, Jason Wang wrote: > >> On Fri, Dec 2, 2022 at 12:25 AM Peter Xu wrote: > >>> It seems not super clear on when iova_tree is used, and why. Add

Re: [PATCH] intel-iommu: Document iova_tree

2022-12-06 Thread Peter Xu
On Tue, Dec 06, 2022 at 02:06:54PM +0100, Eric Auger wrote: > >>> + * current VTD address space, because all UNMAP (including iotlb or > >>> + * dev-iotlb) events can be transparently delivered to !MAP iommu > >>> + * notifiers. > >> because all UNMAP notifications (iotlb or dev-iotlb)

Re: [PATCH] intel-iommu: Document iova_tree

2022-12-06 Thread Eric Auger
Hi Peter, On 12/6/22 00:28, Peter Xu wrote: > On Mon, Dec 05, 2022 at 12:23:20PM +0800, Jason Wang wrote: >> On Fri, Dec 2, 2022 at 12:25 AM Peter Xu wrote: >>> It seems not super clear on when iova_tree is used, and why. Add a rich >>> comment above iova_tree to track why we needed the

Re: [PATCH] intel-iommu: Document iova_tree

2022-12-06 Thread Eric Auger
Hi Peter, On 12/1/22 20:22, Peter Xu wrote: > On Thu, Dec 01, 2022 at 07:17:41PM +0100, Eric Auger wrote: >> Hi Peter > Hi, Eric, > >> On 12/1/22 17:25, Peter Xu wrote: >>> It seems not super clear on when iova_tree is used, and why. Add a rich >>> comment above iova_tree to track why we needed

Re: [PATCH] intel-iommu: Document iova_tree

2022-12-05 Thread Jason Wang
On Tue, Dec 6, 2022 at 7:28 AM Peter Xu wrote: > > On Mon, Dec 05, 2022 at 12:23:20PM +0800, Jason Wang wrote: > > On Fri, Dec 2, 2022 at 12:25 AM Peter Xu wrote: > > > > > > It seems not super clear on when iova_tree is used, and why. Add a rich > > > comment above iova_tree to track why we

Re: [PATCH] intel-iommu: Document iova_tree

2022-12-05 Thread Peter Xu
On Mon, Dec 05, 2022 at 12:23:20PM +0800, Jason Wang wrote: > On Fri, Dec 2, 2022 at 12:25 AM Peter Xu wrote: > > > > It seems not super clear on when iova_tree is used, and why. Add a rich > > comment above iova_tree to track why we needed the iova_tree, and when we > > need it. > > > >

Re: [PATCH] intel-iommu: Document iova_tree

2022-12-04 Thread Jason Wang
On Fri, Dec 2, 2022 at 12:25 AM Peter Xu wrote: > > It seems not super clear on when iova_tree is used, and why. Add a rich > comment above iova_tree to track why we needed the iova_tree, and when we > need it. > > Suggested-by: Jason Wang > Signed-off-by: Peter Xu > --- >

Re: [PATCH] intel-iommu: Document iova_tree

2022-12-01 Thread Peter Xu
t it may confuse > > > > If it directly notifies the registered device with the unmodified range, it > > may confuse the drivers ../.. > > Will fix. > > > > > So the range of the MAP notification can be adapted based on the existing > > IOVA map

Re: [PATCH] intel-iommu: Document iova_tree

2022-12-01 Thread Peter Xu
On Thu, Dec 01, 2022 at 07:17:41PM +0100, Eric Auger wrote: > Hi Peter Hi, Eric, > > On 12/1/22 17:25, Peter Xu wrote: > > It seems not super clear on when iova_tree is used, and why. Add a rich > > comment above iova_tree to track why we needed the iova_tree, and when we > > need it. > > > >

Re: [PATCH] intel-iommu: Document iova_tree

2022-12-01 Thread Eric Auger
Hi Peter On 12/1/22 17:25, Peter Xu wrote: > It seems not super clear on when iova_tree is used, and why. Add a rich > comment above iova_tree to track why we needed the iova_tree, and when we > need it. > > Suggested-by: Jason Wang > Signed-off-by: Peter Xu > --- >

[PATCH] intel-iommu: Document iova_tree

2022-12-01 Thread Peter Xu
It seems not super clear on when iova_tree is used, and why. Add a rich comment above iova_tree to track why we needed the iova_tree, and when we need it. Suggested-by: Jason Wang Signed-off-by: Peter Xu --- include/hw/i386/intel_iommu.h | 30 +- 1 file changed, 29