Re: [PATCH] linux-user: Fix clang warning for nios2-linux-user code

2022-01-11 Thread Peter Maydell
On Tue, 11 Jan 2022 at 07:01, Laurent Vivier wrote: > > Le 10/01/2022 à 20:17, Peter Maydell a écrit : > > The clang in Ubuntu 18.04 (10.0.0-4ubuntu1) produces a warning > > on the code added in commit f5ef0e518d03 where we use a > > shifted expression in a boolean context: > > > > ../../linux-use

Re: [PATCH] linux-user: Fix clang warning for nios2-linux-user code

2022-01-10 Thread Laurent Vivier
Le 10/01/2022 à 20:17, Peter Maydell a écrit : The clang in Ubuntu 18.04 (10.0.0-4ubuntu1) produces a warning on the code added in commit f5ef0e518d03 where we use a shifted expression in a boolean context: ../../linux-user/elfload.c:2423:16: error: converting the result of '<<' to a boolean al

Re: [PATCH] linux-user: Fix clang warning for nios2-linux-user code

2022-01-10 Thread Warner Losh
> On Jan 10, 2022, at 12:17 PM, Peter Maydell wrote: > > The clang in Ubuntu 18.04 (10.0.0-4ubuntu1) produces a warning > on the code added in commit f5ef0e518d03 where we use a > shifted expression in a boolean context: > > ../../linux-user/elfload.c:2423:16: error: converting the result of

[PATCH] linux-user: Fix clang warning for nios2-linux-user code

2022-01-10 Thread Peter Maydell
The clang in Ubuntu 18.04 (10.0.0-4ubuntu1) produces a warning on the code added in commit f5ef0e518d03 where we use a shifted expression in a boolean context: ../../linux-user/elfload.c:2423:16: error: converting the result of '<<' to a boolean always evaluates to true [-Werror,-Wtautological-co