Re: [PATCH] m68k: Fix regression causing Single-Step via GDB/RSP to not single step

2020-01-15 Thread Richard Henderson
On 1/15/20 1:03 AM, Laurent Vivier wrote: > +if (dc->base.singlestep_enabled) { > +tcg_gen_movi_i32(QREG_PC, dc->pc); > +gen_helper_raise_exception(cpu_env, tcg_const_i32(EXCP_DEBUG)); This leaks the temporary, and so not quite ideal. It would be of more concern if

[PATCH] m68k: Fix regression causing Single-Step via GDB/RSP to not single step

2020-01-15 Thread Laurent Vivier
A regression that was introduced, with the refactor to TranslatorOps, drops two lines that update the PC when single-stepping is being performed. Fixes: 11ab74b01e0a ("target/m68k: Convert to TranslatorOps") Reported-by: Lucien Murray-Pitts Suggested-by: Lucien Murray-Pitts Suggested-by: Richard