RE: [PATCH] migration/block-dirty-bitmap: fix uninitialized variable warning

2020-10-13 Thread Chenqun (kuhn)
> Le 10/10/2020 à 13:07, Chen Qun a écrit : > > This if statement judgment is redundant and it will cause a warning: > > > > migration/block-dirty-bitmap.c:1090:13: warning: ‘bitmap_name’ may > > be used uninitialized in this function [-Wmaybe-uninitialized] > >

Re: [PATCH] migration/block-dirty-bitmap: fix uninitialized variable warning

2020-10-13 Thread Vladimir Sementsov-Ogievskiy
...@nongnu.org; Qemu Developers ; Dr. David Alan Gilbert ; Stefan Hajnoczi ; Euler Robot ; Chenqun (kuhn) ; Max Reitz ; John Snow Subject: Re: [PATCH] migration/block-dirty-bitmap: fix uninitialized variable warning Le 13/10/2020 à 03:34, Li Qiang a écrit : Laurent Vivier 于2020年10月12日周一 下午11:33 写道: Le

RE: [PATCH] migration/block-dirty-bitmap: fix uninitialized variable warning

2020-10-13 Thread Chenqun (kuhn)
gnu.org; Qemu Developers > ; Dr. David Alan Gilbert ; > Stefan Hajnoczi ; Euler Robot > ; Chenqun (kuhn) ; > Max Reitz ; John Snow > Subject: Re: [PATCH] migration/block-dirty-bitmap: fix uninitialized variable > warning > > Le 13/10/2020 à 03:34, Li Qiang a écrit :

RE: [PATCH] migration/block-dirty-bitmap: fix uninitialized variable warning

2020-10-13 Thread Chenqun (kuhn)
migration/block-dirty-bitmap.c > > > b/migration/block-dirty-bitmap.c index 5bef793ac0..e09ea4f22b 100644 > > > --- a/migration/block-dirty-bitmap.c > > > +++ b/migration/block-dirty-bitmap.c > > > @@ -1084,9 +1084,7 @@ static int dirty_bitmap_load_header(QEMUFile > *f, DBMLoadState *s, > > >

Re: [PATCH] migration/block-dirty-bitmap: fix uninitialized variable warning

2020-10-13 Thread Laurent Vivier
Le 13/10/2020 à 03:34, Li Qiang a écrit : > Laurent Vivier 于2020年10月12日周一 下午11:33写道: >> >> Le 10/10/2020 à 13:07, Chen Qun a écrit : >>> This if statement judgment is redundant and it will cause a warning: >>> >>> migration/block-dirty-bitmap.c:1090:13: warning: ‘bitmap_name’ may be used >>> unin

Re: [PATCH] migration/block-dirty-bitmap: fix uninitialized variable warning

2020-10-12 Thread Li Qiang
Laurent Vivier 于2020年10月12日周一 下午11:33写道: > > Le 10/10/2020 à 13:07, Chen Qun a écrit : > > This if statement judgment is redundant and it will cause a warning: > > > > migration/block-dirty-bitmap.c:1090:13: warning: ‘bitmap_name’ may be used > > uninitialized in this function [-Wmaybe-uninitiali

Re: [PATCH] migration/block-dirty-bitmap: fix uninitialized variable warning

2020-10-12 Thread Laurent Vivier
Le 10/10/2020 à 13:07, Chen Qun a écrit : > This if statement judgment is redundant and it will cause a warning: > > migration/block-dirty-bitmap.c:1090:13: warning: ‘bitmap_name’ may be used > uninitialized in this function [-Wmaybe-uninitialized] > g_strlcpy(s->bitmap_name, bitmap_

Re: [PATCH] migration/block-dirty-bitmap: fix uninitialized variable warning

2020-10-10 Thread Li Qiang
Chen Qun 于2020年10月10日周六 下午7:08写道: > > This if statement judgment is redundant and it will cause a warning: > > migration/block-dirty-bitmap.c:1090:13: warning: ‘bitmap_name’ may be used > uninitialized in this function [-Wmaybe-uninitialized] > g_strlcpy(s->bitmap_name, bitmap_name,

[PATCH] migration/block-dirty-bitmap: fix uninitialized variable warning

2020-10-10 Thread Chen Qun
This if statement judgment is redundant and it will cause a warning: migration/block-dirty-bitmap.c:1090:13: warning: ‘bitmap_name’ may be used uninitialized in this function [-Wmaybe-uninitialized] g_strlcpy(s->bitmap_name, bitmap_name, sizeof(s->bitmap_name)); ^~~~