Re: [PATCH] migration: Truncate state file in xen-save-devices-state

2020-09-28 Thread Marek Marczykowski-Górecki
On Mon, Sep 28, 2020 at 05:46:18PM +0100, Anthony PERARD wrote: > On Mon, Sep 21, 2020 at 12:17:23PM +0100, Dr. David Alan Gilbert wrote: > > * Dov Murik (dovmu...@linux.vnet.ibm.com) wrote: > > > When running the xen-save-devices-state QMP command, if the filename > > > already exists it will be t

Re: [PATCH] migration: Truncate state file in xen-save-devices-state

2020-09-28 Thread Anthony PERARD via
On Mon, Sep 21, 2020 at 12:17:23PM +0100, Dr. David Alan Gilbert wrote: > * Dov Murik (dovmu...@linux.vnet.ibm.com) wrote: > > When running the xen-save-devices-state QMP command, if the filename > > already exists it will be truncated before dumping the devices' state > > into it. > > > > Signed-

Re: [PATCH] migration: Truncate state file in xen-save-devices-state

2020-09-23 Thread Dr. David Alan Gilbert
* Dr. David Alan Gilbert (dgilb...@redhat.com) wrote: > * Dov Murik (dovmu...@linux.vnet.ibm.com) wrote: > > When running the xen-save-devices-state QMP command, if the filename > > already exists it will be truncated before dumping the devices' state > > into it. > > > > Signed-off-by: Dov Murik

Re: [PATCH] migration: Truncate state file in xen-save-devices-state

2020-09-21 Thread Stefano Stabellini
Adding Paul On Mon, 21 Sep 2020, Dr. David Alan Gilbert wrote: > * Dov Murik (dovmu...@linux.vnet.ibm.com) wrote: > > > > > > On 21/09/2020 14:17, Dr. David Alan Gilbert wrote: > > > * Dov Murik (dovmu...@linux.vnet.ibm.com) wrote: > > > > When running the xen-save-devices-state QMP command, if

Re: [PATCH] migration: Truncate state file in xen-save-devices-state

2020-09-21 Thread Dr. David Alan Gilbert
* Dov Murik (dovmu...@linux.vnet.ibm.com) wrote: > > > On 21/09/2020 14:17, Dr. David Alan Gilbert wrote: > > * Dov Murik (dovmu...@linux.vnet.ibm.com) wrote: > > > When running the xen-save-devices-state QMP command, if the filename > > > already exists it will be truncated before dumping the de

Re: [PATCH] migration: Truncate state file in xen-save-devices-state

2020-09-21 Thread Dov Murik
On 21/09/2020 14:17, Dr. David Alan Gilbert wrote: * Dov Murik (dovmu...@linux.vnet.ibm.com) wrote: When running the xen-save-devices-state QMP command, if the filename already exists it will be truncated before dumping the devices' state into it. Signed-off-by: Dov Murik --- OK, that loo

Re: [PATCH] migration: Truncate state file in xen-save-devices-state

2020-09-21 Thread Dr. David Alan Gilbert
* Dov Murik (dovmu...@linux.vnet.ibm.com) wrote: > When running the xen-save-devices-state QMP command, if the filename > already exists it will be truncated before dumping the devices' state > into it. > > Signed-off-by: Dov Murik > --- OK, that looks fine to me, so: Reviewed-by: Dr. David Ala

[PATCH] migration: Truncate state file in xen-save-devices-state

2020-09-21 Thread Dov Murik
When running the xen-save-devices-state QMP command, if the filename already exists it will be truncated before dumping the devices' state into it. Signed-off-by: Dov Murik --- Note that I found the above issue while trying to debug xen-load-devices-state which simply fails (prints "Configuratio