Re: [PATCH] net: remove an assert call in eth_get_gso_type

2020-10-20 Thread P J P
+-- On Tue, 20 Oct 2020, Philippe Mathieu-Daudé wrote --+ | Maybe LOG_UNIMP with useful fields, so when user send bug report we directly | know what has to be implemented. qemu_log("Probably not GSO frame, unknown L3 protocol: %hd\n", l3_proto); Maybe just qemu_log()? LOG_UNIMP seems

Re: [PATCH] net: remove an assert call in eth_get_gso_type

2020-10-20 Thread Philippe Mathieu-Daudé
On 10/20/20 10:11 AM, P J P wrote: From: Prasad J Pandit eth_get_gso_type() routine returns segmentation offload type to use based on L3 protocol type. It calls g_assert_not_reached if L3 protocol is unknown, making the following return statement unreachable. Remove the g_assert call, as it

[PATCH] net: remove an assert call in eth_get_gso_type

2020-10-20 Thread P J P
From: Prasad J Pandit eth_get_gso_type() routine returns segmentation offload type to use based on L3 protocol type. It calls g_assert_not_reached if L3 protocol is unknown, making the following return statement unreachable. Remove the g_assert call, as it maybe triggered by a guest user.