Re: [PATCH] ppc/pnv: Introduce common PNV_SETFIELD() and PNV_GETFIELD() macros

2020-04-03 Thread David Gibson
On Thu, Apr 02, 2020 at 09:18:09AM +0200, Cédric Le Goater wrote: > On 4/2/20 8:50 AM, David Gibson wrote: > > On Thu, Apr 02, 2020 at 08:41:24AM +0200, Cédric Le Goater wrote: > >> On 4/2/20 2:31 AM, David Gibson wrote: > >>> On Wed, Apr 01, 2020 at 05:26:33PM +0200, Cédric Le Goater wrote: >

Re: [PATCH] ppc/pnv: Introduce common PNV_SETFIELD() and PNV_GETFIELD() macros

2020-04-02 Thread Cédric Le Goater
On 4/2/20 8:50 AM, David Gibson wrote: > On Thu, Apr 02, 2020 at 08:41:24AM +0200, Cédric Le Goater wrote: >> On 4/2/20 2:31 AM, David Gibson wrote: >>> On Wed, Apr 01, 2020 at 05:26:33PM +0200, Cédric Le Goater wrote: Most of QEMU definitions of the register fields of the PowerNV machine

Re: [PATCH] ppc/pnv: Introduce common PNV_SETFIELD() and PNV_GETFIELD() macros

2020-04-02 Thread David Gibson
On Thu, Apr 02, 2020 at 08:41:24AM +0200, Cédric Le Goater wrote: > On 4/2/20 2:31 AM, David Gibson wrote: > > On Wed, Apr 01, 2020 at 05:26:33PM +0200, Cédric Le Goater wrote: > >> Most of QEMU definitions of the register fields of the PowerNV machine > >> come from skiboot and the models

Re: [PATCH] ppc/pnv: Introduce common PNV_SETFIELD() and PNV_GETFIELD() macros

2020-04-02 Thread Cédric Le Goater
On 4/2/20 2:31 AM, David Gibson wrote: > On Wed, Apr 01, 2020 at 05:26:33PM +0200, Cédric Le Goater wrote: >> Most of QEMU definitions of the register fields of the PowerNV machine >> come from skiboot and the models duplicate a set of macros for this >> purpose. Make them common under the

Re: [PATCH] ppc/pnv: Introduce common PNV_SETFIELD() and PNV_GETFIELD() macros

2020-04-01 Thread David Gibson
On Wed, Apr 01, 2020 at 05:26:33PM +0200, Cédric Le Goater wrote: > Most of QEMU definitions of the register fields of the PowerNV machine > come from skiboot and the models duplicate a set of macros for this > purpose. Make them common under the pnv_utils.h file. > > Signed-off-by: Cédric Le

Re: [PATCH] ppc/pnv: Introduce common PNV_SETFIELD() and PNV_GETFIELD() macros

2020-04-01 Thread Greg Kurz
On Wed, 1 Apr 2020 17:26:33 +0200 Cédric Le Goater wrote: > Most of QEMU definitions of the register fields of the PowerNV machine > come from skiboot and the models duplicate a set of macros for this > purpose. Make them common under the pnv_utils.h file. > > Signed-off-by: Cédric Le Goater

[PATCH] ppc/pnv: Introduce common PNV_SETFIELD() and PNV_GETFIELD() macros

2020-04-01 Thread Cédric Le Goater
Most of QEMU definitions of the register fields of the PowerNV machine come from skiboot and the models duplicate a set of macros for this purpose. Make them common under the pnv_utils.h file. Signed-off-by: Cédric Le Goater --- include/hw/pci-host/pnv_phb3_regs.h | 16 --