Re: [PATCH] qio: fix command spawn RDONLY/WRONLY

2022-09-01 Thread Daniel P . Berrangé
On Thu, Sep 01, 2022 at 02:47:17PM +0400, Marc-André Lureau wrote: > Hi > > On Thu, Sep 1, 2022 at 2:32 PM Daniel P. Berrangé > wrote: > > > On Thu, Sep 01, 2022 at 02:11:20PM +0400, marcandre.lur...@redhat.com > > wrote: > > > From: Marc-André Lureau > > > > > > The in/out handling is

Re: [PATCH] qio: fix command spawn RDONLY/WRONLY

2022-09-01 Thread Marc-André Lureau
Hi On Thu, Sep 1, 2022 at 2:32 PM Daniel P. Berrangé wrote: > On Thu, Sep 01, 2022 at 02:11:20PM +0400, marcandre.lur...@redhat.com > wrote: > > From: Marc-André Lureau > > > > The in/out handling is inverted, although nothing seemed to notice that > yet. > > On the contrary, it is correct,

Re: [PATCH] qio: fix command spawn RDONLY/WRONLY

2022-09-01 Thread Daniel P . Berrangé
On Thu, Sep 01, 2022 at 02:11:20PM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > The in/out handling is inverted, although nothing seemed to notice that yet. On the contrary, it is correct, and the unit tests validate this. > Signed-off-by: Marc-André Lureau > --- >

[PATCH] qio: fix command spawn RDONLY/WRONLY

2022-09-01 Thread marcandre . lureau
From: Marc-André Lureau The in/out handling is inverted, although nothing seemed to notice that yet. Signed-off-by: Marc-André Lureau --- io/channel-command.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/io/channel-command.c b/io/channel-command.c index