Re: [PATCH] qom: Improve error message displayed with missing object properties

2020-10-05 Thread Philippe Mathieu-Daudé
On 10/5/20 6:42 PM, Eduardo Habkost wrote: > On Mon, Oct 05, 2020 at 10:46:38AM +0200, Paolo Bonzini wrote: >> On 20/09/20 17:53, Philippe Mathieu-Daudé wrote: >>> Instead of only displaying the property missing, also display >>> the object name. This help developer to quickly figure out the >>>

Re: [PATCH] qom: Improve error message displayed with missing object properties

2020-10-05 Thread Eduardo Habkost
On Mon, Oct 05, 2020 at 10:46:38AM +0200, Paolo Bonzini wrote: > On 20/09/20 17:53, Philippe Mathieu-Daudé wrote: > > Instead of only displaying the property missing, also display > > the object name. This help developer to quickly figure out the > > mistake without opening a debugger. > > > >

Re: [PATCH] qom: Improve error message displayed with missing object properties

2020-10-05 Thread Paolo Bonzini
On 20/09/20 17:53, Philippe Mathieu-Daudé wrote: > Instead of only displaying the property missing, also display > the object name. This help developer to quickly figure out the > mistake without opening a debugger. > > Signed-off-by: Philippe Mathieu-Daudé > --- > qom/object.c | 3 ++- > 1

Re: [PATCH] qom: Improve error message displayed with missing object properties

2020-10-05 Thread Philippe Mathieu-Daudé
Eduardo, can you take this patch, or can it goes via qemu-trivial? On 9/20/20 5:53 PM, Philippe Mathieu-Daudé wrote: > Instead of only displaying the property missing, also display > the object name. This help developer to quickly figure out the > mistake without opening a debugger. > >

Re: [PATCH] qom: Improve error message displayed with missing object properties

2020-09-20 Thread Li Qiang
Philippe Mathieu-Daudé 于2020年9月20日周日 下午11:54写道: > > Instead of only displaying the property missing, also display > the object name. This help developer to quickly figure out the > mistake without opening a debugger. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Li Qiang > --- >

[PATCH] qom: Improve error message displayed with missing object properties

2020-09-20 Thread Philippe Mathieu-Daudé
Instead of only displaying the property missing, also display the object name. This help developer to quickly figure out the mistake without opening a debugger. Signed-off-by: Philippe Mathieu-Daudé --- qom/object.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git