Re: [PATCH] string-output-visitor: Fix (pseudo) struct handling

2024-01-17 Thread Markus Armbruster
Kevin Wolf writes: > Am 11.01.2024 um 12:45 hat Markus Armbruster geschrieben: >> Kevin Wolf writes: >> >> > Commit ff32bb53 tried to get minimal struct support into the string >> > output visitor by just making it return "". Unfortunately, it >> > forgot that the caller will still make more

Re: [PATCH] string-output-visitor: Fix (pseudo) struct handling

2024-01-16 Thread Stefan Hajnoczi
On Tue, Jan 09, 2024 at 07:17:17PM +0100, Kevin Wolf wrote: > Commit ff32bb53 tried to get minimal struct support into the string > output visitor by just making it return "". Unfortunately, it > forgot that the caller will still make more visitor calls for the > content of the struct. > > If the

Re: [PATCH] string-output-visitor: Fix (pseudo) struct handling

2024-01-15 Thread Kevin Wolf
Am 11.01.2024 um 12:45 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > Commit ff32bb53 tried to get minimal struct support into the string > > output visitor by just making it return "". Unfortunately, it > > forgot that the caller will still make more visitor calls for the > >

Re: [PATCH] string-output-visitor: Fix (pseudo) struct handling

2024-01-11 Thread Markus Armbruster
Kevin Wolf writes: > Commit ff32bb53 tried to get minimal struct support into the string > output visitor by just making it return "". Unfortunately, it > forgot that the caller will still make more visitor calls for the > content of the struct. > > If the struct is contained in a list, such as

[PATCH] string-output-visitor: Fix (pseudo) struct handling

2024-01-09 Thread Kevin Wolf
Commit ff32bb53 tried to get minimal struct support into the string output visitor by just making it return "". Unfortunately, it forgot that the caller will still make more visitor calls for the content of the struct. If the struct is contained in a list, such as IOThreadVirtQueueMapping, in the