Re: [PATCH] target/arm: fix incorrect current EL bug in aarch32 exception emulation

2020-03-30 Thread Peter Maydell
On Sat, 28 Mar 2020 at 14:02, Changbin Du wrote: > > The arm_current_el() should be invoked after mode switching. Otherwise, we > get a wrong current EL value, since current EL is also determined by > current mode. > > Fixes: 4a2696c0d4 ("target/arm: Set PAN bit as required on exception entry") >

Re: [PATCH] target/arm: fix incorrect current EL bug in aarch32 exception emulation

2020-03-30 Thread Changbin Du
Hi, Peter, Could you take this fix as high priority? This bug has made qemu-system-arm broken. On Sat, Mar 28, 2020 at 10:02:32PM +0800, Changbin Du wrote: > The arm_current_el() should be invoked after mode switching. Otherwise, we > get a wrong current EL value, since current EL is also

Re: [PATCH] target/arm: fix incorrect current EL bug in aarch32 exception emulation

2020-03-28 Thread Richard Henderson
On 3/28/20 7:02 AM, Changbin Du wrote: > The arm_current_el() should be invoked after mode switching. Otherwise, we > get a wrong current EL value, since current EL is also determined by > current mode. > > Fixes: 4a2696c0d4 ("target/arm: Set PAN bit as required on exception entry") >

[PATCH] target/arm: fix incorrect current EL bug in aarch32 exception emulation

2020-03-28 Thread Changbin Du
The arm_current_el() should be invoked after mode switching. Otherwise, we get a wrong current EL value, since current EL is also determined by current mode. Fixes: 4a2696c0d4 ("target/arm: Set PAN bit as required on exception entry") Signed-off-by: Changbin Du --- target/arm/helper.c | 5 -