Re: [PATCH] target/mips: fix emulation of nanoMIPS BPOSGE32 instruction

2021-06-22 Thread Philippe Mathieu-Daudé
Hi Filip and Aleksandar, On 6/15/21 7:33 PM, Philippe Mathieu-Daudé wrote: > On 6/15/21 7:22 PM, Aleksandar Rikalo wrote: >> Per the "MIPS® Architecture Extension: nanoMIPS32 DSP Technical >> Reference Manual — Revision 0.04" p. 88 "BPOSGE32C", offset argument (imm) >> should be left-shifted

Re: [PATCH] target/mips: fix emulation of nanoMIPS BPOSGE32 instruction

2021-06-19 Thread Philippe Mathieu-Daudé
On 6/15/21 7:22 PM, Aleksandar Rikalo wrote: > Per the "MIPS® Architecture Extension: nanoMIPS32 DSP Technical > Reference Manual — Revision 0.04" p. 88 "BPOSGE32C", offset argument (imm) > should be left-shifted first. > This change was tested against test_dsp_r1_bposge32.c DSP test. > >

Re: [PATCH] target/mips: fix emulation of nanoMIPS BPOSGE32 instruction

2021-06-15 Thread Philippe Mathieu-Daudé
On 6/15/21 7:22 PM, Aleksandar Rikalo wrote: > Per the "MIPS® Architecture Extension: nanoMIPS32 DSP Technical > Reference Manual — Revision 0.04" p. 88 "BPOSGE32C", offset argument (imm) > should be left-shifted first. > This change was tested against test_dsp_r1_bposge32.c DSP test. Thank you!

[PATCH] target/mips: fix emulation of nanoMIPS BPOSGE32 instruction

2021-06-15 Thread Aleksandar Rikalo
Per the "MIPS® Architecture Extension: nanoMIPS32 DSP Technical Reference Manual — Revision 0.04" p. 88 "BPOSGE32C", offset argument (imm) should be left-shifted first. This change was tested against test_dsp_r1_bposge32.c DSP test. Reviewed-by: Aleksandar Rikalo Signed-off-by: Filip Vidojevic