Re: [PATCH] target/ppc: Fix rlwinm on ppc64

2020-03-15 Thread David Gibson
On Wed, Mar 11, 2020 at 04:00:22PM +0300, Vitaly Chikunov wrote: > David, > > On Wed, Mar 11, 2020 at 10:15:03AM +1100, David Gibson wrote: > > On Mon, Mar 09, 2020 at 11:45:57PM +0300, Vitaly Chikunov wrote: > > > rlwinm cannot just AND with Mask if shift value is zero on ppc64 when > > > Mask

Re: [PATCH] target/ppc: Fix rlwinm on ppc64

2020-03-11 Thread Vitaly Chikunov
David, On Wed, Mar 11, 2020 at 10:15:03AM +1100, David Gibson wrote: > On Mon, Mar 09, 2020 at 11:45:57PM +0300, Vitaly Chikunov wrote: > > rlwinm cannot just AND with Mask if shift value is zero on ppc64 when > > Mask Begin is greater than Mask End and high bits are set to 1. > > > > Note that

Re: [PATCH] target/ppc: Fix rlwinm on ppc64

2020-03-10 Thread David Gibson
On Mon, Mar 09, 2020 at 11:45:57PM +0300, Vitaly Chikunov wrote: > rlwinm cannot just AND with Mask if shift value is zero on ppc64 when > Mask Begin is greater than Mask End and high bits are set to 1. > > Note that PowerISA 3.0B says that for `rlwinm' ROTL32 is used, and > ROTL32 is defined (in

Re: [PATCH] target/ppc: Fix rlwinm on ppc64

2020-03-09 Thread Richard Henderson
On 3/9/20 1:45 PM, Vitaly Chikunov wrote: > rlwinm cannot just AND with Mask if shift value is zero on ppc64 when > Mask Begin is greater than Mask End and high bits are set to 1. > > Note that PowerISA 3.0B says that for `rlwinm' ROTL32 is used, and > ROTL32 is defined (in 3.3.14) so that

Re: [PATCH] target/ppc: Fix rlwinm on ppc64

2020-03-09 Thread David Gibson
On Mon, Mar 09, 2020 at 11:45:57PM +0300, Vitaly Chikunov wrote: > rlwinm cannot just AND with Mask if shift value is zero on ppc64 when > Mask Begin is greater than Mask End and high bits are set to 1. > > Note that PowerISA 3.0B says that for `rlwinm' ROTL32 is used, and > ROTL32 is defined (in

Re: [PATCH] target/ppc: Fix rlwinm on ppc64

2020-03-09 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200309204557.14836-1...@altlinux.org/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash export

[PATCH] target/ppc: Fix rlwinm on ppc64

2020-03-09 Thread Vitaly Chikunov
rlwinm cannot just AND with Mask if shift value is zero on ppc64 when Mask Begin is greater than Mask End and high bits are set to 1. Note that PowerISA 3.0B says that for `rlwinm' ROTL32 is used, and ROTL32 is defined (in 3.3.14) so that rotated value should have two copies of lower word of the