Re: [PATCH] target/riscv/kvm: do not use non-portable strerrorname_np()

2023-12-23 Thread Michael Tokarev
18.12.2023 19:22, Natanael Copa: strerrorname_np is non-portable and breaks building with musl libc. Use strerror(errno) instead, like we do other places. Applied to the trivial-patches tree, finally.. /mjt

Re: [PATCH] target/riscv/kvm: do not use non-portable strerrorname_np()

2023-12-19 Thread Peter Maydell
On Mon, 18 Dec 2023 at 18:34, Daniel Henrique Barboza wrote: > On 12/18/23 14:53, Peter Maydell wrote: > > On Mon, 18 Dec 2023 at 17:22, Daniel Henrique Barboza > > wrote: > > We don't seem to worry about that in any of the other > > KVM code -- accel/kvm/ has lots of places that > > use

Re: [PATCH] target/riscv/kvm: do not use non-portable strerrorname_np()

2023-12-18 Thread Daniel Henrique Barboza
On 12/18/23 18:35, Michael Tokarev wrote: 18.12.2023 20:20, Daniel Henrique Barboza wrote: On 12/18/23 13:22, Natanael Copa wrote: strerrorname_np is non-portable and breaks building with musl libc. Use strerror(errno) instead, like we do other places. Cc: qemu-sta...@nongnu.org Fixes:

Re: [PATCH] target/riscv/kvm: do not use non-portable strerrorname_np()

2023-12-18 Thread Michael Tokarev
18.12.2023 20:20, Daniel Henrique Barboza wrote: On 12/18/23 13:22, Natanael Copa wrote: strerrorname_np is non-portable and breaks building with musl libc. Use strerror(errno) instead, like we do other places. Cc: qemu-sta...@nongnu.org Fixes: commit 082e9e4a58ba (target/riscv/kvm: improve

Re: [PATCH] target/riscv/kvm: do not use non-portable strerrorname_np()

2023-12-18 Thread Daniel Henrique Barboza
On 12/18/23 13:22, Natanael Copa wrote: strerrorname_np is non-portable and breaks building with musl libc. Use strerror(errno) instead, like we do other places. Cc: qemu-sta...@nongnu.org Fixes: commit 082e9e4a58ba (target/riscv/kvm: improve 'init_multiext_cfg' error msg) Resolves:

Re: [PATCH] target/riscv/kvm: do not use non-portable strerrorname_np()

2023-12-18 Thread Daniel Henrique Barboza
On 12/18/23 14:53, Peter Maydell wrote: On Mon, 18 Dec 2023 at 17:22, Daniel Henrique Barboza wrote: On 12/18/23 13:22, Natanael Copa wrote: strerrorname_np is non-portable and breaks building with musl libc. Use strerror(errno) instead, like we do other places. Cc:

Re: [PATCH] target/riscv/kvm: do not use non-portable strerrorname_np()

2023-12-18 Thread Peter Maydell
On Mon, 18 Dec 2023 at 17:22, Daniel Henrique Barboza wrote: > > > > On 12/18/23 13:22, Natanael Copa wrote: > > strerrorname_np is non-portable and breaks building with musl libc. > > > > Use strerror(errno) instead, like we do other places. > > > > Cc: qemu-sta...@nongnu.org > > Fixes: commit

Re: [PATCH] target/riscv/kvm: do not use non-portable strerrorname_np()

2023-12-18 Thread Daniel Henrique Barboza
On 12/18/23 13:22, Natanael Copa wrote: strerrorname_np is non-portable and breaks building with musl libc. Use strerror(errno) instead, like we do other places. Cc: qemu-sta...@nongnu.org Fixes: commit 082e9e4a58ba (target/riscv/kvm: improve 'init_multiext_cfg' error msg) Resolves:

[PATCH] target/riscv/kvm: do not use non-portable strerrorname_np()

2023-12-18 Thread Natanael Copa
strerrorname_np is non-portable and breaks building with musl libc. Use strerror(errno) instead, like we do other places. Cc: qemu-sta...@nongnu.org Fixes: commit 082e9e4a58ba (target/riscv/kvm: improve 'init_multiext_cfg' error msg) Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2041