Re: [PATCH] target/tricore: Remove unused fields from CPUTriCoreState

2023-01-18 Thread Richard Henderson
On 1/17/23 23:03, Bastian Koppelmann wrote: I'm not sure of the purpose of the hflags. I assume they are hidden flags that hold some hidden state of the emulated CPU. However are privilege levels really hidden state? At least in the TriCore any guest software can read PSW at any privilege level

Re: [PATCH] target/tricore: Remove unused fields from CPUTriCoreState

2023-01-18 Thread Bastian Koppelmann
On Tue, Jan 17, 2023 at 07:42:17PM +0100, Philippe Mathieu-Daudé wrote: > Remove dead code: > - unused fields in CPUTriCoreState > - (unexisting) tricore_def_t structure > - forward declaration of tricore_boot_info structure > (declared in "hw/tricore/tricore.h", used once in >

Re: [PATCH] target/tricore: Remove unused fields from CPUTriCoreState

2023-01-18 Thread Bastian Koppelmann
Hi Richard, On Tue, Jan 17, 2023 at 11:01:37AM -1000, Richard Henderson wrote: > On 1/17/23 08:42, Philippe Mathieu-Daudé wrote: > > Remove dead code: > > - unused fields in CPUTriCoreState > > - (unexisting) tricore_def_t structure > > - forward declaration of tricore_boot_info structure > >

Re: [PATCH] target/tricore: Remove unused fields from CPUTriCoreState

2023-01-17 Thread Richard Henderson
On 1/17/23 08:42, Philippe Mathieu-Daudé wrote: Remove dead code: - unused fields in CPUTriCoreState - (unexisting) tricore_def_t structure - forward declaration of tricore_boot_info structure (declared in "hw/tricore/tricore.h", used once in hw/tricore/tricore_testboard.c).

[PATCH] target/tricore: Remove unused fields from CPUTriCoreState

2023-01-17 Thread Philippe Mathieu-Daudé
Remove dead code: - unused fields in CPUTriCoreState - (unexisting) tricore_def_t structure - forward declaration of tricore_boot_info structure (declared in "hw/tricore/tricore.h", used once in hw/tricore/tricore_testboard.c). Signed-off-by: Philippe Mathieu-Daudé --- target/tricore/cpu.h