Re: [PATCH] target/unicore32: Remove CURSES stuff from the Makefile.objs

2020-07-24 Thread Guan Xuetao
That's OK for unicore32 target. Acked-by: Guan Xuetao > -原始邮件- > 发件人: "Thomas Huth" > 发送时间: 2020-07-23 21:22:19 (星期四) > 收件人: "Guan Xuetao" , qemu-devel@nongnu.org > 抄送: "Philippe Mathieu-Daudé" , qemu-triv...@nongnu.org, > "Richa

Re: [PATCH] target/unicore32: Remove CURSES stuff from the Makefile.objs

2020-07-23 Thread Thomas Huth
On 23/07/2020 16.50, Peter Maydell wrote: > On Thu, 23 Jul 2020 at 14:23, Thomas Huth wrote: >> >> The dependency on curses has been removed in commit c7a856b42e403e2b >> ("target/unicore32: Prefer qemu_semihosting_log_out() over curses"). >> So we can remove the related lines in the Makefile

Re: [PATCH] target/unicore32: Remove CURSES stuff from the Makefile.objs

2020-07-23 Thread Philippe Mathieu-Daudé
On 7/23/20 3:45 PM, Thomas Huth wrote: > On 23/07/2020 15.42, Philippe Mathieu-Daudé wrote: >> On 7/23/20 3:22 PM, Thomas Huth wrote: >>> The dependency on curses has been removed in commit c7a856b42e403e2b >>> ("target/unicore32: Prefer qemu_semihosting_log_out() over curses"). >>> So we can

Re: [PATCH] target/unicore32: Remove CURSES stuff from the Makefile.objs

2020-07-23 Thread Peter Maydell
On Thu, 23 Jul 2020 at 14:23, Thomas Huth wrote: > > The dependency on curses has been removed in commit c7a856b42e403e2b > ("target/unicore32: Prefer qemu_semihosting_log_out() over curses"). > So we can remove the related lines in the Makefile now, too. > > Signed-off-by: Thomas Huth

Re: [PATCH] target/unicore32: Remove CURSES stuff from the Makefile.objs

2020-07-23 Thread Thomas Huth
On 23/07/2020 15.42, Philippe Mathieu-Daudé wrote: > On 7/23/20 3:22 PM, Thomas Huth wrote: >> The dependency on curses has been removed in commit c7a856b42e403e2b >> ("target/unicore32: Prefer qemu_semihosting_log_out() over curses"). >> So we can remove the related lines in the Makefile now,

Re: [PATCH] target/unicore32: Remove CURSES stuff from the Makefile.objs

2020-07-23 Thread Philippe Mathieu-Daudé
On 7/23/20 3:22 PM, Thomas Huth wrote: > The dependency on curses has been removed in commit c7a856b42e403e2b > ("target/unicore32: Prefer qemu_semihosting_log_out() over curses"). > So we can remove the related lines in the Makefile now, too. Don't we also need to remove all uses of

[PATCH] target/unicore32: Remove CURSES stuff from the Makefile.objs

2020-07-23 Thread Thomas Huth
The dependency on curses has been removed in commit c7a856b42e403e2b ("target/unicore32: Prefer qemu_semihosting_log_out() over curses"). So we can remove the related lines in the Makefile now, too. Signed-off-by: Thomas Huth --- target/unicore32/Makefile.objs | 4 1 file changed, 4