Re: [PATCH] tcg: Fix tcg gen for vectorized absolute value

2020-08-13 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200812223110.229-1-stepl...@quicinc.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20200812223110.229-1-stepl...@quicinc.com Subject: [PATCH] tcg: Fix tcg gen for vectorized

[PATCH] tcg: Fix tcg gen for vectorized absolute value

2020-08-12 Thread Stephen Long
--- tcg/tcg-op-gvec.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) qemu was generating buggy tcg for arm64's vectorized absolute value insn when the machine didn't support avx insns. Subtracting a mask of -1 for each negative element doesn't add 1 to each negative element. For exam