Re: [PATCH] trace/simple: Allow enabling simple traces from command line

2020-08-04 Thread Markus Armbruster
Josh DuBois writes: > On Aug 3, 2020, at 4:08 AM, Markus Armbruster wrote: >> >>> >>> - prior to db25d56c014aa1a96319c663e0a60346a223b31e, just like today, >>> QEMU built with simple tracing will always produce a trace- file, >>> regardless of whether the user asks for traces at runtime. >>

Re: [PATCH] trace/simple: Allow enabling simple traces from command line

2020-08-04 Thread Josh DuBois
On Aug 3, 2020, at 4:08 AM, Markus Armbruster wrote: > >> >> - prior to db25d56c014aa1a96319c663e0a60346a223b31e, just like today, >> QEMU built with simple tracing will always produce a trace- file, >> regardless of whether the user asks for traces at runtime. > > When you send a patch with a

Re: [PATCH] trace/simple: Allow enabling simple traces from command line

2020-08-03 Thread Markus Armbruster
Josh DuBois writes: > Well, this is a bit embarrassing.  The patch below simply > re-introduced the bug which the Fixes: line was trying to fix in the > first place. > > I.e, : > > - with my patch (just committed as > 1b7157be3a8c4300fc8044d40f4b2e64a152a1b4) applied, a QEMU built with > simple

Re: [PATCH] trace/simple: Allow enabling simple traces from command line

2020-07-30 Thread Josh DuBois
Well, this is a bit embarrassing.  The patch below simply re-introduced the bug which the Fixes: line was trying to fix in the first place. I.e, : - with my patch (just committed as 1b7157be3a8c4300fc8044d40f4b2e64a152a1b4) applied, a QEMU built with simple tracing will always produce a

Re: [PATCH] trace/simple: Allow enabling simple traces from command line

2020-07-29 Thread Stefan Hajnoczi
On Thu, Jul 23, 2020 at 12:33:59AM -0500, Josh DuBois wrote: > The simple trace backend is enabled / disabled with a call > to st_set_trace_file_enabled(). When initializing tracing > from the command-line, this must be enabled on startup. > (Prior to db25d56c014aa1a9, command-line initialization

[PATCH] trace/simple: Allow enabling simple traces from command line

2020-07-23 Thread Josh DuBois
The simple trace backend is enabled / disabled with a call to st_set_trace_file_enabled(). When initializing tracing from the command-line, this must be enabled on startup. (Prior to db25d56c014aa1a9, command-line initialization of simple trace worked because every call to st_set_trace_file