Re: [PATCH] ui/cocoa: Set UI information

2022-02-14 Thread Gerd Hoffmann
On Mon, Feb 14, 2022 at 10:43:32AM +, Peter Maydell wrote: > On Mon, 14 Feb 2022 at 10:27, Gerd Hoffmann wrote: > > > > > (2) A question for Gerd: > > > Is it safe to call dpy_set_ui_info() from a non-QEMU-main-thread? > > > > No. > > Is it OK to do so if the other thread is holding the iothr

Re: [PATCH] ui/cocoa: Set UI information

2022-02-14 Thread Peter Maydell
On Mon, 14 Feb 2022 at 10:27, Gerd Hoffmann wrote: > > > (2) A question for Gerd: > > Is it safe to call dpy_set_ui_info() from a non-QEMU-main-thread? > > No. Is it OK to do so if the other thread is holding the iothread lock? (This is how we do a lot of the other "need to call a QEMU function"

Re: [PATCH] ui/cocoa: Set UI information

2022-02-14 Thread Gerd Hoffmann
> (2) A question for Gerd: > Is it safe to call dpy_set_ui_info() from a non-QEMU-main-thread? No. take care, Gerd

Re: [PATCH] ui/cocoa: Set UI information

2022-02-09 Thread Akihiko Odaki
On Wed, Feb 9, 2022 at 3:07 AM Peter Maydell wrote: > > On Sat, 5 Feb 2022 at 02:06, Akihiko Odaki wrote: > > > > On Sat, Feb 5, 2022 at 1:19 AM Peter Maydell > > wrote > > > > (1) A question for Akihiko: > > > Are all the cocoa calls we make in updateUIInfo safe to > > > make from a non-UI thr

Re: [PATCH] ui/cocoa: Set UI information

2022-02-08 Thread Peter Maydell
On Sat, 5 Feb 2022 at 02:06, Akihiko Odaki wrote: > > On Sat, Feb 5, 2022 at 1:19 AM Peter Maydell wrote > > (1) A question for Akihiko: > > Are all the cocoa calls we make in updateUIInfo safe to > > make from a non-UI thread? Would it be preferable for this > > call in cocoa_switch() to be mov

Re: [PATCH] ui/cocoa: Set UI information

2022-02-04 Thread Akihiko Odaki
On Sat, Feb 5, 2022 at 1:19 AM Peter Maydell wrote: > > On Wed, 16 Jun 2021 at 15:19, Akihiko Odaki wrote: > > > > Signed-off-by: Akihiko Odaki > > --- > > ui/cocoa.m | 49 + > > 1 file changed, 49 insertions(+) > > Hi; I was looking at the cocoa.

Re: [PATCH] ui/cocoa: Set UI information

2022-02-04 Thread Peter Maydell
On Wed, 16 Jun 2021 at 15:19, Akihiko Odaki wrote: > > Signed-off-by: Akihiko Odaki > --- > ui/cocoa.m | 49 + > 1 file changed, 49 insertions(+) Hi; I was looking at the cocoa.m code to see about maybe deleting the unnecessary autorelease pools,

Re: [PATCH] ui/cocoa: Set UI information

2021-06-23 Thread Gerd Hoffmann
On Wed, Jun 16, 2021 at 11:19:10PM +0900, Akihiko Odaki wrote: > Signed-off-by: Akihiko Odaki > --- > ui/cocoa.m | 49 + > 1 file changed, 49 insertions(+) > > diff --git a/ui/cocoa.m b/ui/cocoa.m > index 995301502be..8b83f91723a 100644 > --- a/ui/

[PATCH] ui/cocoa: Set UI information

2021-06-16 Thread Akihiko Odaki
Signed-off-by: Akihiko Odaki --- ui/cocoa.m | 49 + 1 file changed, 49 insertions(+) diff --git a/ui/cocoa.m b/ui/cocoa.m index 995301502be..8b83f91723a 100644 --- a/ui/cocoa.m +++ b/ui/cocoa.m @@ -540,6 +540,43 @@ - (void) setContentDimensions