Re: [PATCH] ui/cocoa: Support hardware cursor interface

2022-10-30 Thread Akihiko Odaki
On 2022/10/30 19:12, Elliot Nunn wrote: Akihiko, Sounds like you've done a lot of work on ui/cocoa, with the goal of improving the experience with modern Linux guests. My goal is to improve the experience with antiquated Mac OS 9 guests. My patch has been only tested with recent Linux, but it

Re: [PATCH] ui/cocoa: Support hardware cursor interface

2022-10-30 Thread Peter Maydell
On Sun, 30 Oct 2022 at 11:20, BALATON Zoltan wrote: > I'm not sure about this and may be wrong but I have a theory that the > problems with mouse tracking are caused by not taking mouse ponter > acceleration into account correctly. I did not check it and can't prove it > but I think the guest and

Re: [PATCH] ui/cocoa: Support hardware cursor interface

2022-10-30 Thread BALATON Zoltan
On Sun, 30 Oct 2022, Akihiko Odaki wrote: On 2022/10/30 14:20, Elliot Nunn wrote: Akihiko, Thanks very much for reviewing my patch. I think that you were right to use the sprite-within-a-window approach, and avoid warping the OS cursor. I tried to compensate for the error that cursor warping

Re: [PATCH] ui/cocoa: Support hardware cursor interface

2022-10-30 Thread Elliot Nunn
Akihiko, Sounds like you've done a lot of work on ui/cocoa, with the goal of improving the experience with modern Linux guests. My goal is to improve the experience with antiquated Mac OS 9 guests. > My patch has been only tested with recent Linux, but it certainly should > be ensured that it

Re: [PATCH] ui/cocoa: Support hardware cursor interface

2022-10-30 Thread Akihiko Odaki
Hi, On 2022/10/30 14:20, Elliot Nunn wrote: Akihiko, Thanks very much for reviewing my patch. I think that you were right to use the sprite-within-a-window approach, and avoid warping the OS cursor. I tried to compensate for the error that cursor warping causes in the subsequent mouse event,

Re: [PATCH] ui/cocoa: Support hardware cursor interface

2022-10-29 Thread Elliot Nunn
Akihiko, Thanks very much for reviewing my patch. I think that you were right to use the sprite-within-a-window approach, and avoid warping the OS cursor. I tried to compensate for the error that cursor warping causes in the subsequent mouse event, but there is still some error getting through

Re: [PATCH] ui/cocoa: Support hardware cursor interface

2022-10-06 Thread Peter Maydell
On Thu, 6 Oct 2022 at 13:16, Akihiko Odaki wrote: > > Thanks Peter and Elliot, > > Unfortunately Patchew seems to have failed to apply the patch to the > current master. It would be nice if you rebase it to the current > master. I think this is probably mostly because the patch got sent in

Re: [PATCH] ui/cocoa: Support hardware cursor interface

2022-10-06 Thread Akihiko Odaki
Thanks Peter and Elliot, Unfortunately Patchew seems to have failed to apply the patch to the current master. It would be nice if you rebase it to the current master. Actually I have a patch to add hardware support to ui/cocoa, but I have not submitted to the mailing list because it depends on a

Re: [PATCH] ui/cocoa: Support hardware cursor interface

2022-10-04 Thread Peter Maydell
Ccing Akihiko to see if he wants to review this cocoa ui frontend patch. also available at: https://lore.kernel.org/qemu-devel/54930451-d85f-4ce0-9a45-b3478c5a6...@www.fastmail.com/ I can confirm that the patch does build, but I don't have any interesting graphics-using test images to hand to

Re: [PATCH] ui/cocoa: Support hardware cursor interface

2022-08-27 Thread Elliot Nunn
Resending this patch now that 7.1 is released (well done). > On 4 Aug 2022, at 2:27 pm, Elliot Nunn wrote: > > Implement dpy_cursor_define() and dpy_mouse_set() on macOS. > > The main benefit is from dpy_cursor_define: in absolute pointing mode, the > host can redraw the cursor on the guest's

[PATCH] ui/cocoa: Support hardware cursor interface

2022-08-04 Thread Elliot Nunn
Implement dpy_cursor_define() and dpy_mouse_set() on macOS. The main benefit is from dpy_cursor_define: in absolute pointing mode, the host can redraw the cursor on the guest's behalf much faster than the guest can itself. To provide the programmatic movement expected from a hardware cursor,