Re: [PATCH] vfio/pci: Don't remove irqchip notifier if not registered

2020-01-07 Thread Peter Xu
On Mon, Jan 06, 2020 at 03:13:24PM -0700, Alex Williamson wrote: > On Tue, 31 Dec 2019 08:39:15 -0500 > Peter Xu wrote: > > > The kvm irqchip notifier is only registered if the device supports > > INTx, however it's unconditionally removed. If the assigned device > > does not support INTx, this

Re: [PATCH] vfio/pci: Don't remove irqchip notifier if not registered

2020-01-06 Thread Alex Williamson
On Tue, 31 Dec 2019 08:39:15 -0500 Peter Xu wrote: > The kvm irqchip notifier is only registered if the device supports > INTx, however it's unconditionally removed. If the assigned device > does not support INTx, this will cause QEMU to crash when unplugging > the device from the system.

Re: [PATCH] vfio/pci: Don't remove irqchip notifier if not registered

2020-01-06 Thread Greg Kurz
On Tue, 31 Dec 2019 08:39:15 -0500 Peter Xu wrote: > The kvm irqchip notifier is only registered if the device supports > INTx, however it's unconditionally removed. If the assigned device > does not support INTx, this will cause QEMU to crash when unplugging > the device from the system.

Re: [PATCH] vfio/pci: Don't remove irqchip notifier if not registered

2020-01-01 Thread David Gibson
On Tue, Dec 31, 2019 at 08:39:15AM -0500, Peter Xu wrote: > The kvm irqchip notifier is only registered if the device supports > INTx, however it's unconditionally removed. If the assigned device > does not support INTx, this will cause QEMU to crash when unplugging > the device from the system.

[PATCH] vfio/pci: Don't remove irqchip notifier if not registered

2019-12-31 Thread Peter Xu
The kvm irqchip notifier is only registered if the device supports INTx, however it's unconditionally removed. If the assigned device does not support INTx, this will cause QEMU to crash when unplugging the device from the system. Change it to conditionally remove the notifier only if the notify