Re: [PATCH] vhost: release memory objects in error path

2023-05-26 Thread Peter Xu
On Fri, May 26, 2023 at 12:24:07PM +0530, Prasad Pandit wrote: > Hello Peter, all > > On Thu, 25 May 2023 at 18:33, Peter Xu wrote: > > > IIRC this bug used to only reproduce on rt kernels, is it still the case? > > > > * Yes, it's a same crash. > > > > Here besides doing correct unregister,

Re: [PATCH] vhost: release memory objects in error path

2023-05-26 Thread Prasad Pandit
Hello Peter, all On Thu, 25 May 2023 at 18:33, Peter Xu wrote: > IIRC this bug used to only reproduce on rt kernels, is it still the case? > * Yes, it's a same crash. > Here besides doing correct unregister, does it also mean that even if > event_notifier_init() failed there's totally no

Re: [PATCH] vhost: release memory objects in error path

2023-05-25 Thread Peter Xu
Hi, Prasad, On Mon, May 22, 2023 at 11:40:21PM +0530, P J P wrote: > From: Prasad Pandit > > vhost_dev_start function does not release memory objects in case > of an error. This may crash the guest with: > > stack trace of thread 125653: > Program terminated with signal SIGSEGV,

[PATCH] vhost: release memory objects in error path

2023-05-22 Thread P J P
From: Prasad Pandit vhost_dev_start function does not release memory objects in case of an error. This may crash the guest with: stack trace of thread 125653: Program terminated with signal SIGSEGV, Segmentation fault #0 memory_listener_register (qemu-kvm + 0x6cda0f) #1