Re: [PATCH] virtio-blk: do not use C99 mixed declarations

2024-02-07 Thread Kevin Wolf
Am 06.02.2024 um 15:04 hat Stefan Hajnoczi geschrieben: > QEMU's coding style generally forbids C99 mixed declarations. > > Signed-off-by: Stefan Hajnoczi Thanks, applied to the block branch. Kevin

Re: [PATCH] virtio-blk: do not use C99 mixed declarations

2024-02-06 Thread Stefan Hajnoczi
On Tue, Feb 06, 2024 at 10:57:37AM -0500, Michael S. Tsirkin wrote: > On Tue, Feb 06, 2024 at 09:04:09AM -0500, Stefan Hajnoczi wrote: > > QEMU's coding style generally forbids C99 mixed declarations. > > > > Signed-off-by: Stefan Hajnoczi > > Acked-by: Michael S. Tsirkin > > or maybe it's

Re: [PATCH] virtio-blk: do not use C99 mixed declarations

2024-02-06 Thread Michael S. Tsirkin
On Tue, Feb 06, 2024 at 09:04:09AM -0500, Stefan Hajnoczi wrote: > QEMU's coding style generally forbids C99 mixed declarations. > > Signed-off-by: Stefan Hajnoczi Acked-by: Michael S. Tsirkin or maybe it's time we moved on? > --- > hw/block/virtio-blk.c | 25 ++--- > 1

Re: [PATCH] virtio-blk: do not use C99 mixed declarations

2024-02-06 Thread Hanna Czenczek
On 06.02.24 15:04, Stefan Hajnoczi wrote: QEMU's coding style generally forbids C99 mixed declarations. Signed-off-by: Stefan Hajnoczi --- hw/block/virtio-blk.c | 25 ++--- 1 file changed, 14 insertions(+), 11 deletions(-) Reviewed-by: Hanna Czenczek

[PATCH] virtio-blk: do not use C99 mixed declarations

2024-02-06 Thread Stefan Hajnoczi
QEMU's coding style generally forbids C99 mixed declarations. Signed-off-by: Stefan Hajnoczi --- hw/block/virtio-blk.c | 25 ++--- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c index 227d83569f..f6009cd9b3