Re: [PATCH] virtio-pci: fix queue_enable write

2020-06-10 Thread Jason Wang
On 2020/6/10 下午12:16, Michael S. Tsirkin wrote: On Wed, Jun 10, 2020 at 10:03:28AM +0800, Jason Wang wrote: On 2020/6/9 下午11:43, Michael S. Tsirkin wrote: On Fri, May 29, 2020 at 11:07:28AM +0800, Jason Wang wrote: Spec said: The driver uses this to selectively prevent the device from

Re: [PATCH] virtio-pci: fix queue_enable write

2020-06-09 Thread Michael S. Tsirkin
On Wed, Jun 10, 2020 at 10:03:28AM +0800, Jason Wang wrote: > > On 2020/6/9 下午11:43, Michael S. Tsirkin wrote: > > On Fri, May 29, 2020 at 11:07:28AM +0800, Jason Wang wrote: > > > Spec said: The driver uses this to selectively prevent the device from > > > executing requests from this virtqueue.

Re: [PATCH] virtio-pci: fix queue_enable write

2020-06-09 Thread Jason Wang
On 2020/6/9 下午11:43, Michael S. Tsirkin wrote: On Fri, May 29, 2020 at 11:07:28AM +0800, Jason Wang wrote: Spec said: The driver uses this to selectively prevent the device from executing requests from this virtqueue. 1 - enabled; 0 - disabled. Though write 0 to queue_enable is forbidden by

Re: [PATCH] virtio-pci: fix queue_enable write

2020-06-09 Thread Michael S. Tsirkin
On Fri, May 29, 2020 at 11:07:28AM +0800, Jason Wang wrote: > Spec said: The driver uses this to selectively prevent the device from > executing requests from this virtqueue. 1 - enabled; 0 - disabled. > > Though write 0 to queue_enable is forbidden by the sepc, we should not spec? > assume

Re: [PATCH] virtio-pci: fix queue_enable write

2020-05-29 Thread Stefan Hajnoczi
On Fri, May 29, 2020 at 11:07:28AM +0800, Jason Wang wrote: > Spec said: The driver uses this to selectively prevent the device from > executing requests from this virtqueue. 1 - enabled; 0 - disabled. > > Though write 0 to queue_enable is forbidden by the sepc, we should not > assume that the

[PATCH] virtio-pci: fix queue_enable write

2020-05-28 Thread Jason Wang
Spec said: The driver uses this to selectively prevent the device from executing requests from this virtqueue. 1 - enabled; 0 - disabled. Though write 0 to queue_enable is forbidden by the sepc, we should not assume that the value is 1. Fix this by ignoring the write value other than 1. Cc: