Re: [PATCH] vl: fix machine option containing underscores

2021-08-10 Thread Paolo Bonzini
On 10/08/21 15:12, Jean-Philippe Brucker wrote: My first take was renaming default_bus_bypass_iommu, since it's the only machine option with underscores, We should do that, since the underscore variant still works and the result is a simple one-line patch. Paolo but then we'd want to

Re: [PATCH] vl: fix machine option containing underscores

2021-08-10 Thread Philippe Mathieu-Daudé
+Paolo/Markus On 8/10/21 3:12 PM, Jean-Philippe Brucker wrote: > Since commit d8fb7d0969d5 ("vl: switch -M parsing to keyval"), > keyval_dashify() replaces all underscores with dashes in machine > options. As a result the machine option "default_bus_bypass_iommu", > which was introduced in the

[PATCH] vl: fix machine option containing underscores

2021-08-10 Thread Jean-Philippe Brucker
Since commit d8fb7d0969d5 ("vl: switch -M parsing to keyval"), keyval_dashify() replaces all underscores with dashes in machine options. As a result the machine option "default_bus_bypass_iommu", which was introduced in the same release (c9e96b04fc19 6d7a85483a06), is not recognized: $