Re: [PATCH-for-5.1] hw/nvram/fw_cfg: Let fw_cfg_add_from_generator() return boolean value

2020-07-23 Thread Laszlo Ersek
+Igor, and question below On 07/23/20 09:37, Markus Armbruster wrote: > You must use ERRP_GUARD() in functions that dereference their @errp > parameter (so that works even when the argument is null) or pass it to > error_prepend() or error_append_hint() (so they get reached even when > the

Re: [PATCH-for-5.1] hw/nvram/fw_cfg: Let fw_cfg_add_from_generator() return boolean value

2020-07-23 Thread Markus Armbruster
Cc: Vladimir Laszlo Ersek writes: > On 07/21/20 10:33, Markus Armbruster wrote: >> Laszlo Ersek writes: >> >>> On 07/20/20 14:35, Philippe Mathieu-Daudé wrote: Commits b6d7e9b66f..a43770df5d simplified the error propagation. Similarly to commit 6fd5bef10b "qom: Make functions taking

Re: [PATCH-for-5.1] hw/nvram/fw_cfg: Let fw_cfg_add_from_generator() return boolean value

2020-07-22 Thread Laszlo Ersek
On 07/21/20 10:33, Markus Armbruster wrote: > Laszlo Ersek writes: > >> On 07/20/20 14:35, Philippe Mathieu-Daudé wrote: >>> Commits b6d7e9b66f..a43770df5d simplified the error propagation. >>> Similarly to commit 6fd5bef10b "qom: Make functions taking Error** >>> return bool, not void", let

Re: [PATCH-for-5.1] hw/nvram/fw_cfg: Let fw_cfg_add_from_generator() return boolean value

2020-07-21 Thread Markus Armbruster
Laszlo Ersek writes: > On 07/20/20 14:35, Philippe Mathieu-Daudé wrote: >> Commits b6d7e9b66f..a43770df5d simplified the error propagation. >> Similarly to commit 6fd5bef10b "qom: Make functions taking Error** >> return bool, not void", let fw_cfg_add_from_generator() return a >> boolean value,

Re: [PATCH-for-5.1] hw/nvram/fw_cfg: Let fw_cfg_add_from_generator() return boolean value

2020-07-20 Thread Laszlo Ersek
On 07/20/20 14:35, Philippe Mathieu-Daudé wrote: > Commits b6d7e9b66f..a43770df5d simplified the error propagation. > Similarly to commit 6fd5bef10b "qom: Make functions taking Error** > return bool, not void", let fw_cfg_add_from_generator() return a > boolean value, not void. > This allow to

[PATCH-for-5.1] hw/nvram/fw_cfg: Let fw_cfg_add_from_generator() return boolean value

2020-07-20 Thread Philippe Mathieu-Daudé
Commits b6d7e9b66f..a43770df5d simplified the error propagation. Similarly to commit 6fd5bef10b "qom: Make functions taking Error** return bool, not void", let fw_cfg_add_from_generator() return a boolean value, not void. This allow to simplify parse_fw_cfg() and fixes the error handling issue