Paolo Bonzini writes:
> On 29/07/20 09:39, Markus Armbruster wrote:
>> Taking a step back, I disagree with the notion that assertions should be
>> avoided just because we have an Error **. A programming error doesn't
>> become less wrong, and continuing when the program is in disorder
>> doesn't
On 29/07/20 09:39, Markus Armbruster wrote:
> Taking a step back, I disagree with the notion that assertions should be
> avoided just because we have an Error **. A programming error doesn't
> become less wrong, and continuing when the program is in disorder
> doesn't become any safer when you add
Philippe Mathieu-Daudé writes:
> On 7/29/20 2:32 PM, Markus Armbruster wrote:
>> Philippe Mathieu-Daudé writes:
>>
>>> On 7/29/20 9:39 AM, Markus Armbruster wrote:
Paolo Bonzini writes:
> On 28/07/20 09:44, Markus Armbruster wrote:
>>> -assert(!DEVICE_GET_CLASS(dev)->
On 7/29/20 2:32 PM, Markus Armbruster wrote:
> Philippe Mathieu-Daudé writes:
>
>> On 7/29/20 9:39 AM, Markus Armbruster wrote:
>>> Paolo Bonzini writes:
>>>
On 28/07/20 09:44, Markus Armbruster wrote:
>> -assert(!DEVICE_GET_CLASS(dev)->bus_type);
>> +} else if (DEVICE_G
Philippe Mathieu-Daudé writes:
> On 7/29/20 9:39 AM, Markus Armbruster wrote:
>> Paolo Bonzini writes:
>>
>>> On 28/07/20 09:44, Markus Armbruster wrote:
> -assert(!DEVICE_GET_CLASS(dev)->bus_type);
> +} else if (DEVICE_GET_CLASS(dev)->bus_type) {
> +error_setg(e
On 7/29/20 9:39 AM, Markus Armbruster wrote:
> Paolo Bonzini writes:
>
>> On 28/07/20 09:44, Markus Armbruster wrote:
-assert(!DEVICE_GET_CLASS(dev)->bus_type);
+} else if (DEVICE_GET_CLASS(dev)->bus_type) {
+error_setg(errp, "Unexpected bus '%s' for bus-less de
Paolo Bonzini writes:
> On 28/07/20 09:44, Markus Armbruster wrote:
>>> -assert(!DEVICE_GET_CLASS(dev)->bus_type);
>>> +} else if (DEVICE_GET_CLASS(dev)->bus_type) {
>>> +error_setg(errp, "Unexpected bus '%s' for bus-less device '%s'",
>>> + DEVICE_GET_CLASS(
On 28/07/20 09:44, Markus Armbruster wrote:
>> -assert(!DEVICE_GET_CLASS(dev)->bus_type);
>> +} else if (DEVICE_GET_CLASS(dev)->bus_type) {
>> +error_setg(errp, "Unexpected bus '%s' for bus-less device '%s'",
>> + DEVICE_GET_CLASS(dev)->bus_type,
>> +
Philippe Mathieu-Daudé writes:
> Since commit 510ef98dca5, qdev_realize() aborts if bus-less
> device is realized on a bus. While commits 514db7710b..007d1dbf72
> took care of converting all mainstream uses, QEMU forks weren't
> converted.
>
> These forks are usually maintained by hobbyist with i
Since commit 510ef98dca5, qdev_realize() aborts if bus-less
device is realized on a bus. While commits 514db7710b..007d1dbf72
took care of converting all mainstream uses, QEMU forks weren't
converted.
These forks are usually maintained by hobbyist with interest in
following mainstream development,
10 matches
Mail list logo