Re: [PATCH-for-5.2 v4] hw/core/qdev: Increase qdev_realize() kindness

2020-07-30 Thread Markus Armbruster
Paolo Bonzini writes: > On 29/07/20 09:39, Markus Armbruster wrote: >> Taking a step back, I disagree with the notion that assertions should be >> avoided just because we have an Error **. A programming error doesn't >> become less wrong, and continuing when the program is in disorder >> doesn't

Re: [PATCH-for-5.2 v4] hw/core/qdev: Increase qdev_realize() kindness

2020-07-29 Thread Paolo Bonzini
On 29/07/20 09:39, Markus Armbruster wrote: > Taking a step back, I disagree with the notion that assertions should be > avoided just because we have an Error **. A programming error doesn't > become less wrong, and continuing when the program is in disorder > doesn't become any safer when you add

Re: [PATCH-for-5.2 v4] hw/core/qdev: Increase qdev_realize() kindness

2020-07-29 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > On 7/29/20 2:32 PM, Markus Armbruster wrote: >> Philippe Mathieu-Daudé writes: >> >>> On 7/29/20 9:39 AM, Markus Armbruster wrote: Paolo Bonzini writes: > On 28/07/20 09:44, Markus Armbruster wrote: >>> -assert(!DEVICE_GET_CLASS(dev)->

Re: [PATCH-for-5.2 v4] hw/core/qdev: Increase qdev_realize() kindness

2020-07-29 Thread Philippe Mathieu-Daudé
On 7/29/20 2:32 PM, Markus Armbruster wrote: > Philippe Mathieu-Daudé writes: > >> On 7/29/20 9:39 AM, Markus Armbruster wrote: >>> Paolo Bonzini writes: >>> On 28/07/20 09:44, Markus Armbruster wrote: >> -assert(!DEVICE_GET_CLASS(dev)->bus_type); >> +} else if (DEVICE_G

Re: [PATCH-for-5.2 v4] hw/core/qdev: Increase qdev_realize() kindness

2020-07-29 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > On 7/29/20 9:39 AM, Markus Armbruster wrote: >> Paolo Bonzini writes: >> >>> On 28/07/20 09:44, Markus Armbruster wrote: > -assert(!DEVICE_GET_CLASS(dev)->bus_type); > +} else if (DEVICE_GET_CLASS(dev)->bus_type) { > +error_setg(e

Re: [PATCH-for-5.2 v4] hw/core/qdev: Increase qdev_realize() kindness

2020-07-29 Thread Philippe Mathieu-Daudé
On 7/29/20 9:39 AM, Markus Armbruster wrote: > Paolo Bonzini writes: > >> On 28/07/20 09:44, Markus Armbruster wrote: -assert(!DEVICE_GET_CLASS(dev)->bus_type); +} else if (DEVICE_GET_CLASS(dev)->bus_type) { +error_setg(errp, "Unexpected bus '%s' for bus-less de

Re: [PATCH-for-5.2 v4] hw/core/qdev: Increase qdev_realize() kindness

2020-07-29 Thread Markus Armbruster
Paolo Bonzini writes: > On 28/07/20 09:44, Markus Armbruster wrote: >>> -assert(!DEVICE_GET_CLASS(dev)->bus_type); >>> +} else if (DEVICE_GET_CLASS(dev)->bus_type) { >>> +error_setg(errp, "Unexpected bus '%s' for bus-less device '%s'", >>> + DEVICE_GET_CLASS(

Re: [PATCH-for-5.2 v4] hw/core/qdev: Increase qdev_realize() kindness

2020-07-28 Thread Paolo Bonzini
On 28/07/20 09:44, Markus Armbruster wrote: >> -assert(!DEVICE_GET_CLASS(dev)->bus_type); >> +} else if (DEVICE_GET_CLASS(dev)->bus_type) { >> +error_setg(errp, "Unexpected bus '%s' for bus-less device '%s'", >> + DEVICE_GET_CLASS(dev)->bus_type, >> +

Re: [PATCH-for-5.2 v4] hw/core/qdev: Increase qdev_realize() kindness

2020-07-28 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > Since commit 510ef98dca5, qdev_realize() aborts if bus-less > device is realized on a bus. While commits 514db7710b..007d1dbf72 > took care of converting all mainstream uses, QEMU forks weren't > converted. > > These forks are usually maintained by hobbyist with i

[PATCH-for-5.2 v4] hw/core/qdev: Increase qdev_realize() kindness

2020-07-27 Thread Philippe Mathieu-Daudé
Since commit 510ef98dca5, qdev_realize() aborts if bus-less device is realized on a bus. While commits 514db7710b..007d1dbf72 took care of converting all mainstream uses, QEMU forks weren't converted. These forks are usually maintained by hobbyist with interest in following mainstream development,