Re: [PATCH v3 7/7] hw/virtio: generalise CHR_EVENT_CLOSED handling

2022-11-30 Thread Alex Bennée
"Michael S. Tsirkin" writes: > On Wed, Nov 30, 2022 at 10:25:58AM +, Alex Bennée wrote: >> >> Raphael Norwitz writes: >> >> >> On Nov 29, 2022, at 12:30 AM, Michael S. Tsirkin wrote: >> >> >> >> On Tue, Nov 29, 2022 at 05:18:58AM +, Raphael Norwitz wrote: >> On Nov 28, 2022,

Re: [PATCH v3 7/7] hw/virtio: generalise CHR_EVENT_CLOSED handling

2022-11-30 Thread Michael S. Tsirkin
On Wed, Nov 30, 2022 at 10:25:58AM +, Alex Bennée wrote: > > Raphael Norwitz writes: > > >> On Nov 29, 2022, at 12:30 AM, Michael S. Tsirkin wrote: > >> > >> On Tue, Nov 29, 2022 at 05:18:58AM +, Raphael Norwitz wrote: > On Nov 28, 2022, at 11:41 AM, Alex Bennée wrote: > >

Re: [PATCH v3 7/7] hw/virtio: generalise CHR_EVENT_CLOSED handling

2022-11-30 Thread Alex Bennée
Raphael Norwitz writes: >> On Nov 29, 2022, at 12:30 AM, Michael S. Tsirkin wrote: >> >> On Tue, Nov 29, 2022 at 05:18:58AM +, Raphael Norwitz wrote: On Nov 28, 2022, at 11:41 AM, Alex Bennée wrote: ..and use for both virtio-user-blk and virtio-user-gpio. This avoids

Re: [PATCH v3 7/7] hw/virtio: generalise CHR_EVENT_CLOSED handling

2022-11-29 Thread Raphael Norwitz
> On Nov 29, 2022, at 12:30 AM, Michael S. Tsirkin wrote: > > On Tue, Nov 29, 2022 at 05:18:58AM +, Raphael Norwitz wrote: >>> On Nov 28, 2022, at 11:41 AM, Alex Bennée wrote: >>> >>> ..and use for both virtio-user-blk and virtio-user-gpio. This avoids >>> the circular close by deferring

Re: [PATCH v3 7/7] hw/virtio: generalise CHR_EVENT_CLOSED handling

2022-11-28 Thread Michael S. Tsirkin
On Tue, Nov 29, 2022 at 05:18:58AM +, Raphael Norwitz wrote: > > On Nov 28, 2022, at 11:41 AM, Alex Bennée wrote: > > > > ..and use for both virtio-user-blk and virtio-user-gpio. This avoids > > the circular close by deferring shutdown due to disconnection until a > > later point.

Re: [PATCH v3 7/7] hw/virtio: generalise CHR_EVENT_CLOSED handling

2022-11-28 Thread Raphael Norwitz
> On Nov 28, 2022, at 11:41 AM, Alex Bennée wrote: > > ..and use for both virtio-user-blk and virtio-user-gpio. This avoids > the circular close by deferring shutdown due to disconnection until a > later point. virtio-user-blk already had this mechanism in place so The mechanism was originally

[PATCH v3 7/7] hw/virtio: generalise CHR_EVENT_CLOSED handling

2022-11-28 Thread Alex Bennée
..and use for both virtio-user-blk and virtio-user-gpio. This avoids the circular close by deferring shutdown due to disconnection until a later point. virtio-user-blk already had this mechanism in place so generalise it as a vhost-user helper function and use for both blk and gpio devices. While